[INFO] cloning repository https://github.com/bytel0rd/oba [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/bytel0rd/oba" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbytel0rd%2Foba", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbytel0rd%2Foba'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 03082e5babc1402b6b7c251a17dd46d6aba60f03 [INFO] checking bytel0rd/oba/03082e5babc1402b6b7c251a17dd46d6aba60f03 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbytel0rd%2Foba" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/bytel0rd/oba on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/bytel0rd/oba [INFO] finished tweaking git repo https://github.com/bytel0rd/oba [INFO] tweaked toml for git repo https://github.com/bytel0rd/oba written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/bytel0rd/oba already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4eabc4e8b12854252f3bc826a22a27346fb1e9fa4b11be4d4385d5e60eceb374 [INFO] running `Command { std: "docker" "start" "-a" "4eabc4e8b12854252f3bc826a22a27346fb1e9fa4b11be4d4385d5e60eceb374", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4eabc4e8b12854252f3bc826a22a27346fb1e9fa4b11be4d4385d5e60eceb374", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4eabc4e8b12854252f3bc826a22a27346fb1e9fa4b11be4d4385d5e60eceb374", kill_on_drop: false }` [INFO] [stdout] 4eabc4e8b12854252f3bc826a22a27346fb1e9fa4b11be4d4385d5e60eceb374 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d8cb62e4389e9b6c9e9fad267d23e4421e400b234346b747458be0b818a74d05 [INFO] running `Command { std: "docker" "start" "-a" "d8cb62e4389e9b6c9e9fad267d23e4421e400b234346b747458be0b818a74d05", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] [stderr] Compiling proc-macro2 v1.0.81 [INFO] [stderr] Compiling libc v0.2.154 [INFO] [stderr] Compiling serde v1.0.201 [INFO] [stderr] Compiling rustversion v1.0.15 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling thiserror v1.0.60 [INFO] [stderr] Compiling anyhow v1.0.83 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking xxhash-rust v0.8.10 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.60 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking socket2 v0.5.6 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking uuid v1.8.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot v0.12.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling serde_derive v1.0.201 [INFO] [stderr] Compiling strum_macros v0.26.2 [INFO] [stderr] Compiling thiserror-impl v1.0.60 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking strum v0.26.2 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Checking oba_network v0.1.0 (/opt/rustwide/workdir/network) [INFO] [stdout] warning: unused import: `Read` [INFO] [stdout] --> network/src/encoding.rs:1:23 [INFO] [stdout] | [INFO] [stdout] 1 | use std::io::{Cursor, Read}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Bytes` [INFO] [stdout] --> network/src/encoding.rs:4:21 [INFO] [stdout] | [INFO] [stdout] 4 | use bytes::{BufMut, Bytes, BytesMut}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::error::Error` [INFO] [stdout] --> network/src/commons.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::error::Error; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Read` [INFO] [stdout] --> network/src/encoding.rs:1:23 [INFO] [stdout] | [INFO] [stdout] 1 | use std::io::{Cursor, Read}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Bytes` [INFO] [stdout] --> network/src/encoding.rs:4:21 [INFO] [stdout] | [INFO] [stdout] 4 | use bytes::{BufMut, Bytes, BytesMut}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::error::Error` [INFO] [stdout] --> network/src/commons.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::error::Error; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> network/src/encoding.rs:73:13 [INFO] [stdout] | [INFO] [stdout] 73 | let mut delimiter = buf.get(cursor_start..cursor_end); [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> network/src/encoding.rs:167:17 [INFO] [stdout] | [INFO] [stdout] 167 | let (_, mut data_part) = buf.split_at_mut(cursor_end); [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> network/src/encoding.rs:73:13 [INFO] [stdout] | [INFO] [stdout] 73 | let mut delimiter = buf.get(cursor_start..cursor_end); [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> network/src/encoding.rs:167:17 [INFO] [stdout] | [INFO] [stdout] 167 | let (_, mut data_part) = buf.split_at_mut(cursor_end); [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> network/src/encoding.rs:227:13 [INFO] [stdout] | [INFO] [stdout] 227 | let mut delimiter = b"!CZ~"; [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> network/src/encoding.rs:228:13 [INFO] [stdout] | [INFO] [stdout] 228 | let mut delimiter_length = delimiter.len(); [INFO] [stdout] | ----^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> network/src/encoding.rs:327:13 [INFO] [stdout] | [INFO] [stdout] 327 | let mut buf = raw_byte.as_mut_slice(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> network/src/encoding.rs:343:13 [INFO] [stdout] | [INFO] [stdout] 343 | let mut buf = raw_byte.as_mut_slice(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> network/src/encoding.rs:359:13 [INFO] [stdout] | [INFO] [stdout] 359 | let mut buf = raw_byte.as_mut_slice(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> network/src/encoding.rs:370:13 [INFO] [stdout] | [INFO] [stdout] 370 | let mut buf = &mut byte_stream; [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> network/src/encoding.rs:386:13 [INFO] [stdout] | [INFO] [stdout] 386 | let mut byte_stream = byte_stream.as_mut_slice(); [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `result` [INFO] [stdout] --> network/src/encoding.rs:426:13 [INFO] [stdout] | [INFO] [stdout] 426 | let result = encoding.read_from_stream(byte_stream); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_result` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `result` [INFO] [stdout] --> network/src/encoding.rs:440:13 [INFO] [stdout] | [INFO] [stdout] 440 | let result = encoding.read_from_stream(byte_stream); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_result` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> network/src/commons.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn new(operation: OperationType, data: T) -> anyhow::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | Ok(Message { [INFO] [stdout] | ____________^ [INFO] [stdout] 39 | | operation, [INFO] [stdout] 40 | | data, [INFO] [stdout] 41 | | timestamp: Some(chrono::Utc::now().timestamp()), [INFO] [stdout] 42 | | id: Some(uuid::Uuid::new_v4().to_string()), [INFO] [stdout] 43 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `oba_network` (lib) due to 2 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> network/src/encoding.rs:267:9 [INFO] [stdout] | [INFO] [stdout] 267 | delimiter.read_to_string(&mut version_str); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 267 | let _ = delimiter.read_to_string(&mut version_str); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> network/src/encoding.rs:296:57 [INFO] [stdout] | [INFO] [stdout] 296 | let data_length = u32::from_be_bytes(data_length.clone().try_into().unwrap()); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `[u8]` does not implement `Clone`, so calling `clone` on `&[u8]` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> network/src/commons.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn new(operation: OperationType, data: T) -> anyhow::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | Ok(Message { [INFO] [stdout] | ____________^ [INFO] [stdout] 39 | | operation, [INFO] [stdout] 40 | | data, [INFO] [stdout] 41 | | timestamp: Some(chrono::Utc::now().timestamp()), [INFO] [stdout] 42 | | id: Some(uuid::Uuid::new_v4().to_string()), [INFO] [stdout] 43 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 16 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `oba_network` (lib test) due to 2 previous errors; 16 warnings emitted [INFO] running `Command { std: "docker" "inspect" "d8cb62e4389e9b6c9e9fad267d23e4421e400b234346b747458be0b818a74d05", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d8cb62e4389e9b6c9e9fad267d23e4421e400b234346b747458be0b818a74d05", kill_on_drop: false }` [INFO] [stdout] d8cb62e4389e9b6c9e9fad267d23e4421e400b234346b747458be0b818a74d05