[INFO] cloning repository https://github.com/byo-os/byo-os [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/byo-os/byo-os" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbyo-os%2Fbyo-os", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbyo-os%2Fbyo-os'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] a690394b45a0af3e11a124f71888a4787fb0aab9 [INFO] checking byo-os/byo-os/a690394b45a0af3e11a124f71888a4787fb0aab9 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbyo-os%2Fbyo-os" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/byo-os/byo-os on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/byo-os/byo-os [INFO] finished tweaking git repo https://github.com/byo-os/byo-os [INFO] tweaked toml for git repo https://github.com/byo-os/byo-os written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/byo-os/byo-os already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0ece05b022926f7cb0d38f76037059d426f0a2b7d506749e5d0cd4bccc7b2363 [INFO] running `Command { std: "docker" "start" "-a" "0ece05b022926f7cb0d38f76037059d426f0a2b7d506749e5d0cd4bccc7b2363", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0ece05b022926f7cb0d38f76037059d426f0a2b7d506749e5d0cd4bccc7b2363", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0ece05b022926f7cb0d38f76037059d426f0a2b7d506749e5d0cd4bccc7b2363", kill_on_drop: false }` [INFO] [stdout] 0ece05b022926f7cb0d38f76037059d426f0a2b7d506749e5d0cd4bccc7b2363 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e8f4508875f325c331ae1739ef50c2c3eb15970bd665134cced3305737d61f4e [INFO] running `Command { std: "docker" "start" "-a" "e8f4508875f325c331ae1739ef50c2c3eb15970bd665134cced3305737d61f4e", kill_on_drop: false }` [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking parking v2.2.0 [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling semver v1.0.21 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling paste v1.0.14 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Compiling serde v1.0.196 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Compiling thiserror v1.0.57 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking piper v0.2.1 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking concurrent-queue v2.4.0 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking futures-lite v2.2.0 [INFO] [stderr] Checking event-listener v4.0.3 [INFO] [stderr] Checking event-listener v5.0.0 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking event-listener-strategy v0.5.0 [INFO] [stderr] Checking event-listener-strategy v0.4.0 [INFO] [stderr] Compiling interprocess v1.2.1 [INFO] [stderr] Checking async-channel v2.2.0 [INFO] [stderr] Compiling syn v2.0.49 [INFO] [stderr] Checking async-lock v3.3.0 [INFO] [stderr] Checking async-task v4.7.0 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking spinning v0.1.0 [INFO] [stderr] Checking to_method v1.1.0 [INFO] [stderr] Checking intmap v0.7.1 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking blocking v1.5.1 [INFO] [stderr] Checking rmp v0.8.12 [INFO] [stderr] Compiling thiserror-impl v1.0.57 [INFO] [stderr] Checking rmp-serde v0.15.5 [INFO] [stderr] Checking byo_ipc v0.1.0 (/opt/rustwide/workdir/crates/byo_ipc) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/byo_ipc/src/base.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 27 | let listener = match transport { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | let listener = LocalSocketListener::bind(url.path())?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | let listener = LocalSocketListener::bind(format!("@{}", url.path()))?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let listener = TcpListener::bind(format!( [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | Ok(IpcServer { [INFO] [stdout] | ____________^ [INFO] [stdout] 49 | | listener, [INFO] [stdout] 50 | | format, [INFO] [stdout] 51 | | _phantom: PhantomData, [INFO] [stdout] 52 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/byo_ipc/src/base.rs:174:12 [INFO] [stdout] | [INFO] [stdout] 152 | let stream = match transport { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 155 | let stream = LocalSocketStream::connect(url.path())?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | let stream = LocalSocketStream::connect(format!("@{}", url.path())).unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 164 | let stream = TcpStream::connect(format!( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 174 | Ok(IpcConnection { [INFO] [stdout] | ____________^ [INFO] [stdout] 175 | | stream, [INFO] [stdout] 176 | | format, [INFO] [stdout] 177 | | _phantom: PhantomData, [INFO] [stdout] 178 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/byo_ipc/src/envelope.rs:66:30 [INFO] [stdout] | [INFO] [stdout] 66 | .or_else(|_| Err(IpcError::RegistryPoisoned))? [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/byo_ipc/src/envelope.rs:76:30 [INFO] [stdout] | [INFO] [stdout] 76 | .or_else(|_| Err(IpcError::RegistryPoisoned))? [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `byo_ipc` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/byo_ipc/src/base.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 27 | let listener = match transport { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | let listener = LocalSocketListener::bind(url.path())?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | let listener = LocalSocketListener::bind(format!("@{}", url.path()))?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let listener = TcpListener::bind(format!( [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | Ok(IpcServer { [INFO] [stdout] | ____________^ [INFO] [stdout] 49 | | listener, [INFO] [stdout] 50 | | format, [INFO] [stdout] 51 | | _phantom: PhantomData, [INFO] [stdout] 52 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/byo_ipc/src/base.rs:174:12 [INFO] [stdout] | [INFO] [stdout] 152 | let stream = match transport { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 155 | let stream = LocalSocketStream::connect(url.path())?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | let stream = LocalSocketStream::connect(format!("@{}", url.path())).unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 164 | let stream = TcpStream::connect(format!( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 174 | Ok(IpcConnection { [INFO] [stdout] | ____________^ [INFO] [stdout] 175 | | stream, [INFO] [stdout] 176 | | format, [INFO] [stdout] 177 | | _phantom: PhantomData, [INFO] [stdout] 178 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/byo_ipc/src/envelope.rs:66:30 [INFO] [stdout] | [INFO] [stdout] 66 | .or_else(|_| Err(IpcError::RegistryPoisoned))? [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/byo_ipc/src/envelope.rs:76:30 [INFO] [stdout] | [INFO] [stdout] 76 | .or_else(|_| Err(IpcError::RegistryPoisoned))? [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `byo_ipc` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "e8f4508875f325c331ae1739ef50c2c3eb15970bd665134cced3305737d61f4e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e8f4508875f325c331ae1739ef50c2c3eb15970bd665134cced3305737d61f4e", kill_on_drop: false }` [INFO] [stdout] e8f4508875f325c331ae1739ef50c2c3eb15970bd665134cced3305737d61f4e