[INFO] cloning repository https://github.com/bxb100/rsatv [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/bxb100/rsatv" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbxb100%2Frsatv", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbxb100%2Frsatv'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 7e5b65b71a7fab10fa697559dc0fb7008a852cea [INFO] checking bxb100/rsatv/7e5b65b71a7fab10fa697559dc0fb7008a852cea against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbxb100%2Frsatv" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/bxb100/rsatv on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/bxb100/rsatv [INFO] finished tweaking git repo https://github.com/bxb100/rsatv [INFO] tweaked toml for git repo https://github.com/bxb100/rsatv written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/bxb100/rsatv already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2927c5d14d5a1b75cdaed7136f21d01d9525f53b5613de3971e1b57be382913b [INFO] running `Command { std: "docker" "start" "-a" "2927c5d14d5a1b75cdaed7136f21d01d9525f53b5613de3971e1b57be382913b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2927c5d14d5a1b75cdaed7136f21d01d9525f53b5613de3971e1b57be382913b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2927c5d14d5a1b75cdaed7136f21d01d9525f53b5613de3971e1b57be382913b", kill_on_drop: false }` [INFO] [stdout] 2927c5d14d5a1b75cdaed7136f21d01d9525f53b5613de3971e1b57be382913b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2dc9fd828fffaac20034c8cbdce8b02cac87d1339fc0aa6207facd164c4f0224 [INFO] running `Command { std: "docker" "start" "-a" "2dc9fd828fffaac20034c8cbdce8b02cac87d1339fc0aa6207facd164c4f0224", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.74 [INFO] [stderr] Compiling libc v0.2.152 [INFO] [stderr] Compiling siphasher v0.3.11 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling anyhow v1.0.79 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Checking phf_shared v0.11.2 [INFO] [stderr] Checking rsatv v0.1.0 (/opt/rustwide/workdir/core) [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Compiling syn v2.0.46 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling uuid-macro-internal v1.7.0 [INFO] [stderr] Compiling phf_macros v0.11.2 [INFO] [stderr] Checking uuid v1.7.0 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Checking protocols v0.1.0 (/opt/rustwide/workdir/protocols) [INFO] [stdout] warning: function `key_data` is never used [INFO] [stdout] --> protocols/src/dmap/parser.rs:14:4 [INFO] [stdout] | [INFO] [stdout] 14 | fn key_data(input: &[u8]) -> IResult<&[u8], &str> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `read_usize` is never used [INFO] [stdout] --> protocols/src/dmap/parser.rs:18:4 [INFO] [stdout] | [INFO] [stdout] 18 | fn read_usize(arr: &[u8]) -> anyhow::Result { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `len_data` is never used [INFO] [stdout] --> protocols/src/dmap/parser.rs:32:4 [INFO] [stdout] | [INFO] [stdout] 32 | fn len_data(input: &[u8]) -> IResult<&[u8], u32> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `Container`, `String`, `Uint`, `Bool`, and `Bytes` are never constructed [INFO] [stdout] --> protocols/src/dmap/parser.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 37 | pub enum TagType { [INFO] [stdout] | ------- variants in this enum [INFO] [stdout] 38 | Container(HashMap), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 39 | String(String), [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 40 | Uint(usize), [INFO] [stdout] | ^^^^ [INFO] [stdout] 41 | Bool(bool), [INFO] [stdout] | ^^^^ [INFO] [stdout] 42 | Bytes(Vec), [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TagType` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `tag_container` is never used [INFO] [stdout] --> protocols/src/dmap/parser.rs:45:4 [INFO] [stdout] | [INFO] [stdout] 45 | fn tag_container(tag_name: String, input: &[u8], len: usize) -> IResult<&[u8], (String, TagType)> { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `tag_unit` is never used [INFO] [stdout] --> protocols/src/dmap/parser.rs:64:4 [INFO] [stdout] | [INFO] [stdout] 64 | fn tag_unit(tag_name: String, input: &[u8], len: usize) -> IResult<&[u8], (String, TagType)> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `tag_string` is never used [INFO] [stdout] --> protocols/src/dmap/parser.rs:81:4 [INFO] [stdout] | [INFO] [stdout] 81 | fn tag_string(tag_name: String, input: &[u8], len: usize) -> IResult<&[u8], (String, TagType)> { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `tag_bool` is never used [INFO] [stdout] --> protocols/src/dmap/parser.rs:104:4 [INFO] [stdout] | [INFO] [stdout] 104 | fn tag_bool(tag_name: String, input: &[u8], len: usize) -> IResult<&[u8], (String, TagType)> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `tag_bytes` is never used [INFO] [stdout] --> protocols/src/dmap/parser.rs:121:4 [INFO] [stdout] | [INFO] [stdout] 121 | fn tag_bytes(tag_name: String, input: &[u8], len: usize) -> IResult<&[u8], (String, TagType)> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `map_tag_type` is never used [INFO] [stdout] --> protocols/src/dmap/parser.rs:135:4 [INFO] [stdout] | [INFO] [stdout] 135 | fn map_tag_type(tag: &str, size: usize) -> impl Fn(&[u8]) -> IResult<&[u8], (String, TagType)> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parser` is never used [INFO] [stdout] --> protocols/src/dmap/parser.rs:172:8 [INFO] [stdout] | [INFO] [stdout] 172 | pub fn parser(input: &[u8]) -> IResult<&[u8], (String, TagType)> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Tag` is never used [INFO] [stdout] --> protocols/src/dmap/tag_definition.rs:4:17 [INFO] [stdout] | [INFO] [stdout] 4 | pub(crate) enum Tag { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static `DMAP_MAP` is never used [INFO] [stdout] --> protocols/src/dmap/tag_definition.rs:13:19 [INFO] [stdout] | [INFO] [stdout] 13 | pub(crate) static DMAP_MAP: phf::Map<&'static str, Tag> = phf_map! { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple variants are never constructed [INFO] [stdout] --> protocols/src/companion/opack.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 11 | pub enum TypeData<'a> { [INFO] [stdout] | -------- variants in this enum [INFO] [stdout] 12 | Bool(bool), [INFO] [stdout] | ^^^^ [INFO] [stdout] 13 | None, [INFO] [stdout] | ^^^^ [INFO] [stdout] 14 | NegativeOne, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 15 | Uuid(Uuid), [INFO] [stdout] | ^^^^ [INFO] [stdout] 16 | Num(u8), [INFO] [stdout] | ^^^ [INFO] [stdout] 17 | NumU8(u8), [INFO] [stdout] | ^^^^^ [INFO] [stdout] 18 | NumU16(u16), [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 19 | NumU32(u32), [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 20 | NumU64(u64), [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 21 | NumU128(u128), [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 22 | Float(f32), [INFO] [stdout] | ^^^^^ [INFO] [stdout] 23 | Double(f64), [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 24 | Str(&'a str), [INFO] [stdout] | ^^^ [INFO] [stdout] 25 | Raw(&'a [u8]), [INFO] [stdout] | ^^^ [INFO] [stdout] 26 | Array(Vec>), [INFO] [stdout] | ^^^^^ [INFO] [stdout] 27 | Dict(Vec<(TypeData<'a>, TypeData<'a>)>), [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TypeData` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `read_index` is never used [INFO] [stdout] --> protocols/src/companion/opack.rs:30:4 [INFO] [stdout] | [INFO] [stdout] 30 | fn read_index(input: &[u8]) -> usize { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `deserializer` is never used [INFO] [stdout] --> protocols/src/companion/opack.rs:41:8 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn deserializer(input: &[u8]) -> IResult<&[u8], TypeData> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `ConvertToBytes` is never used [INFO] [stdout] --> protocols/src/companion/opack.rs:212:7 [INFO] [stdout] | [INFO] [stdout] 212 | trait ConvertToBytes { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `serializer` is never used [INFO] [stdout] --> protocols/src/companion/opack.rs:370:8 [INFO] [stdout] | [INFO] [stdout] 370 | pub fn serializer(data: TypeData) -> anyhow::Result> { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> protocols/src/dmap/parser.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 54 | let inner_content_parser = map_parser(take(len), many0(parser)); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | [INFO] [stdout] 56 | / map(inner_content_parser, |tags| { [INFO] [stdout] 57 | | ( [INFO] [stdout] 58 | | tag_name.to_owned(), [INFO] [stdout] 59 | | TagType::Container(tags.into_iter().collect()), [INFO] [stdout] 60 | | ) [INFO] [stdout] 61 | | })(input) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 18 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `protocols` (lib) due to 2 previous errors; 18 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> protocols/src/dmap/parser.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 54 | let inner_content_parser = map_parser(take(len), many0(parser)); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | [INFO] [stdout] 56 | / map(inner_content_parser, |tags| { [INFO] [stdout] 57 | | ( [INFO] [stdout] 58 | | tag_name.to_owned(), [INFO] [stdout] 59 | | TagType::Container(tags.into_iter().collect()), [INFO] [stdout] 60 | | ) [INFO] [stdout] 61 | | })(input) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `protocols` (lib test) due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "2dc9fd828fffaac20034c8cbdce8b02cac87d1339fc0aa6207facd164c4f0224", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2dc9fd828fffaac20034c8cbdce8b02cac87d1339fc0aa6207facd164c4f0224", kill_on_drop: false }` [INFO] [stdout] 2dc9fd828fffaac20034c8cbdce8b02cac87d1339fc0aa6207facd164c4f0224