[INFO] cloning repository https://github.com/bwestley/atc [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/bwestley/atc" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbwestley%2Fatc", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbwestley%2Fatc'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 04e9516125a63c236102080c26bde3e8b0e879be [INFO] checking bwestley/atc/04e9516125a63c236102080c26bde3e8b0e879be against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbwestley%2Fatc" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/bwestley/atc on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/bwestley/atc [INFO] finished tweaking git repo https://github.com/bwestley/atc [INFO] tweaked toml for git repo https://github.com/bwestley/atc written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/bwestley/atc already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4b17676d4c204a30d063452dba214f57faac79e30c95f1e17dcddd94eddf07be [INFO] running `Command { std: "docker" "start" "-a" "4b17676d4c204a30d063452dba214f57faac79e30c95f1e17dcddd94eddf07be", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4b17676d4c204a30d063452dba214f57faac79e30c95f1e17dcddd94eddf07be", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4b17676d4c204a30d063452dba214f57faac79e30c95f1e17dcddd94eddf07be", kill_on_drop: false }` [INFO] [stdout] 4b17676d4c204a30d063452dba214f57faac79e30c95f1e17dcddd94eddf07be [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 40b8f33e69915bee066d9f280c9082413ea9a53db1c07cb8cddfd00f8727fc37 [INFO] running `Command { std: "docker" "start" "-a" "40b8f33e69915bee066d9f280c9082413ea9a53db1c07cb8cddfd00f8727fc37", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.69 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking bytemuck v1.14.0 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling serde v1.0.189 [INFO] [stderr] Compiling libc v0.2.149 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Checking smallvec v1.11.1 [INFO] [stderr] Checking encoding_rs v0.8.33 [INFO] [stderr] Checking strength_reduce v0.2.4 [INFO] [stderr] Checking hashbrown v0.14.1 [INFO] [stderr] Checking winnow v0.5.17 [INFO] [stderr] Checking glam v0.24.2 [INFO] [stderr] Checking dyn-clone v1.0.14 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking symphonia-core v0.5.3 [INFO] [stderr] Checking rsor v0.1.3 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling rustfft v6.1.0 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking indexmap v2.0.2 [INFO] [stderr] Compiling syn v2.0.38 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Compiling duplicate v1.0.0 [INFO] [stderr] Checking num-complex v0.4.4 [INFO] [stderr] Checking numeric-array v0.5.2 [INFO] [stderr] Checking symphonia-metadata v0.5.3 [INFO] [stderr] Checking symphonia-codec-adpcm v0.5.3 [INFO] [stderr] Checking symphonia-codec-pcm v0.5.3 [INFO] [stderr] Checking symphonia-codec-alac v0.5.3 [INFO] [stderr] Checking symphonia-codec-aac v0.5.3 [INFO] [stderr] Checking transpose v0.2.2 [INFO] [stderr] Checking primal-check v0.3.3 [INFO] [stderr] Checking symphonia-utils-xiph v0.5.3 [INFO] [stderr] Checking symphonia-format-wav v0.5.3 [INFO] [stderr] Checking symphonia-bundle-mp3 v0.5.3 [INFO] [stderr] Checking symphonia-format-ogg v0.5.3 [INFO] [stderr] Checking symphonia-bundle-flac v0.5.3 [INFO] [stderr] Checking symphonia-codec-vorbis v0.5.3 [INFO] [stderr] Checking symphonia-format-isomp4 v0.5.3 [INFO] [stderr] Checking symphonia-format-mkv v0.5.3 [INFO] [stderr] Checking symphonia v0.5.3 [INFO] [stderr] Checking funutd v0.12.1 [INFO] [stderr] Compiling serde_derive v1.0.189 [INFO] [stderr] Compiling pin-project-internal v1.1.3 [INFO] [stderr] Checking pin-project v1.1.3 [INFO] [stderr] Checking thingbuf v0.1.4 [INFO] [stderr] Checking fundsp v0.15.0 [INFO] [stderr] Checking serde_spanned v0.6.3 [INFO] [stderr] Checking toml_datetime v0.6.3 [INFO] [stderr] Checking toml_edit v0.19.15 [INFO] [stderr] Checking toml v0.7.8 [INFO] [stderr] Checking atc v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: function `tokenize` is never used [INFO] [stdout] --> src/tts.rs:48:8 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn tokenize(string: &str) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:368:11 [INFO] [stdout] | [INFO] [stdout] 255 | let input_wave = match Wave64::load(&input_path) { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 256 | Ok(wave) => wave, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 257 | Err(load_error) => { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 272 | let mut input_wave = Wave64::render( [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 324 | let audio_arc = Arc::new(input_wave); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 325 | let mut sequencer = Sequencer64::new(true, 1); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 366 | let output_wave = Wave64::render(SAMPLE_RATE, t_out_sec, &mut sequencer); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 367 | println!("[Main] Saving audio to {}.", output_path.to_string_lossy()); [INFO] [stdout] 368 | match output_wave.save_wav16(&output_path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a value that implements `Copy` does nothing [INFO] [stdout] --> src/main.rs:200:5 [INFO] [stdout] | [INFO] [stdout] 200 | drop(success); [INFO] [stdout] | ^^^^^-------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `bool` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_copy_types)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 200 - drop(success); [INFO] [stdout] 200 + let _ = success; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `tokenize` is never used [INFO] [stdout] --> src/tts.rs:48:8 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn tokenize(string: &str) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:368:11 [INFO] [stdout] | [INFO] [stdout] 255 | let input_wave = match Wave64::load(&input_path) { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 256 | Ok(wave) => wave, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 257 | Err(load_error) => { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 272 | let mut input_wave = Wave64::render( [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 324 | let audio_arc = Arc::new(input_wave); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 325 | let mut sequencer = Sequencer64::new(true, 1); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 366 | let output_wave = Wave64::render(SAMPLE_RATE, t_out_sec, &mut sequencer); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 367 | println!("[Main] Saving audio to {}.", output_path.to_string_lossy()); [INFO] [stdout] 368 | match output_wave.save_wav16(&output_path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a value that implements `Copy` does nothing [INFO] [stdout] --> src/main.rs:200:5 [INFO] [stdout] | [INFO] [stdout] 200 | drop(success); [INFO] [stdout] | ^^^^^-------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `bool` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_copy_types)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 200 - drop(success); [INFO] [stdout] 200 + let _ = success; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/main.rs:241:5 [INFO] [stdout] | [INFO] [stdout] 241 | drop(input_path_string); [INFO] [stdout] | ^^^^^-----------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&std::string::String` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 241 - drop(input_path_string); [INFO] [stdout] 241 + let _ = input_path_string; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/main.rs:241:5 [INFO] [stdout] | [INFO] [stdout] 241 | drop(input_path_string); [INFO] [stdout] | ^^^^^-----------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&std::string::String` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 241 - drop(input_path_string); [INFO] [stdout] 241 + let _ = input_path_string; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `atc` (bin "atc" test) due to 2 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `atc` (bin "atc") due to 2 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "40b8f33e69915bee066d9f280c9082413ea9a53db1c07cb8cddfd00f8727fc37", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "40b8f33e69915bee066d9f280c9082413ea9a53db1c07cb8cddfd00f8727fc37", kill_on_drop: false }` [INFO] [stdout] 40b8f33e69915bee066d9f280c9082413ea9a53db1c07cb8cddfd00f8727fc37