[INFO] cloning repository https://github.com/burtgulash/sirka [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/burtgulash/sirka" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fburtgulash%2Fsirka", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fburtgulash%2Fsirka'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f6cf96e074501cc6ad4294a87b136110f50780af [INFO] checking burtgulash/sirka/f6cf96e074501cc6ad4294a87b136110f50780af against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fburtgulash%2Fsirka" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/burtgulash/sirka on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/burtgulash/sirka [INFO] finished tweaking git repo https://github.com/burtgulash/sirka [INFO] tweaked toml for git repo https://github.com/burtgulash/sirka written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/burtgulash/sirka already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 57c0a3b5ec29222fe36e4ddcf76f6ca482be7f4de38e0da505be9137c0f9c1c1 [INFO] running `Command { std: "docker" "start" "-a" "57c0a3b5ec29222fe36e4ddcf76f6ca482be7f4de38e0da505be9137c0f9c1c1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "57c0a3b5ec29222fe36e4ddcf76f6ca482be7f4de38e0da505be9137c0f9c1c1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "57c0a3b5ec29222fe36e4ddcf76f6ca482be7f4de38e0da505be9137c0f9c1c1", kill_on_drop: false }` [INFO] [stdout] 57c0a3b5ec29222fe36e4ddcf76f6ca482be7f4de38e0da505be9137c0f9c1c1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b2ddbe1ab713e80d51d4e6bc1f2c13e1ca4c76884bb8fd3e2fa450eeb4871260 [INFO] running `Command { std: "docker" "start" "-a" "b2ddbe1ab713e80d51d4e6bc1f2c13e1ca4c76884bb8fd3e2fa450eeb4871260", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking sirka v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `terms_size` [INFO] [stdout] --> src/nutrie/read.rs:47:68 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn new(bytes: &'a [u8], dict_size: usize, root_ptr: usize, terms_size: usize) -> Self { [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_terms_size` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/postings/cursor/merge/with_duplicates.rs:77:17 [INFO] [stdout] | [INFO] [stdout] 77 | let mut ptrs = self.frontier.drain().collect::>(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nutrie/write.rs:181:18 [INFO] [stdout] | [INFO] [stdout] 173 | fn new(parent: Option, t: WrittenTerm, postings: Option) -> TrieNode { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 181 | TrieNode(Rc::new(RefCell::new(_TrieNode { [INFO] [stdout] | __________________^ [INFO] [stdout] 182 | | t: t, [INFO] [stdout] 183 | | pointer_in_dictbuf: None, [INFO] [stdout] 184 | | postings: postings, [INFO] [stdout] 185 | | parent: parent.map(|p| Rc::downgrade(&p.clone())), [INFO] [stdout] 186 | | children: Vec::new(), [INFO] [stdout] 187 | | }))) [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nutrie/write.rs:185:51 [INFO] [stdout] | [INFO] [stdout] 185 | parent: parent.map(|p| Rc::downgrade(&p.clone())), [INFO] [stdout] | - ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nutrie/write.rs:392:22 [INFO] [stdout] | [INFO] [stdout] 383 | fn from_trienode(n: TrieNode, prefix: &str, postings_ptr: DocId) -> TrieNodeHeader { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 392 | term_id: n.borrow().t.term_id, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nutrie/write.rs:395:27 [INFO] [stdout] | [INFO] [stdout] 383 | fn from_trienode(n: TrieNode, prefix: &str, postings_ptr: DocId) -> TrieNodeHeader { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 395 | num_children: n.borrow().children.len() as u32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/postings/cursor/merge/without_duplicates.rs:28:23 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn new(to_merge: Vec) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | MergerWithoutDuplicatesUnrolled { [INFO] [stdout] 28 | to_merge: Some(to_merge), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/postings/cursor/merge/without_duplicates.rs:124:26 [INFO] [stdout] | [INFO] [stdout] 115 | pub fn new(to_merge: Vec) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | let mut heap = create_heap(to_merge); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | let first_ptr = heap.pop().unwrap(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | current_ptr: Some(first_ptr), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/postings/cursor/merge/with_duplicates.rs:13:23 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn new(to_merge: Vec) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | MergeUnrolled { [INFO] [stdout] 13 | to_merge: Some(to_merge), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/postings/cursor/merge/with_duplicates.rs:47:26 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn new(to_merge: Vec) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | let size = to_merge.iter().map(|c| c.remains()).fold(0, |acc, x| acc + x); [INFO] [stdout] 45 | let heap = create_heap(to_merge); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | Merge{ [INFO] [stdout] 47 | current_ptr: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/postings/cursor/merge/frontier.rs:33:27 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn create_heap(to_merge: Vec) -> BinaryHeap> { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | BinaryHeap::from_iter(to_merge.into_iter().map(|mut cur| { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 34 | | let _ = cur.advance().unwrap(); [INFO] [stdout] 35 | | FrontierPointer { [INFO] [stdout] 36 | | cursor: cur [INFO] [stdout] 37 | | } [INFO] [stdout] 38 | | })) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sirka` (lib) due to 10 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `terms_size` [INFO] [stdout] --> src/nutrie/read.rs:47:68 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn new(bytes: &'a [u8], dict_size: usize, root_ptr: usize, terms_size: usize) -> Self { [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_terms_size` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/postings/cursor/merge/with_duplicates.rs:77:17 [INFO] [stdout] | [INFO] [stdout] 77 | let mut ptrs = self.frontier.drain().collect::>(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nutrie/write.rs:181:18 [INFO] [stdout] | [INFO] [stdout] 173 | fn new(parent: Option, t: WrittenTerm, postings: Option) -> TrieNode { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 181 | TrieNode(Rc::new(RefCell::new(_TrieNode { [INFO] [stdout] | __________________^ [INFO] [stdout] 182 | | t: t, [INFO] [stdout] 183 | | pointer_in_dictbuf: None, [INFO] [stdout] 184 | | postings: postings, [INFO] [stdout] 185 | | parent: parent.map(|p| Rc::downgrade(&p.clone())), [INFO] [stdout] 186 | | children: Vec::new(), [INFO] [stdout] 187 | | }))) [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nutrie/write.rs:185:51 [INFO] [stdout] | [INFO] [stdout] 185 | parent: parent.map(|p| Rc::downgrade(&p.clone())), [INFO] [stdout] | - ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nutrie/write.rs:392:22 [INFO] [stdout] | [INFO] [stdout] 383 | fn from_trienode(n: TrieNode, prefix: &str, postings_ptr: DocId) -> TrieNodeHeader { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 392 | term_id: n.borrow().t.term_id, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nutrie/write.rs:395:27 [INFO] [stdout] | [INFO] [stdout] 383 | fn from_trienode(n: TrieNode, prefix: &str, postings_ptr: DocId) -> TrieNodeHeader { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 395 | num_children: n.borrow().children.len() as u32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/postings/cursor/merge/without_duplicates.rs:28:23 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn new(to_merge: Vec) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | MergerWithoutDuplicatesUnrolled { [INFO] [stdout] 28 | to_merge: Some(to_merge), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/postings/cursor/merge/without_duplicates.rs:124:26 [INFO] [stdout] | [INFO] [stdout] 115 | pub fn new(to_merge: Vec) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | let mut heap = create_heap(to_merge); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | let first_ptr = heap.pop().unwrap(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | current_ptr: Some(first_ptr), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/postings/cursor/merge/with_duplicates.rs:13:23 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn new(to_merge: Vec) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | MergeUnrolled { [INFO] [stdout] 13 | to_merge: Some(to_merge), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/postings/cursor/merge/with_duplicates.rs:47:26 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn new(to_merge: Vec) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | let size = to_merge.iter().map(|c| c.remains()).fold(0, |acc, x| acc + x); [INFO] [stdout] 45 | let heap = create_heap(to_merge); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | Merge{ [INFO] [stdout] 47 | current_ptr: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/postings/cursor/merge/frontier.rs:33:27 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn create_heap(to_merge: Vec) -> BinaryHeap> { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | BinaryHeap::from_iter(to_merge.into_iter().map(|mut cur| { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 34 | | let _ = cur.advance().unwrap(); [INFO] [stdout] 35 | | FrontierPointer { [INFO] [stdout] 36 | | cursor: cur [INFO] [stdout] 37 | | } [INFO] [stdout] 38 | | })) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sirka` (lib test) due to 10 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "b2ddbe1ab713e80d51d4e6bc1f2c13e1ca4c76884bb8fd3e2fa450eeb4871260", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b2ddbe1ab713e80d51d4e6bc1f2c13e1ca4c76884bb8fd3e2fa450eeb4871260", kill_on_drop: false }` [INFO] [stdout] b2ddbe1ab713e80d51d4e6bc1f2c13e1ca4c76884bb8fd3e2fa450eeb4871260