[INFO] cloning repository https://github.com/bungogood/orsay [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/bungogood/orsay" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbungogood%2Forsay", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbungogood%2Forsay'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f8c069684fbaf3ad7336772bbe0faa6d0e1c39eb [INFO] checking bungogood/orsay/f8c069684fbaf3ad7336772bbe0faa6d0e1c39eb against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbungogood%2Forsay" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/bungogood/orsay on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/bungogood/orsay [INFO] finished tweaking git repo https://github.com/bungogood/orsay [INFO] tweaked toml for git repo https://github.com/bungogood/orsay written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/bungogood/orsay already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 39e5fdc56ad43b81285ffe8c974eaa13bc9627128625a34ffb8cbf81c7212d5e [INFO] running `Command { std: "docker" "start" "-a" "39e5fdc56ad43b81285ffe8c974eaa13bc9627128625a34ffb8cbf81c7212d5e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "39e5fdc56ad43b81285ffe8c974eaa13bc9627128625a34ffb8cbf81c7212d5e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "39e5fdc56ad43b81285ffe8c974eaa13bc9627128625a34ffb8cbf81c7212d5e", kill_on_drop: false }` [INFO] [stdout] 39e5fdc56ad43b81285ffe8c974eaa13bc9627128625a34ffb8cbf81c7212d5e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 39259be34cc581f2083c341f2ff3f6ade718de5aa3ad3527d4a8b1ecdd3e940d [INFO] running `Command { std: "docker" "start" "-a" "39259be34cc581f2083c341f2ff3f6ade718de5aa3ad3527d4a8b1ecdd3e940d", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Compiling cc v1.0.92 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Compiling rustix v0.38.32 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Compiling openssl v0.10.64 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking hex v0.3.2 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking fastrand v2.0.2 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Checking num-format v0.4.4 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking crossbeam-channel v0.5.12 [INFO] [stderr] Compiling openssl-sys v0.9.102 [INFO] [stderr] Compiling syn v2.0.58 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking crypto-hash v0.3.4 [INFO] [stderr] Checking orsay v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:108:8 [INFO] [stdout] | [INFO] [stdout] 28 | mut reader: BufReader, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | read_tx: Sender<(usize, Vec)>, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | write_tx: Sender<(usize, Vec)>, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | let reader = thread::spawn(move || { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | Ok((line_length, reader)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/worker.rs:20:27 [INFO] [stdout] | [INFO] [stdout] 18 | let rx = read_rx.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | let tx = write_tx.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | thread::spawn(move || { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 21 | | let mut solver = SolverBasic::new(1, true); [INFO] [stdout] 22 | | let mut stats = Stats::new(); [INFO] [stdout] 23 | | for (index, chunk) in rx { [INFO] [stdout] ... | [INFO] [stdout] 28 | | stats [INFO] [stdout] 29 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writer.rs:35:19 [INFO] [stdout] | [INFO] [stdout] 32 | mut writer: BufWriter, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | write_rx: Receiver<(usize, Vec)>, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | ) -> thread::JoinHandle<()> { [INFO] [stdout] 35 | thread::spawn(move || { [INFO] [stdout] | ___________________^ [INFO] [stdout] 36 | | let mut heap = BinaryHeap::new(); [INFO] [stdout] 37 | | let mut next_index = 0; [INFO] [stdout] ... | [INFO] [stdout] 50 | | writer.flush().unwrap(); [INFO] [stdout] 51 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:108:8 [INFO] [stdout] | [INFO] [stdout] 28 | mut reader: BufReader, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | read_tx: Sender<(usize, Vec)>, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | write_tx: Sender<(usize, Vec)>, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | let reader = thread::spawn(move || { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | Ok((line_length, reader)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `orsay` (lib) due to 4 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/worker.rs:20:27 [INFO] [stdout] | [INFO] [stdout] 18 | let rx = read_rx.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | let tx = write_tx.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | thread::spawn(move || { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 21 | | let mut solver = SolverBasic::new(1, true); [INFO] [stdout] 22 | | let mut stats = Stats::new(); [INFO] [stdout] 23 | | for (index, chunk) in rx { [INFO] [stdout] ... | [INFO] [stdout] 28 | | stats [INFO] [stdout] 29 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writer.rs:35:19 [INFO] [stdout] | [INFO] [stdout] 32 | mut writer: BufWriter, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | write_rx: Receiver<(usize, Vec)>, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | ) -> thread::JoinHandle<()> { [INFO] [stdout] 35 | thread::spawn(move || { [INFO] [stdout] | ___________________^ [INFO] [stdout] 36 | | let mut heap = BinaryHeap::new(); [INFO] [stdout] 37 | | let mut next_index = 0; [INFO] [stdout] ... | [INFO] [stdout] 50 | | writer.flush().unwrap(); [INFO] [stdout] 51 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `orsay` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "39259be34cc581f2083c341f2ff3f6ade718de5aa3ad3527d4a8b1ecdd3e940d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "39259be34cc581f2083c341f2ff3f6ade718de5aa3ad3527d4a8b1ecdd3e940d", kill_on_drop: false }` [INFO] [stdout] 39259be34cc581f2083c341f2ff3f6ade718de5aa3ad3527d4a8b1ecdd3e940d