[INFO] cloning repository https://github.com/bumpjammy/SinCosTanDemo [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/bumpjammy/SinCosTanDemo" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbumpjammy%2FSinCosTanDemo", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbumpjammy%2FSinCosTanDemo'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8d5c196b44a68e7af4a0069d1fcd590d1dfd7468 [INFO] checking bumpjammy/SinCosTanDemo/8d5c196b44a68e7af4a0069d1fcd590d1dfd7468 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbumpjammy%2FSinCosTanDemo" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/bumpjammy/SinCosTanDemo on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/bumpjammy/SinCosTanDemo [INFO] finished tweaking git repo https://github.com/bumpjammy/SinCosTanDemo [INFO] tweaked toml for git repo https://github.com/bumpjammy/SinCosTanDemo written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/bumpjammy/SinCosTanDemo already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 92e1f8296dc2b24e8f6640d53467245be482b653f21d2c67f1290fa3dc8c66e2 [INFO] running `Command { std: "docker" "start" "-a" "92e1f8296dc2b24e8f6640d53467245be482b653f21d2c67f1290fa3dc8c66e2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "92e1f8296dc2b24e8f6640d53467245be482b653f21d2c67f1290fa3dc8c66e2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "92e1f8296dc2b24e8f6640d53467245be482b653f21d2c67f1290fa3dc8c66e2", kill_on_drop: false }` [INFO] [stdout] 92e1f8296dc2b24e8f6640d53467245be482b653f21d2c67f1290fa3dc8c66e2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 55db57af648b41d357facaf4692a21826543f89e92f1328581735d3939f8fe02 [INFO] running `Command { std: "docker" "start" "-a" "55db57af648b41d357facaf4692a21826543f89e92f1328581735d3939f8fe02", kill_on_drop: false }` [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling version-compare v0.1.1 [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling sdl2 v0.35.2 [INFO] [stderr] Checking c_vec v2.0.0 [INFO] [stderr] Compiling sdl2-sys v0.35.2 [INFO] [stderr] Checking SinCosTanDemo v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `SDL_CreateRenderer`, `SDL_GetWindowSurface`, and `SDL_Renderer` [INFO] [stdout] --> src/window_management.rs:2:17 [INFO] [stdout] | [INFO] [stdout] 2 | use sdl2::sys::{SDL_CreateRenderer, SDL_GetWindowSurface, SDL_Renderer}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `sdl2::rect::Point` [INFO] [stdout] --> src/app_loop.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use sdl2::rect::Point; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `sdl2::sys::SDL_Renderer` [INFO] [stdout] --> src/app_loop.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use sdl2::sys::SDL_Renderer; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `CIRCLE_CENTRE` [INFO] [stdout] --> src/app_loop.rs:5:13 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::{CIRCLE_CENTRE, event_handling, rendering}; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `SDL_CreateRenderer`, `SDL_GetWindowSurface`, and `SDL_Renderer` [INFO] [stdout] --> src/window_management.rs:2:17 [INFO] [stdout] | [INFO] [stdout] 2 | use sdl2::sys::{SDL_CreateRenderer, SDL_GetWindowSurface, SDL_Renderer}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `sdl2::rect::Point` [INFO] [stdout] --> src/app_loop.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use sdl2::rect::Point; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `sdl2::sys::SDL_Renderer` [INFO] [stdout] --> src/app_loop.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use sdl2::sys::SDL_Renderer; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `CIRCLE_CENTRE` [INFO] [stdout] --> src/app_loop.rs:5:13 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::{CIRCLE_CENTRE, event_handling, rendering}; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `render_triangle` is never used [INFO] [stdout] --> src/rendering.rs:180:4 [INFO] [stdout] | [INFO] [stdout] 180 | fn render_triangle(canvas: &mut WindowCanvas, p1: Point, p2 : Point, p3: Point) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `render_thick_line` is never used [INFO] [stdout] --> src/rendering.rs:187:4 [INFO] [stdout] | [INFO] [stdout] 187 | fn render_thick_line(canvas: &mut WindowCanvas, p1: Point, p2: Point, thickness: i32) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/window_management.rs:17:8 [INFO] [stdout] | [INFO] [stdout] 6 | let sdl_context = sdl2::init()?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 7 | let video_subsystem = sdl_context.video()?; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 8 | [INFO] [stdout] 9 | let window = video_subsystem.window("Sin Cos Tan", WIDTH as u32, HEIGHT as u32) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 14 | let canvas = window.into_canvas().build() [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 17 | Ok((sdl_context, canvas)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `SinCosTanDemo` (bin "SinCosTanDemo" test) due to 2 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: function `render_triangle` is never used [INFO] [stdout] --> src/rendering.rs:180:4 [INFO] [stdout] | [INFO] [stdout] 180 | fn render_triangle(canvas: &mut WindowCanvas, p1: Point, p2 : Point, p3: Point) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `render_thick_line` is never used [INFO] [stdout] --> src/rendering.rs:187:4 [INFO] [stdout] | [INFO] [stdout] 187 | fn render_thick_line(canvas: &mut WindowCanvas, p1: Point, p2: Point, thickness: i32) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/window_management.rs:17:8 [INFO] [stdout] | [INFO] [stdout] 6 | let sdl_context = sdl2::init()?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 7 | let video_subsystem = sdl_context.video()?; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 8 | [INFO] [stdout] 9 | let window = video_subsystem.window("Sin Cos Tan", WIDTH as u32, HEIGHT as u32) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 14 | let canvas = window.into_canvas().build() [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 17 | Ok((sdl_context, canvas)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `SinCosTanDemo` (bin "SinCosTanDemo") due to 2 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "55db57af648b41d357facaf4692a21826543f89e92f1328581735d3939f8fe02", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "55db57af648b41d357facaf4692a21826543f89e92f1328581735d3939f8fe02", kill_on_drop: false }` [INFO] [stdout] 55db57af648b41d357facaf4692a21826543f89e92f1328581735d3939f8fe02