[INFO] cloning repository https://github.com/bsjhx/too-many-linked-lists [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/bsjhx/too-many-linked-lists" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbsjhx%2Ftoo-many-linked-lists", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbsjhx%2Ftoo-many-linked-lists'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] dfffc07f635d3152af55f4f58932034189310015 [INFO] checking bsjhx/too-many-linked-lists/dfffc07f635d3152af55f4f58932034189310015 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbsjhx%2Ftoo-many-linked-lists" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/bsjhx/too-many-linked-lists on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/bsjhx/too-many-linked-lists [INFO] finished tweaking git repo https://github.com/bsjhx/too-many-linked-lists [INFO] tweaked toml for git repo https://github.com/bsjhx/too-many-linked-lists written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/bsjhx/too-many-linked-lists already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3769c0f621daee97a6ad14794bee36576f4676556a45ce97359471d29f17ab74 [INFO] running `Command { std: "docker" "start" "-a" "3769c0f621daee97a6ad14794bee36576f4676556a45ce97359471d29f17ab74", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3769c0f621daee97a6ad14794bee36576f4676556a45ce97359471d29f17ab74", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3769c0f621daee97a6ad14794bee36576f4676556a45ce97359471d29f17ab74", kill_on_drop: false }` [INFO] [stdout] 3769c0f621daee97a6ad14794bee36576f4676556a45ce97359471d29f17ab74 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d9b4031fb30274a775befb68411ba0c70d93cb2e6a6b2d896d24c9d485b767e9 [INFO] running `Command { std: "docker" "start" "-a" "d9b4031fb30274a775befb68411ba0c70d93cb2e6a6b2d896d24c9d485b767e9", kill_on_drop: false }` [INFO] [stderr] Checking lists v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `crate::first::List` [INFO] [stdout] --> src/first.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 61 | use crate::first::List; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/second.rs:116:9 [INFO] [stdout] | [INFO] [stdout] 116 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/third.rs:29:19 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn prepend(&self, elem: T) -> List { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | List { [INFO] [stdout] 29 | head: Some(Rc::new(Node { [INFO] [stdout] | ___________________^ [INFO] [stdout] 30 | | elem, [INFO] [stdout] 31 | | next: self.head.clone(), [INFO] [stdout] 32 | | })), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fourth.rs:32:15 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn push_front(&mut self, elem: T) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | // new node needs +2 links, everything else should be +0 [INFO] [stdout] 31 | let new_head = Node::new(elem); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | match self.head.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fourth.rs:47:15 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn push_back(&mut self, elem: T) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | let new_tail = Node::new(elem); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | match self.tail.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fourth.rs:76:13 [INFO] [stdout] | [INFO] [stdout] 62 | self.head.take().map(|old_head| { // -1 old [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | Rc::try_unwrap(old_head).ok().unwrap().into_inner().elem [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fourth.rs:91:13 [INFO] [stdout] | [INFO] [stdout] 81 | self.tail.take().map(|old_tail| { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | Rc::try_unwrap(old_tail).ok().unwrap().into_inner().elem [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fourth.rs:135:17 [INFO] [stdout] | [INFO] [stdout] 134 | pub fn new(elem: T) -> Rc>> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | Rc::new(RefCell::new(Node { [INFO] [stdout] | _________________^ [INFO] [stdout] 136 | | elem, [INFO] [stdout] 137 | | next: None, [INFO] [stdout] 138 | | prev: None, [INFO] [stdout] 139 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `More` is never constructed [INFO] [stdout] --> src/first.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 7 | enum Link { [INFO] [stdout] | ---- variant in this enum [INFO] [stdout] 8 | Empty, [INFO] [stdout] 9 | More(Box) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `elem` is never read [INFO] [stdout] --> src/first.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 12 | struct Node { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] 13 | elem: i32, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `push`, and `pop` are never used [INFO] [stdout] --> src/first.rs:18:8 [INFO] [stdout] | [INFO] [stdout] 17 | impl List { [INFO] [stdout] | --------- associated items in this implementation [INFO] [stdout] 18 | fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 24 | fn push(&mut self, elem: i32) { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 33 | fn pop(&mut self) -> Option { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/third.rs:29:19 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn prepend(&self, elem: T) -> List { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | List { [INFO] [stdout] 29 | head: Some(Rc::new(Node { [INFO] [stdout] | ___________________^ [INFO] [stdout] 30 | | elem, [INFO] [stdout] 31 | | next: self.head.clone(), [INFO] [stdout] 32 | | })), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lists` (lib test) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fourth.rs:32:15 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn push_front(&mut self, elem: T) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | // new node needs +2 links, everything else should be +0 [INFO] [stdout] 31 | let new_head = Node::new(elem); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | match self.head.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fourth.rs:47:15 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn push_back(&mut self, elem: T) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | let new_tail = Node::new(elem); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | match self.tail.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fourth.rs:76:13 [INFO] [stdout] | [INFO] [stdout] 62 | self.head.take().map(|old_head| { // -1 old [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | Rc::try_unwrap(old_head).ok().unwrap().into_inner().elem [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fourth.rs:91:13 [INFO] [stdout] | [INFO] [stdout] 81 | self.tail.take().map(|old_tail| { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | Rc::try_unwrap(old_tail).ok().unwrap().into_inner().elem [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fourth.rs:135:17 [INFO] [stdout] | [INFO] [stdout] 134 | pub fn new(elem: T) -> Rc>> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | Rc::new(RefCell::new(Node { [INFO] [stdout] | _________________^ [INFO] [stdout] 136 | | elem, [INFO] [stdout] 137 | | next: None, [INFO] [stdout] 138 | | prev: None, [INFO] [stdout] 139 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lists` (lib) due to 7 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "d9b4031fb30274a775befb68411ba0c70d93cb2e6a6b2d896d24c9d485b767e9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d9b4031fb30274a775befb68411ba0c70d93cb2e6a6b2d896d24c9d485b767e9", kill_on_drop: false }` [INFO] [stdout] d9b4031fb30274a775befb68411ba0c70d93cb2e6a6b2d896d24c9d485b767e9