[INFO] cloning repository https://github.com/bruceskingle/marco-sparko [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/bruceskingle/marco-sparko" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbruceskingle%2Fmarco-sparko", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbruceskingle%2Fmarco-sparko'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 95deffb245fb6942b1423eb53b661d169f891e1b [INFO] checking bruceskingle/marco-sparko/95deffb245fb6942b1423eb53b661d169f891e1b against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbruceskingle%2Fmarco-sparko" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/bruceskingle/marco-sparko on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/bruceskingle/marco-sparko [INFO] finished tweaking git repo https://github.com/bruceskingle/marco-sparko [INFO] tweaked toml for git repo https://github.com/bruceskingle/marco-sparko written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/bruceskingle/marco-sparko already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: unused manifest key: dependencies.serde.with [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 675a8338525c616623fb94d47415429acb9fc24d44de7926b0fb14e1a5b69e28 [INFO] running `Command { std: "docker" "start" "-a" "675a8338525c616623fb94d47415429acb9fc24d44de7926b0fb14e1a5b69e28", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "675a8338525c616623fb94d47415429acb9fc24d44de7926b0fb14e1a5b69e28", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "675a8338525c616623fb94d47415429acb9fc24d44de7926b0fb14e1a5b69e28", kill_on_drop: false }` [INFO] [stdout] 675a8338525c616623fb94d47415429acb9fc24d44de7926b0fb14e1a5b69e28 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bd2d9e0eb69be122943ce5002b8be2edd7cc2939e935de2ab2454253140d8e97 [INFO] running `Command { std: "docker" "start" "-a" "bd2d9e0eb69be122943ce5002b8be2edd7cc2939e935de2ab2454253140d8e97", kill_on_drop: false }` [INFO] [stderr] warning: unused manifest key: dependencies.serde.with [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Compiling openssl v0.10.66 [INFO] [stderr] Checking foreign-types-shared v0.1.1 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Checking mio v1.0.1 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking indexmap v2.3.0 [INFO] [stderr] Compiling native-tls v0.2.12 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking tower-layer v0.3.2 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Compiling serde_json v1.0.122 [INFO] [stderr] Checking foreign-types v0.3.2 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking rustls-pki-types v1.7.0 [INFO] [stderr] Checking clap_builder v4.5.13 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking rtoolbox v0.0.2 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking rustls-pemfile v2.1.3 [INFO] [stderr] Checking rpassword v7.3.1 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling openssl-sys v0.9.103 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Compiling async-stream-impl v0.3.5 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking async-stream v0.3.5 [INFO] [stderr] Checking tokio v1.39.2 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking clap v4.5.13 [INFO] [stderr] Checking serde v1.0.204 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking tokio-test v0.4.4 [INFO] [stderr] Checking h2 v0.4.5 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking hyper-util v0.1.6 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.5 [INFO] [stderr] Checking marco-sparko v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `collections::HashMap`, `fmt::Display`, and `sync::Arc` [INFO] [stdout] --> src/system.rs:25:11 [INFO] [stdout] | [INFO] [stdout] 25 | use std::{collections::HashMap, fmt::Display, sync::Arc}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `time::OffsetDateTime` [INFO] [stdout] --> src/system.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | use time::OffsetDateTime; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `collections::HashMap`, `fmt::Display`, and `sync::Arc` [INFO] [stdout] --> src/system.rs:25:11 [INFO] [stdout] | [INFO] [stdout] 25 | use std::{collections::HashMap, fmt::Display, sync::Arc}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `time::OffsetDateTime` [INFO] [stdout] --> src/system.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | use time::OffsetDateTime; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/octopus.rs:180:16 [INFO] [stdout] | [INFO] [stdout] 178 | pub fn constructor(context: Box<&Context>, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 179 | json_profile: Option) -> Result, crate::Error> { [INFO] [stdout] 180 | Ok(Client::builder(&context, json_profile)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/octopus.rs:395:12 [INFO] [stdout] | [INFO] [stdout] 394 | fn build(self: Box, init: bool) -> Result, crate::Error> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 395 | Ok(Box::new(self.do_build(init)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/octopus/token.rs:114:21 [INFO] [stdout] | [INFO] [stdout] 110 | fn new(gql_client: Arc, authenticator: ObtainJSONWebTokenInput) -> TokenManager { [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | token: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/octopus/token.rs:261:12 [INFO] [stdout] | [INFO] [stdout] 239 | pub fn build(mut self, init: bool) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 261 | Ok(TokenManager::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 262 | | self.gql_client.ok_or(Error::CallerError("GQL Client must be provided"))?, [INFO] [stdout] 263 | | self.authenticator.ok_or(Error::CallerError("Credentials must be specified"))?) [INFO] [stdout] | |___________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/octopus.rs:180:16 [INFO] [stdout] | [INFO] [stdout] 178 | pub fn constructor(context: Box<&Context>, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 179 | json_profile: Option) -> Result, crate::Error> { [INFO] [stdout] 180 | Ok(Client::builder(&context, json_profile)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/octopus.rs:395:12 [INFO] [stdout] | [INFO] [stdout] 394 | fn build(self: Box, init: bool) -> Result, crate::Error> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 395 | Ok(Box::new(self.do_build(init)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/octopus/token.rs:114:21 [INFO] [stdout] | [INFO] [stdout] 110 | fn new(gql_client: Arc, authenticator: ObtainJSONWebTokenInput) -> TokenManager { [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | token: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/octopus/token.rs:261:12 [INFO] [stdout] | [INFO] [stdout] 239 | pub fn build(mut self, init: bool) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 261 | Ok(TokenManager::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 262 | | self.gql_client.ok_or(Error::CallerError("GQL Client must be provided"))?, [INFO] [stdout] 263 | | self.authenticator.ok_or(Error::CallerError("Credentials must be specified"))?) [INFO] [stdout] | |___________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/octopus/token.rs:314:30 [INFO] [stdout] | [INFO] [stdout] 310 | let mut octopus_client = crate::octopus::ClientBuilder::new_test() [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 314 | tokio_test::block_on(octopus_client.token_manager.authenticate()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/octopus/token.rs:435:30 [INFO] [stdout] | [INFO] [stdout] 418 | let mut octopus_client = crate::octopus::ClientBuilder::new_test() [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 435 | tokio_test::block_on(octopus_client.token_manager.authenticate()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `marco-sparko` (lib) due to 5 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 6 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `marco-sparko` (lib test) due to 7 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "bd2d9e0eb69be122943ce5002b8be2edd7cc2939e935de2ab2454253140d8e97", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bd2d9e0eb69be122943ce5002b8be2edd7cc2939e935de2ab2454253140d8e97", kill_on_drop: false }` [INFO] [stdout] bd2d9e0eb69be122943ce5002b8be2edd7cc2939e935de2ab2454253140d8e97