[INFO] cloning repository https://github.com/bruceg/vecmap [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/bruceg/vecmap" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbruceg%2Fvecmap", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbruceg%2Fvecmap'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] bbf2a3e3a0ea44ec97fe629f133911ac399e75b3 [INFO] checking bruceg/vecmap/bbf2a3e3a0ea44ec97fe629f133911ac399e75b3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbruceg%2Fvecmap" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/bruceg/vecmap on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/bruceg/vecmap [INFO] finished tweaking git repo https://github.com/bruceg/vecmap [INFO] tweaked toml for git repo https://github.com/bruceg/vecmap written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/bruceg/vecmap already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `proptest` dependency) [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4686b9a8606604d733a91b5c588753358dd5db3d14d7495b6206da8525eb68ad [INFO] running `Command { std: "docker" "start" "-a" "4686b9a8606604d733a91b5c588753358dd5db3d14d7495b6206da8525eb68ad", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4686b9a8606604d733a91b5c588753358dd5db3d14d7495b6206da8525eb68ad", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4686b9a8606604d733a91b5c588753358dd5db3d14d7495b6206da8525eb68ad", kill_on_drop: false }` [INFO] [stdout] 4686b9a8606604d733a91b5c588753358dd5db3d14d7495b6206da8525eb68ad [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 07c4476410c09ebe8745f96691615d8921d2b04168c9568c3e230912c679e49f [INFO] running `Command { std: "docker" "start" "-a" "07c4476410c09ebe8745f96691615d8921d2b04168c9568c3e230912c679e49f", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `proptest` dependency) [INFO] [stderr] Compiling libc v0.2.150 [INFO] [stderr] Compiling proc-macro2 v1.0.70 [INFO] [stderr] Compiling memoffset v0.9.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling crossbeam-epoch v0.9.15 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Compiling serde v1.0.193 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Checking smallvec v1.11.2 [INFO] [stderr] Compiling serde_json v1.0.108 [INFO] [stderr] Compiling rustix v0.38.26 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Compiling rayon-core v1.12.0 [INFO] [stderr] Checking half v1.8.2 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Checking ciborium-io v0.2.1 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking linux-raw-sys v0.4.12 [INFO] [stderr] Checking crossbeam-deque v0.8.3 [INFO] [stderr] Checking plotters-backend v0.3.5 [INFO] [stderr] Checking getrandom v0.2.11 [INFO] [stderr] Compiling syn v2.0.39 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking clap_lex v0.6.0 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking plotters-svg v0.3.5 [INFO] [stderr] Checking clap_builder v4.4.11 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking ciborium-ll v0.2.1 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking anymap v1.0.0-beta.2 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking generic_singleton v0.5.0 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking rayon v1.8.0 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking plotters v0.3.5 [INFO] [stderr] Checking dashmap v5.5.3 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking rand_xorshift v0.3.0 [INFO] [stderr] Checking itertools v0.12.0 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Checking clap v4.4.11 [INFO] [stderr] Checking unarray v0.1.4 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking proptest v1.4.0 [INFO] [stderr] Compiling serde_derive v1.0.193 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Checking vecmap v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/keystore.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 17 | fn insert(&self, key: K) -> SharedKeys { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | / self.inserts [INFO] [stdout] 27 | | .entry(key.clone()) [INFO] [stdout] 28 | | .or_insert_with(|| { [INFO] [stdout] 29 | | let index = self [INFO] [stdout] ... | [INFO] [stdout] 41 | | ) [INFO] [stdout] 42 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/keystore.rs:37:21 [INFO] [stdout] | [INFO] [stdout] 17 | fn insert(&self, key: K) -> SharedKeys { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | / self.indices [INFO] [stdout] 38 | | .iter() [INFO] [stdout] 39 | | .map(|(key, &index)| (key.clone(), index)) [INFO] [stdout] 40 | | .chain(iter::once((key, index))), [INFO] [stdout] | |________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/keystore.rs:39:47 [INFO] [stdout] | [INFO] [stdout] 39 | .map(|(key, &index)| (key.clone(), index)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/keystore.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 49 | fn from_iter>(keys: I) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | Self::from_iter( [INFO] [stdout] 51 | / keys.into_iter() [INFO] [stdout] 52 | | .enumerate() [INFO] [stdout] 53 | | .map(|(index, key)| (key, index)), [INFO] [stdout] | |_________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/keystore.rs:61:22 [INFO] [stdout] | [INFO] [stdout] 59 | fn from_iter>(indices: I) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | Self { [INFO] [stdout] 61 | indices: indices.into_iter().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/keystore.rs:62:22 [INFO] [stdout] | [INFO] [stdout] 59 | fn from_iter>(indices: I) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | inserts: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/keystore.rs:104:14 [INFO] [stdout] | [INFO] [stdout] 103 | fn from_iter>(keys: I) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | Self(Arc::new(KeysInner::from_iter(keys))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/keystore.rs:110:14 [INFO] [stdout] | [INFO] [stdout] 109 | fn from_iter>(indices: I) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | Self(Arc::new(KeysInner::from_iter(indices))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/keystore.rs:177:9 [INFO] [stdout] | [INFO] [stdout] 175 | fn get(keys: Vec) -> SharedKeys { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | let map = Self::get_map(); [INFO] [stdout] 177 | / map.get(&keys) [INFO] [stdout] 178 | | .map(|got| got.value().clone()) [INFO] [stdout] | |___________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/keystore.rs:179:29 [INFO] [stdout] | [INFO] [stdout] 175 | fn get(keys: Vec) -> SharedKeys { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 179 | .unwrap_or_else(|| { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 180 | | let value = SharedKeys::from_iter(keys.iter().cloned()); [INFO] [stdout] 181 | | let entry = map.entry(keys).or_insert(value); [INFO] [stdout] 182 | | entry.value().clone() [INFO] [stdout] 183 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/map.rs:21:21 [INFO] [stdout] | [INFO] [stdout] 18 | let keys = S::get(Vec::new()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | values: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/map.rs:88:39 [INFO] [stdout] | [INFO] [stdout] 88 | .map(|(key, value)| (key, Some(value))) [INFO] [stdout] | ------------ ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/map.rs:133:19 [INFO] [stdout] | [INFO] [stdout] 131 | fn into_iter(self) -> Self::IntoIter { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | IntoIter { [INFO] [stdout] 133 | keys: self.keys.indices().clone().into_iter(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vecmap` (lib) due to 14 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "07c4476410c09ebe8745f96691615d8921d2b04168c9568c3e230912c679e49f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "07c4476410c09ebe8745f96691615d8921d2b04168c9568c3e230912c679e49f", kill_on_drop: false }` [INFO] [stdout] 07c4476410c09ebe8745f96691615d8921d2b04168c9568c3e230912c679e49f