[INFO] cloning repository https://github.com/brokenbyte/ds2img [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/brokenbyte/ds2img" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbrokenbyte%2Fds2img", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbrokenbyte%2Fds2img'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f48f7fe0ad1da3d1a241006d6811c8c074467c42 [INFO] checking brokenbyte/ds2img/f48f7fe0ad1da3d1a241006d6811c8c074467c42 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbrokenbyte%2Fds2img" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/brokenbyte/ds2img on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/brokenbyte/ds2img [INFO] finished tweaking git repo https://github.com/brokenbyte/ds2img [INFO] tweaked toml for git repo https://github.com/brokenbyte/ds2img written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/brokenbyte/ds2img already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d373f3a4c9f4c4f60bdbc48f2be03afad78feef1f5111915be54bd89daeba8ae [INFO] running `Command { std: "docker" "start" "-a" "d373f3a4c9f4c4f60bdbc48f2be03afad78feef1f5111915be54bd89daeba8ae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d373f3a4c9f4c4f60bdbc48f2be03afad78feef1f5111915be54bd89daeba8ae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d373f3a4c9f4c4f60bdbc48f2be03afad78feef1f5111915be54bd89daeba8ae", kill_on_drop: false }` [INFO] [stdout] d373f3a4c9f4c4f60bdbc48f2be03afad78feef1f5111915be54bd89daeba8ae [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6e3867105a7cfbc616ca8e30f625203507d88398bea9775730acfc40702ae6fa [INFO] running `Command { std: "docker" "start" "-a" "6e3867105a7cfbc616ca8e30f625203507d88398bea9775730acfc40702ae6fa", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.67 [INFO] [stderr] Compiling serde v1.0.188 [INFO] [stderr] Compiling libc v0.2.148 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking bitflags v2.4.0 [INFO] [stderr] Compiling rustix v0.38.15 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Checking hashbrown v0.14.1 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Checking regex-syntax v0.7.5 [INFO] [stderr] Compiling num-traits v0.2.16 [INFO] [stderr] Checking linux-raw-sys v0.4.8 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking clap_lex v0.5.1 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking winnow v0.5.15 [INFO] [stderr] Checking anstyle-parse v0.2.2 [INFO] [stderr] Checking iana-time-zone v0.1.57 [INFO] [stderr] Checking crc-catalog v2.2.0 [INFO] [stderr] Checking anstream v0.6.4 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking crc v3.0.1 [INFO] [stderr] Checking termcolor v1.3.0 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking fscommon v0.1.1 [INFO] [stderr] Checking aho-corasick v1.1.1 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Checking clap_builder v4.4.6 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking indexmap v2.0.2 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling syn v2.0.37 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking uuid v1.4.1 [INFO] [stderr] Checking gpt v3.1.0 [INFO] [stderr] Checking chrono v0.4.31 [INFO] [stderr] Checking regex-automata v0.3.9 [INFO] [stderr] Checking fatfs v0.3.6 [INFO] [stderr] Checking regex v1.9.6 [INFO] [stderr] Compiling serde_derive v1.0.188 [INFO] [stderr] Compiling clap_derive v4.4.2 [INFO] [stderr] Checking env_logger v0.10.0 [INFO] [stderr] Checking clap v4.4.6 [INFO] [stderr] Checking serde_spanned v0.6.3 [INFO] [stderr] Checking toml_datetime v0.6.3 [INFO] [stderr] Checking toml_edit v0.20.1 [INFO] [stderr] Checking toml v0.8.1 [INFO] [stderr] Checking ds2img v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:155:5 [INFO] [stdout] | [INFO] [stdout] 102 | fn write_partitions(partitions: Vec, output: &String) { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | let mut file = OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | let mut mem_device = Box::new(file); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | let mut gdisk = init_gpt(&mut mem_device, total_size); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | let data = gdisk [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | let mut file = gdisk.write().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 155 | data.into_iter() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ext4.rs:33:8 [INFO] [stdout] | [INFO] [stdout] 31 | let img = File::open("ext4.img").unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | [INFO] [stdout] 33 | Ok(Partition { [INFO] [stdout] | ________^ [INFO] [stdout] 34 | | size, [INFO] [stdout] 35 | | data: Box::new(img), [INFO] [stdout] 36 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ext4.rs:45:26 [INFO] [stdout] | [INFO] [stdout] 45 | .map(|entry| entry.metadata().map(|e| e.len()).unwrap_or(0)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fat32.rs:132:8 [INFO] [stdout] | [INFO] [stdout] 88 | let mut buf_stream = fscommon::BufStream::new(&mut fat_slice); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | Ok(Partition { [INFO] [stdout] | ________^ [INFO] [stdout] 133 | | size: file.len() as u64, [INFO] [stdout] 134 | | data: Box::new(Cursor::new(file)), [INFO] [stdout] 135 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:155:5 [INFO] [stdout] | [INFO] [stdout] 102 | fn write_partitions(partitions: Vec, output: &String) { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | let mut file = OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | let mut mem_device = Box::new(file); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | let mut gdisk = init_gpt(&mut mem_device, total_size); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | let data = gdisk [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | let mut file = gdisk.write().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 155 | data.into_iter() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ds2img` (bin "ds2img" test) due to 5 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ext4.rs:33:8 [INFO] [stdout] | [INFO] [stdout] 31 | let img = File::open("ext4.img").unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | [INFO] [stdout] 33 | Ok(Partition { [INFO] [stdout] | ________^ [INFO] [stdout] 34 | | size, [INFO] [stdout] 35 | | data: Box::new(img), [INFO] [stdout] 36 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ext4.rs:45:26 [INFO] [stdout] | [INFO] [stdout] 45 | .map(|entry| entry.metadata().map(|e| e.len()).unwrap_or(0)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fat32.rs:132:8 [INFO] [stdout] | [INFO] [stdout] 88 | let mut buf_stream = fscommon::BufStream::new(&mut fat_slice); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | Ok(Partition { [INFO] [stdout] | ________^ [INFO] [stdout] 133 | | size: file.len() as u64, [INFO] [stdout] 134 | | data: Box::new(Cursor::new(file)), [INFO] [stdout] 135 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ds2img` (bin "ds2img") due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "6e3867105a7cfbc616ca8e30f625203507d88398bea9775730acfc40702ae6fa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6e3867105a7cfbc616ca8e30f625203507d88398bea9775730acfc40702ae6fa", kill_on_drop: false }` [INFO] [stdout] 6e3867105a7cfbc616ca8e30f625203507d88398bea9775730acfc40702ae6fa