[INFO] cloning repository https://github.com/brinchj/rust-sudoku-fun [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/brinchj/rust-sudoku-fun" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbrinchj%2Frust-sudoku-fun", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbrinchj%2Frust-sudoku-fun'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 849f6a4ac8d2168e7a273a5b1bbee70e6837cb2d [INFO] checking brinchj/rust-sudoku-fun/849f6a4ac8d2168e7a273a5b1bbee70e6837cb2d against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbrinchj%2Frust-sudoku-fun" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/brinchj/rust-sudoku-fun on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/brinchj/rust-sudoku-fun [INFO] finished tweaking git repo https://github.com/brinchj/rust-sudoku-fun [INFO] tweaked toml for git repo https://github.com/brinchj/rust-sudoku-fun written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/brinchj/rust-sudoku-fun already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b46335b2cc9758b3276a0f59d055f0c9eb80f3d9bd5e50176d4d424bc459a3fe [INFO] running `Command { std: "docker" "start" "-a" "b46335b2cc9758b3276a0f59d055f0c9eb80f3d9bd5e50176d4d424bc459a3fe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b46335b2cc9758b3276a0f59d055f0c9eb80f3d9bd5e50176d4d424bc459a3fe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b46335b2cc9758b3276a0f59d055f0c9eb80f3d9bd5e50176d4d424bc459a3fe", kill_on_drop: false }` [INFO] [stdout] b46335b2cc9758b3276a0f59d055f0c9eb80f3d9bd5e50176d4d424bc459a3fe [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d12ed823e62ddf1d40816c738a58865ac07e85c5701551c27bb9aeefc4f0ea4f [INFO] running `Command { std: "docker" "start" "-a" "d12ed823e62ddf1d40816c738a58865ac07e85c5701551c27bb9aeefc4f0ea4f", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling winapi-build v0.1.1 [INFO] [stderr] Compiling cc v1.0.17 [INFO] [stderr] Checking libc v0.2.42 [INFO] [stderr] Compiling unicode-xid v0.0.4 [INFO] [stderr] Checking winapi v0.2.8 [INFO] [stderr] Checking cfg-if v0.1.3 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling quote v0.3.15 [INFO] [stderr] Checking debug-builders v0.1.0 [INFO] [stderr] Compiling debugtrace v0.1.0 [INFO] [stderr] Checking custom_derive v0.1.7 [INFO] [stderr] Checking rustc-demangle v0.1.8 [INFO] [stderr] Checking bitflags v0.7.0 [INFO] [stderr] Checking either v0.1.7 [INFO] [stderr] Checking conv v0.3.3 [INFO] [stderr] Compiling synom v0.11.3 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling kernel32-sys v0.2.2 [INFO] [stderr] Compiling dbghelp-sys v0.2.0 [INFO] [stderr] Compiling syn v0.11.11 [INFO] [stderr] Compiling rustc_version v0.2.2 [INFO] [stderr] Compiling im v10.2.0 [INFO] [stderr] Compiling synstructure v0.6.1 [INFO] [stderr] Compiling backtrace-sys v0.1.23 [INFO] [stderr] Compiling failure_derive v0.1.1 [INFO] [stderr] Checking backtrace v0.1.8 [INFO] [stderr] Checking backtrace v0.3.8 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Checking chomp v0.3.1 [INFO] [stderr] Checking sudokusolver v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused `#[macro_use]` import [INFO] [stdout] --> src/lib.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | #[macro_use] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `#[macro_use]` import [INFO] [stdout] --> src/lib.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | #[macro_use] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `iterator_step_by` has been stable since 1.28.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(iterator_step_by)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `iterator_step_by` has been stable since 1.28.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(iterator_step_by)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/board.rs:15:27 [INFO] [stdout] | [INFO] [stdout] 15 | (0..=8).map(|row| Self::all().skip(9 * row).take(9)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/board.rs:18:27 [INFO] [stdout] | [INFO] [stdout] 18 | (0..=8).map(|col| Self::all().skip(col).step_by(9)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/board.rs:56:20 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn new(input: impl Iterator)>) -> Board { [INFO] [stdout] | --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | Board { [INFO] [stdout] 56 | inner: input [INFO] [stdout] | ____________________^ [INFO] [stdout] 57 | | .filter_map(move |(pos, opt)| opt.map(|n| (pos, n))) [INFO] [stdout] 58 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/board.rs:91:24 [INFO] [stdout] | [INFO] [stdout] 89 | fn line_dups(&self, line: impl Iterator) -> usize { [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | let values = line.flat_map(|pos| self.at(&pos)).collect::>(); [INFO] [stdout] 91 | values.len() - values.iter().collect::>().len() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/board.rs:131:38 [INFO] [stdout] | [INFO] [stdout] 131 | .filter_map(move |n| self.with(pos, *n).and_then(|b| solve_next(&b, *n))) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:31:8 [INFO] [stdout] | [INFO] [stdout] 31 | Ok(Board::new(Position::all().zip(values))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/board.rs:15:27 [INFO] [stdout] | [INFO] [stdout] 15 | (0..=8).map(|row| Self::all().skip(9 * row).take(9)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/board.rs:18:27 [INFO] [stdout] | [INFO] [stdout] 18 | (0..=8).map(|col| Self::all().skip(col).step_by(9)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/board.rs:56:20 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn new(input: impl Iterator)>) -> Board { [INFO] [stdout] | --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | Board { [INFO] [stdout] 56 | inner: input [INFO] [stdout] | ____________________^ [INFO] [stdout] 57 | | .filter_map(move |(pos, opt)| opt.map(|n| (pos, n))) [INFO] [stdout] 58 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/board.rs:91:24 [INFO] [stdout] | [INFO] [stdout] 89 | fn line_dups(&self, line: impl Iterator) -> usize { [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | let values = line.flat_map(|pos| self.at(&pos)).collect::>(); [INFO] [stdout] 91 | values.len() - values.iter().collect::>().len() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/board.rs:131:38 [INFO] [stdout] | [INFO] [stdout] 131 | .filter_map(move |n| self.with(pos, *n).and_then(|b| solve_next(&b, *n))) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:31:8 [INFO] [stdout] | [INFO] [stdout] 31 | Ok(Board::new(Position::all().zip(values))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sudokusolver` (lib test) due to 7 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `sudokusolver` (lib) due to 7 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "d12ed823e62ddf1d40816c738a58865ac07e85c5701551c27bb9aeefc4f0ea4f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d12ed823e62ddf1d40816c738a58865ac07e85c5701551c27bb9aeefc4f0ea4f", kill_on_drop: false }` [INFO] [stdout] d12ed823e62ddf1d40816c738a58865ac07e85c5701551c27bb9aeefc4f0ea4f