[INFO] cloning repository https://github.com/bricks-rs/rcx [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/bricks-rs/rcx" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbricks-rs%2Frcx", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbricks-rs%2Frcx'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 87bf9495cceadeb58342416937531d8dba71f34f [INFO] checking bricks-rs/rcx/87bf9495cceadeb58342416937531d8dba71f34f against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbricks-rs%2Frcx" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/bricks-rs/rcx on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/bricks-rs/rcx [INFO] finished tweaking git repo https://github.com/bricks-rs/rcx [INFO] tweaked toml for git repo https://github.com/bricks-rs/rcx written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/bricks-rs/rcx already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 820060a8b4994190ec5857482bb02c19d28ff5321ef6c6b0484635c58ce83697 [INFO] running `Command { std: "docker" "start" "-a" "820060a8b4994190ec5857482bb02c19d28ff5321ef6c6b0484635c58ce83697", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "820060a8b4994190ec5857482bb02c19d28ff5321ef6c6b0484635c58ce83697", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "820060a8b4994190ec5857482bb02c19d28ff5321ef6c6b0484635c58ce83697", kill_on_drop: false }` [INFO] [stdout] 820060a8b4994190ec5857482bb02c19d28ff5321ef6c6b0484635c58ce83697 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 74f0ec161b69584c8b1341781e714297149b5fa78f5596cbfab8c816680926e9 [INFO] running `Command { std: "docker" "start" "-a" "74f0ec161b69584c8b1341781e714297149b5fa78f5596cbfab8c816680926e9", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling minimal-lexical v0.2.1 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Compiling mime v0.3.17 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling hashbrown v0.14.3 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Compiling rustversion v1.0.14 [INFO] [stderr] Compiling askama_escape v0.10.3 [INFO] [stderr] Compiling itoa v1.0.10 [INFO] [stderr] Compiling percent-encoding v2.3.1 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Compiling cc v1.0.88 [INFO] [stderr] Compiling ryu v1.0.17 [INFO] [stderr] Compiling unsafe-libyaml v0.2.10 [INFO] [stderr] Checking gimli v0.28.1 [INFO] [stderr] Compiling thiserror v1.0.57 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Compiling eyre v0.6.12 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking object v0.32.2 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Compiling mime_guess v2.0.4 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling humansize v2.1.3 [INFO] [stderr] Compiling indexmap v2.2.5 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking rustc-demangle v0.1.23 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Compiling syn v2.0.52 [INFO] [stderr] Checking owo-colors v3.5.0 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking pretty_assertions v1.4.0 [INFO] [stderr] Checking bstr v1.9.1 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Checking similar v2.4.0 [INFO] [stderr] Checking hex-literal v0.4.1 [INFO] [stderr] Checking regex-automata v0.4.5 [INFO] [stderr] Compiling backtrace v0.3.69 [INFO] [stderr] Compiling askama_parser v0.2.1 [INFO] [stderr] Checking addr2line v0.21.0 [INFO] [stderr] Checking globset v0.4.14 [INFO] [stderr] Checking insta v1.35.1 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling thiserror-impl v1.0.57 [INFO] [stderr] Compiling strum_macros v0.26.1 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking strum v0.26.1 [INFO] [stderr] Checking tracing-error v0.2.0 [INFO] [stderr] Checking nqc v0.0.0 (/opt/rustwide/workdir/nqc) [INFO] [stdout] warning: fields `span` and `kind` are never read [INFO] [stdout] --> nqc/src/ast/mod.rs:211:5 [INFO] [stdout] | [INFO] [stdout] 210 | pub struct Expr<'src> { [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] 211 | span: Span, [INFO] [stdout] | ^^^^ [INFO] [stdout] 212 | kind: ExprKind<'src>, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Expr` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `src` is never read [INFO] [stdout] --> nqc/src/lexer/mod.rs:251:5 [INFO] [stdout] | [INFO] [stdout] 250 | pub struct Tokens<'src> { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 251 | src: Src<'src>, [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `span` and `kind` are never read [INFO] [stdout] --> nqc/src/ast/mod.rs:211:5 [INFO] [stdout] | [INFO] [stdout] 210 | pub struct Expr<'src> { [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] 211 | span: Span, [INFO] [stdout] | ^^^^ [INFO] [stdout] 212 | kind: ExprKind<'src>, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Expr` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `src` is never read [INFO] [stdout] --> nqc/src/lexer/mod.rs:251:5 [INFO] [stdout] | [INFO] [stdout] 250 | pub struct Tokens<'src> { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 251 | src: Src<'src>, [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking color-spantrace v0.2.1 [INFO] [stderr] Checking color-eyre v0.6.2 [INFO] [stderr] Compiling basic-toml v0.1.8 [INFO] [stderr] Compiling serde_yaml v0.9.32 [INFO] [stderr] Compiling askama_derive v0.12.5 [INFO] [stderr] Compiling askama v0.12.1 [INFO] [stderr] Compiling rcx v0.1.3 (/opt/rustwide/workdir/rcx) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> rcx/src/lib.rs:24:20 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn new(tower: impl IrTower + 'static) -> Self { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | Self { [INFO] [stdout] 24 | tower: Box::new(tower), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> rcx/src/lib.rs:24:20 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn new(tower: impl IrTower + 'static) -> Self { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | Self { [INFO] [stdout] 24 | tower: Box::new(tower), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> rcx/src/binfmt.rs:166:17 [INFO] [stdout] | [INFO] [stdout] 164 | let (i, symbols) = nom::multi::count(parse_symbol, symbol_count.into())(i)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 165 | [INFO] [stdout] 166 | IResult::Ok(( [INFO] [stdout] | _________________^ [INFO] [stdout] 167 | | i, [INFO] [stdout] 168 | | RcxBin { [INFO] [stdout] 169 | | signature: signature.try_into().unwrap_or([0; 4]), [INFO] [stdout] ... | [INFO] [stdout] 177 | | }, [INFO] [stdout] 178 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> rcx/src/binfmt.rs:166:17 [INFO] [stdout] | [INFO] [stdout] 164 | let (i, symbols) = nom::multi::count(parse_symbol, symbol_count.into())(i)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 165 | [INFO] [stdout] 166 | IResult::Ok(( [INFO] [stdout] | _________________^ [INFO] [stdout] 167 | | i, [INFO] [stdout] 168 | | RcxBin { [INFO] [stdout] 169 | | signature: signature.try_into().unwrap_or([0; 4]), [INFO] [stdout] ... | [INFO] [stdout] 177 | | }, [INFO] [stdout] 178 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> rcx/src/tower/usb.rs:30:12 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn open(device: impl AsRef) -> Result { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | let device = OpenOptions::new().read(true).write(true).open(device)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 31 | | device, [INFO] [stdout] 32 | | use_alternate_opcode: false, [INFO] [stdout] 33 | | last_tx: Instant::now(), [INFO] [stdout] 34 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> rcx/src/tower/usb.rs:30:12 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn open(device: impl AsRef) -> Result { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | let device = OpenOptions::new().read(true).write(true).open(device)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 31 | | device, [INFO] [stdout] 32 | | use_alternate_opcode: false, [INFO] [stdout] 33 | | last_tx: Instant::now(), [INFO] [stdout] 34 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rcx` (lib test) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rcx` (lib) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "74f0ec161b69584c8b1341781e714297149b5fa78f5596cbfab8c816680926e9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "74f0ec161b69584c8b1341781e714297149b5fa78f5596cbfab8c816680926e9", kill_on_drop: false }` [INFO] [stdout] 74f0ec161b69584c8b1341781e714297149b5fa78f5596cbfab8c816680926e9