[INFO] cloning repository https://github.com/briannelson95/convertit [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/briannelson95/convertit" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbriannelson95%2Fconvertit", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbriannelson95%2Fconvertit'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 16408bf1d9fe62bff0a3656bc96a08e6a96b010a [INFO] checking briannelson95/convertit/16408bf1d9fe62bff0a3656bc96a08e6a96b010a against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbriannelson95%2Fconvertit" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/briannelson95/convertit on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/briannelson95/convertit [INFO] finished tweaking git repo https://github.com/briannelson95/convertit [INFO] tweaked toml for git repo https://github.com/briannelson95/convertit written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/briannelson95/convertit already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ad4f9f6047b1fb781b081cab1c4a7f2195d6e7900f101822b8dadc3d90a26bf7 [INFO] running `Command { std: "docker" "start" "-a" "ad4f9f6047b1fb781b081cab1c4a7f2195d6e7900f101822b8dadc3d90a26bf7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ad4f9f6047b1fb781b081cab1c4a7f2195d6e7900f101822b8dadc3d90a26bf7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ad4f9f6047b1fb781b081cab1c4a7f2195d6e7900f101822b8dadc3d90a26bf7", kill_on_drop: false }` [INFO] [stdout] ad4f9f6047b1fb781b081cab1c4a7f2195d6e7900f101822b8dadc3d90a26bf7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a09ab84b438ca6a2677f5f2ec3fb446f8b8018658748c44c571770cc508b9f28 [INFO] running `Command { std: "docker" "start" "-a" "a09ab84b438ca6a2677f5f2ec3fb446f8b8018658748c44c571770cc508b9f28", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Compiling target-lexicon v0.12.14 [INFO] [stderr] Compiling winnow v0.6.11 [INFO] [stderr] Compiling smallvec v1.13.2 [INFO] [stderr] Compiling version-compare v0.2.0 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Compiling gio v0.16.7 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Checking unic-common v0.9.0 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking unic-char-range v0.9.0 [INFO] [stderr] Checking unic-ucd-version v0.9.0 [INFO] [stderr] Checking unic-char-property v0.9.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling memoffset v0.9.1 [INFO] [stderr] Checking miniz_oxide v0.7.3 [INFO] [stderr] Checking aligned-vec v0.5.0 [INFO] [stderr] Checking unic-ucd-bidi v0.9.0 [INFO] [stderr] Checking matches v0.1.10 [INFO] [stderr] Compiling built v0.7.3 [INFO] [stderr] Checking unic-bidi v0.9.0 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking v_frame v0.3.8 [INFO] [stderr] Checking num-bigint v0.4.5 [INFO] [stderr] Checking kurbo v0.9.5 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Compiling cfg-expr v0.15.8 [INFO] [stderr] Checking bytemuck v1.16.0 [INFO] [stderr] Compiling rav1e v0.7.1 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking maybe-rayon v0.1.1 [INFO] [stderr] Compiling field-offset v0.3.6 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Compiling simd_helpers v0.1.0 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking flate2 v1.0.30 [INFO] [stderr] Compiling gtk v0.16.2 [INFO] [stderr] Checking bitstream-io v2.3.0 [INFO] [stderr] Compiling noop_proc_macro v0.3.0 [INFO] [stderr] Checking weezl v0.1.8 [INFO] [stderr] Checking xi-unicode v0.3.0 [INFO] [stderr] Compiling jobserver v0.1.31 [INFO] [stderr] Checking new_debug_unreachable v1.0.6 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking piet v0.6.2 [INFO] [stderr] Checking imgref v1.10.1 [INFO] [stderr] Checking type-map v0.5.0 [INFO] [stderr] Compiling cc v1.0.98 [INFO] [stderr] Checking flume v0.11.0 [INFO] [stderr] Checking rgb v0.8.37 [INFO] [stderr] Checking fdeflate v0.3.4 [INFO] [stderr] Checking zune-inflate v0.2.54 [INFO] [stderr] Checking loop9 v0.1.5 [INFO] [stderr] Checking avif-serialize v0.8.1 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking bit_field v0.10.2 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking zune-core v0.4.12 [INFO] [stderr] Checking self_cell v1.0.4 [INFO] [stderr] Checking quick-error v2.0.1 [INFO] [stderr] Checking byteorder-lite v0.1.0 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Compiling druid-shell v0.8.3 [INFO] [stderr] Checking jpeg-decoder v0.3.1 [INFO] [stderr] Checking lebe v0.5.2 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking zune-jpeg v0.4.11 [INFO] [stderr] Checking png v0.17.13 [INFO] [stderr] Checking gif v0.13.1 [INFO] [stderr] Checking exr v1.72.0 [INFO] [stderr] Checking self_cell v0.10.3 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Checking tiff v0.9.1 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking keyboard-types v0.6.2 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking raw-window-handle v0.5.2 [INFO] [stderr] Checking ascii v1.1.0 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking av1-grain v0.2.3 [INFO] [stderr] Compiling libwebp-sys v0.9.5 [INFO] [stderr] Checking which v4.4.2 [INFO] [stderr] Checking versions v5.0.1 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling toml_datetime v0.6.6 [INFO] [stderr] Compiling serde_spanned v0.6.6 [INFO] [stderr] Compiling toml_edit v0.19.15 [INFO] [stderr] Compiling toml_edit v0.22.14 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling displaydoc v0.2.4 [INFO] [stderr] Compiling profiling-procmacros v1.0.15 [INFO] [stderr] Compiling arg_enum_proc_macro v0.3.4 [INFO] [stderr] Compiling num-derive v0.4.2 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling druid-derive v0.5.1 [INFO] [stderr] Checking profiling v1.0.15 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking thiserror v1.0.61 [INFO] [stderr] Checking tinystr v0.7.6 [INFO] [stderr] Checking fluent-syntax v0.11.1 [INFO] [stderr] Checking image-webp v0.1.2 [INFO] [stderr] Checking native-dialog v0.7.0 [INFO] [stderr] Checking unic-langid-impl v0.9.5 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking unic-langid v0.9.5 [INFO] [stderr] Checking fluent-langneg v0.13.0 [INFO] [stderr] Checking intl_pluralrules v7.0.2 [INFO] [stderr] Checking intl-memoizer v0.5.2 [INFO] [stderr] Compiling proc-macro-crate v1.3.1 [INFO] [stderr] Checking fluent-bundle v0.15.3 [INFO] [stderr] Compiling toml v0.8.14 [INFO] [stderr] Compiling glib-macros v0.16.8 [INFO] [stderr] Compiling gtk3-macros v0.16.3 [INFO] [stderr] Compiling system-deps v6.2.2 [INFO] [stderr] Compiling glib-sys v0.16.3 [INFO] [stderr] Compiling gobject-sys v0.16.3 [INFO] [stderr] Compiling gio-sys v0.16.3 [INFO] [stderr] Compiling pango-sys v0.16.3 [INFO] [stderr] Compiling cairo-sys-rs v0.16.3 [INFO] [stderr] Compiling gdk-sys v0.16.0 [INFO] [stderr] Compiling atk-sys v0.16.0 [INFO] [stderr] Compiling gdk-pixbuf-sys v0.16.3 [INFO] [stderr] Compiling gtk-sys v0.16.0 [INFO] [stderr] Compiling pangocairo-sys v0.16.3 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking glib v0.16.9 [INFO] [stderr] Checking ravif v0.11.5 [INFO] [stderr] Checking image v0.25.1 [INFO] [stderr] Checking webp v0.3.0 [INFO] [stderr] Checking cairo-rs v0.16.7 [INFO] [stderr] Checking atk v0.16.0 [INFO] [stderr] Checking pango v0.16.5 [INFO] [stderr] Checking gdk-pixbuf v0.16.7 [INFO] [stderr] Checking pangocairo v0.16.3 [INFO] [stderr] Checking gdk v0.16.2 [INFO] [stderr] Checking piet-cairo v0.6.2 [INFO] [stderr] Checking piet-common v0.6.2 [INFO] [stderr] Checking druid v0.8.3 [INFO] [stderr] Checking ConvertIt v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:66:5 [INFO] [stdout] | [INFO] [stdout] 19 | let input_label = Label::new("Input Path:"); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | let input_textbox = TextBox::new().lens(AppState::input_path); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | [INFO] [stdout] 22 | let input_browse_button = Button::new("Browse...").on_click(|_ctx, data: &mut AppState, _env| { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | let output_label = Label::new("Output Path:"); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | let output_textbox = TextBox::new().lens(AppState::output_path); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | let output_browse_button = Button::new("Browse...").on_click(|_ctx, data: &mut AppState, _env| { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | let quality_label = Label::new("Quality:"); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | let quality_slider = Slider::new().with_range(0.0, 100.0).lens(parse_lens::RoundLens); [INFO] [stdout] 47 | let quality_textbox = TextBox::new().lens(AppState::quality); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | [INFO] [stdout] 49 | let status_label = Label::new(|data: &AppState, _: &Env| data.status.clone()); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | [INFO] [stdout] 51 | let convert_button = Button::new("Convert") [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | / Flex::column() [INFO] [stdout] 67 | | .with_child(input_label) [INFO] [stdout] 68 | | .with_child(Flex::row().with_flex_child(input_textbox, 1.0).with_child(input_browse_button)) [INFO] [stdout] 69 | | .with_child(output_label) [INFO] [stdout] ... | [INFO] [stdout] 73 | | .with_child(quality_textbox) [INFO] [stdout] 74 | | .with_child(convert_button) [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:66:5 [INFO] [stdout] | [INFO] [stdout] 19 | let input_label = Label::new("Input Path:"); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | let input_textbox = TextBox::new().lens(AppState::input_path); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | [INFO] [stdout] 22 | let input_browse_button = Button::new("Browse...").on_click(|_ctx, data: &mut AppState, _env| { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | let output_label = Label::new("Output Path:"); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | let output_textbox = TextBox::new().lens(AppState::output_path); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | let output_browse_button = Button::new("Browse...").on_click(|_ctx, data: &mut AppState, _env| { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | let quality_label = Label::new("Quality:"); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | let quality_slider = Slider::new().with_range(0.0, 100.0).lens(parse_lens::RoundLens); [INFO] [stdout] 47 | let quality_textbox = TextBox::new().lens(AppState::quality); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | [INFO] [stdout] 49 | let status_label = Label::new(|data: &AppState, _: &Env| data.status.clone()); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | [INFO] [stdout] 51 | let convert_button = Button::new("Convert") [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | / Flex::column() [INFO] [stdout] 67 | | .with_child(input_label) [INFO] [stdout] 68 | | .with_child(Flex::row().with_flex_child(input_textbox, 1.0).with_child(input_browse_button)) [INFO] [stdout] 69 | | .with_child(output_label) [INFO] [stdout] ... | [INFO] [stdout] 73 | | .with_child(quality_textbox) [INFO] [stdout] 74 | | .with_child(convert_button) [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ConvertIt` (bin "ConvertIt" test) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `ConvertIt` (bin "ConvertIt") due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "a09ab84b438ca6a2677f5f2ec3fb446f8b8018658748c44c571770cc508b9f28", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a09ab84b438ca6a2677f5f2ec3fb446f8b8018658748c44c571770cc508b9f28", kill_on_drop: false }` [INFO] [stdout] a09ab84b438ca6a2677f5f2ec3fb446f8b8018658748c44c571770cc508b9f28