[INFO] cloning repository https://github.com/brian-dawn/jot [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/brian-dawn/jot" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbrian-dawn%2Fjot", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbrian-dawn%2Fjot'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 411acce3d7dd7c72954adf162d59fc3a15fb0184 [INFO] checking brian-dawn/jot/411acce3d7dd7c72954adf162d59fc3a15fb0184 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbrian-dawn%2Fjot" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/brian-dawn/jot on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/brian-dawn/jot [INFO] finished tweaking git repo https://github.com/brian-dawn/jot [INFO] tweaked toml for git repo https://github.com/brian-dawn/jot written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/brian-dawn/jot already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c7b96d951de848efecdd559b3a8e366a0b81ce116ffb5ea122a4da861093e49a [INFO] running `Command { std: "docker" "start" "-a" "c7b96d951de848efecdd559b3a8e366a0b81ce116ffb5ea122a4da861093e49a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c7b96d951de848efecdd559b3a8e366a0b81ce116ffb5ea122a4da861093e49a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c7b96d951de848efecdd559b3a8e366a0b81ce116ffb5ea122a4da861093e49a", kill_on_drop: false }` [INFO] [stdout] c7b96d951de848efecdd559b3a8e366a0b81ce116ffb5ea122a4da861093e49a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8007c206ec19ac2571d7604ac28e991a3483caac91928f271a442da42f91ec25 [INFO] running `Command { std: "docker" "start" "-a" "8007c206ec19ac2571d7604ac28e991a3483caac91928f271a442da42f91ec25", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.68 [INFO] [stderr] Compiling proc-macro2 v1.0.9 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling syn v1.0.17 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling serde v1.0.105 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Compiling ryu v1.0.3 [INFO] [stderr] Checking regex-syntax v0.6.17 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Checking itoa v0.4.5 [INFO] [stderr] Compiling serde_json v1.0.55 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Compiling num-integer v0.1.42 [INFO] [stderr] Checking ppv-lite86 v0.2.6 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling anyhow v1.0.27 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking encode_unicode v0.3.6 [INFO] [stderr] Checking remove_dir_all v0.5.2 [INFO] [stderr] Checking colorful v0.2.1 [INFO] [stderr] Checking scrawl v1.1.0 [INFO] [stderr] Checking aho-corasick v0.7.10 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Checking regex-automata v0.1.9 [INFO] [stderr] Compiling quote v1.0.3 [INFO] [stderr] Checking dirs v1.0.5 [INFO] [stderr] Checking term_size v0.3.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking dirs-sys v0.3.4 [INFO] [stderr] Checking clicolors-control v1.0.1 [INFO] [stderr] Checking termios v0.3.1 [INFO] [stderr] Checking term v0.5.2 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking dirs v2.0.2 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking chrono v0.4.11 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking regex v1.3.6 [INFO] [stderr] Checking tempfile v3.1.0 [INFO] [stderr] Checking console v0.10.0 [INFO] [stderr] Compiling serde_derive v1.0.105 [INFO] [stderr] Checking serde_regex v0.4.0 [INFO] [stderr] Checking bstr v0.2.12 [INFO] [stderr] Checking toml v0.5.6 [INFO] [stderr] Checking pidgin v0.4.0 [INFO] [stderr] Checking csv v1.1.3 [INFO] [stderr] Checking two_timer v2.1.0 [INFO] [stderr] Checking prettytable-rs v0.8.0 [INFO] [stderr] Checking jot v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `some_bool` [INFO] [stdout] --> src/commands/view.rs:112:34 [INFO] [stdout] | [INFO] [stdout] 112 | if let Some((start, end, some_bool)) = human_range { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_some_bool` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `some_bool` [INFO] [stdout] --> src/commands/view.rs:112:34 [INFO] [stdout] | [INFO] [stdout] 112 | if let Some((start, end, some_bool)) = human_range { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_some_bool` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/jot.rs:215:25 [INFO] [stdout] | [INFO] [stdout] 215 | .map(|entry| Ok(entry?.path())) [INFO] [stdout] | ----- ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/jot.rs:236:18 [INFO] [stdout] | [INFO] [stdout] 230 | let mut file = File::open(&file_path).ok()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 236 | Some(parse_jot(header_line, &message, &file_path)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/jot.rs:270:10 [INFO] [stdout] | [INFO] [stdout] 258 | let caps = RE.captures(header_line)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 262 | let tags = TAG_RE [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 270 | Some(Jot { [INFO] [stdout] | __________^ [INFO] [stdout] 271 | | datetime: DateTime::from(parsed_date), [INFO] [stdout] 272 | | message: message.trim().to_string(), [INFO] [stdout] 273 | | tags, [INFO] [stdout] ... | [INFO] [stdout] 277 | | path: path.to_owned(), [INFO] [stdout] 278 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `jot` (bin "jot") due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/jot.rs:215:25 [INFO] [stdout] | [INFO] [stdout] 215 | .map(|entry| Ok(entry?.path())) [INFO] [stdout] | ----- ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/jot.rs:236:18 [INFO] [stdout] | [INFO] [stdout] 230 | let mut file = File::open(&file_path).ok()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 236 | Some(parse_jot(header_line, &message, &file_path)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/jot.rs:270:10 [INFO] [stdout] | [INFO] [stdout] 258 | let caps = RE.captures(header_line)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 262 | let tags = TAG_RE [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 270 | Some(Jot { [INFO] [stdout] | __________^ [INFO] [stdout] 271 | | datetime: DateTime::from(parsed_date), [INFO] [stdout] 272 | | message: message.trim().to_string(), [INFO] [stdout] 273 | | tags, [INFO] [stdout] ... | [INFO] [stdout] 277 | | path: path.to_owned(), [INFO] [stdout] 278 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `jot` (bin "jot" test) due to 4 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "8007c206ec19ac2571d7604ac28e991a3483caac91928f271a442da42f91ec25", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8007c206ec19ac2571d7604ac28e991a3483caac91928f271a442da42f91ec25", kill_on_drop: false }` [INFO] [stdout] 8007c206ec19ac2571d7604ac28e991a3483caac91928f271a442da42f91ec25