[INFO] cloning repository https://github.com/brhoades/adaptive-backoff [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/brhoades/adaptive-backoff" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbrhoades%2Fadaptive-backoff", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbrhoades%2Fadaptive-backoff'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] daf3a876f855aa7fd8f896928e96d1e85bc208ff [INFO] checking brhoades/adaptive-backoff/daf3a876f855aa7fd8f896928e96d1e85bc208ff against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbrhoades%2Fadaptive-backoff" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/brhoades/adaptive-backoff on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/brhoades/adaptive-backoff [INFO] finished tweaking git repo https://github.com/brhoades/adaptive-backoff [INFO] tweaked toml for git repo https://github.com/brhoades/adaptive-backoff written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/brhoades/adaptive-backoff already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 231ab406559fb825759396aa895018708c5237bee601c10b317afb7cec6e5e88 [INFO] running `Command { std: "docker" "start" "-a" "231ab406559fb825759396aa895018708c5237bee601c10b317afb7cec6e5e88", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "231ab406559fb825759396aa895018708c5237bee601c10b317afb7cec6e5e88", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "231ab406559fb825759396aa895018708c5237bee601c10b317afb7cec6e5e88", kill_on_drop: false }` [INFO] [stdout] 231ab406559fb825759396aa895018708c5237bee601c10b317afb7cec6e5e88 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0b273ea6daa96146605ee2b7c46fc003759bb3103ad8aa25713ae1b4c4b1db33 [INFO] running `Command { std: "docker" "start" "-a" "0b273ea6daa96146605ee2b7c46fc003759bb3103ad8aa25713ae1b4c4b1db33", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling syn v1.0.54 [INFO] [stderr] Compiling anyhow v1.0.36 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling quote v1.0.3 [INFO] [stderr] Compiling thiserror-impl v1.0.22 [INFO] [stderr] Checking thiserror v1.0.22 [INFO] [stderr] Checking adaptive_backoff v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `success_step` and `fail_step` are never read [INFO] [stdout] --> src/lib/adaptive.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 16 | pub struct Adaptive { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 48 | success_step: f64, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 49 | fail_step: f64, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Adaptive` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/adaptive.rs:137:12 [INFO] [stdout] | [INFO] [stdout] 118 | pub fn build(self) -> Result> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | let mut backoff = if self.backoff.is_some() && self.builder.is_some() { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | return Err(format_err!("adaptive builders from `.adaptive` on a backoff builder cannot be used with the `.backoff` function")); [INFO] [stdout] 121 | } else if let Some(boff) = self.backoff { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | Ok(Adaptive:: { [INFO] [stdout] | ____________^ [INFO] [stdout] 138 | | backoff, [INFO] [stdout] 139 | | fail_mult, [INFO] [stdout] 140 | | success_mult, [INFO] [stdout] ... | [INFO] [stdout] 146 | | fail_step: 1.0 / fail_mult, [INFO] [stdout] 147 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `adaptive_backoff` (lib) due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `success_step` and `fail_step` are never read [INFO] [stdout] --> src/lib/adaptive.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 16 | pub struct Adaptive { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 48 | success_step: f64, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 49 | fail_step: f64, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Adaptive` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/adaptive.rs:137:12 [INFO] [stdout] | [INFO] [stdout] 118 | pub fn build(self) -> Result> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | let mut backoff = if self.backoff.is_some() && self.builder.is_some() { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | return Err(format_err!("adaptive builders from `.adaptive` on a backoff builder cannot be used with the `.backoff` function")); [INFO] [stdout] 121 | } else if let Some(boff) = self.backoff { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | Ok(Adaptive:: { [INFO] [stdout] | ____________^ [INFO] [stdout] 138 | | backoff, [INFO] [stdout] 139 | | fail_mult, [INFO] [stdout] 140 | | success_mult, [INFO] [stdout] ... | [INFO] [stdout] 146 | | fail_step: 1.0 / fail_mult, [INFO] [stdout] 147 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `adaptive_backoff` (lib test) due to 2 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "0b273ea6daa96146605ee2b7c46fc003759bb3103ad8aa25713ae1b4c4b1db33", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0b273ea6daa96146605ee2b7c46fc003759bb3103ad8aa25713ae1b4c4b1db33", kill_on_drop: false }` [INFO] [stdout] 0b273ea6daa96146605ee2b7c46fc003759bb3103ad8aa25713ae1b4c4b1db33