[INFO] cloning repository https://github.com/brendanzab/rust-visitors [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/brendanzab/rust-visitors" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbrendanzab%2Frust-visitors", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbrendanzab%2Frust-visitors'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 682c89da4559e8d370e94191f67a47df24cf9a9a [INFO] checking brendanzab/rust-visitors/682c89da4559e8d370e94191f67a47df24cf9a9a against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbrendanzab%2Frust-visitors" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/brendanzab/rust-visitors on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/brendanzab/rust-visitors [INFO] finished tweaking git repo https://github.com/brendanzab/rust-visitors [INFO] tweaked toml for git repo https://github.com/brendanzab/rust-visitors written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/brendanzab/rust-visitors already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a52874f9725c894931df2f392064fed75396ab05c6adba008a4530f77ff7f804 [INFO] running `Command { std: "docker" "start" "-a" "a52874f9725c894931df2f392064fed75396ab05c6adba008a4530f77ff7f804", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a52874f9725c894931df2f392064fed75396ab05c6adba008a4530f77ff7f804", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a52874f9725c894931df2f392064fed75396ab05c6adba008a4530f77ff7f804", kill_on_drop: false }` [INFO] [stdout] a52874f9725c894931df2f392064fed75396ab05c6adba008a4530f77ff7f804 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4328f4bde5b1147ccc06c48d143a1c3948225bc8b1b1932c4295fd54f2c23fd3 [INFO] running `Command { std: "docker" "start" "-a" "4328f4bde5b1147ccc06c48d143a1c3948225bc8b1b1932c4295fd54f2c23fd3", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking visitors v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `CollectMapVisitor` [INFO] [stdout] --> src/json/mod.rs:1:25 [INFO] [stdout] | [INFO] [stdout] 1 | pub use self::collect::{CollectMapVisitor, CollectValueVisitor}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `RedactMapVisitor` [INFO] [stdout] --> src/json/mod.rs:2:24 [INFO] [stdout] | [INFO] [stdout] 2 | pub use self::redact::{RedactMapVisitor, RedactValueVisitor}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `StringifyMapVisitor` [INFO] [stdout] --> src/json/mod.rs:3:27 [INFO] [stdout] | [INFO] [stdout] 3 | pub use self::stringify::{StringifyMapVisitor, StringifyValueVisitor}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/json/mod.rs:19:21 [INFO] [stdout] | [INFO] [stdout] 19 | fn on_str(self, &str) -> T; [INFO] [stdout] | ^^^^ help: try naming the parameter or explicitly ignoring it: `_: &str` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] = note: `#[warn(anonymous_parameters)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/json/mod.rs:20:21 [INFO] [stdout] | [INFO] [stdout] 20 | fn on_num(self, f64) -> T; [INFO] [stdout] | ^^^ help: try naming the parameter or explicitly ignoring it: `_: f64` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/json/mod.rs:21:21 [INFO] [stdout] | [INFO] [stdout] 21 | fn on_map(self, Option) -> Self::MapVisitor; [INFO] [stdout] | ^^^^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: Option` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/json/mod.rs:27:26 [INFO] [stdout] | [INFO] [stdout] 27 | fn on_key(&mut self, &str); [INFO] [stdout] | ^^^^ help: try naming the parameter or explicitly ignoring it: `_: &str` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/json/mod.rs:29:33 [INFO] [stdout] | [INFO] [stdout] 29 | fn collect_value(&mut self, T); [INFO] [stdout] | ^ help: try naming the parameter or explicitly ignoring it: `_: T` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `CollectMapVisitor` [INFO] [stdout] --> src/json/mod.rs:1:25 [INFO] [stdout] | [INFO] [stdout] 1 | pub use self::collect::{CollectMapVisitor, CollectValueVisitor}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `RedactMapVisitor` [INFO] [stdout] --> src/json/mod.rs:2:24 [INFO] [stdout] | [INFO] [stdout] 2 | pub use self::redact::{RedactMapVisitor, RedactValueVisitor}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `StringifyMapVisitor` [INFO] [stdout] --> src/json/mod.rs:3:27 [INFO] [stdout] | [INFO] [stdout] 3 | pub use self::stringify::{StringifyMapVisitor, StringifyValueVisitor}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/json/mod.rs:19:21 [INFO] [stdout] | [INFO] [stdout] 19 | fn on_str(self, &str) -> T; [INFO] [stdout] | ^^^^ help: try naming the parameter or explicitly ignoring it: `_: &str` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] = note: `#[warn(anonymous_parameters)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/json/mod.rs:20:21 [INFO] [stdout] | [INFO] [stdout] 20 | fn on_num(self, f64) -> T; [INFO] [stdout] | ^^^ help: try naming the parameter or explicitly ignoring it: `_: f64` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/json/mod.rs:21:21 [INFO] [stdout] | [INFO] [stdout] 21 | fn on_map(self, Option) -> Self::MapVisitor; [INFO] [stdout] | ^^^^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: Option` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/json/mod.rs:27:26 [INFO] [stdout] | [INFO] [stdout] 27 | fn on_key(&mut self, &str); [INFO] [stdout] | ^^^^ help: try naming the parameter or explicitly ignoring it: `_: &str` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/json/mod.rs:29:33 [INFO] [stdout] | [INFO] [stdout] 29 | fn collect_value(&mut self, T); [INFO] [stdout] | ^ help: try naming the parameter or explicitly ignoring it: `_: T` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json/redact.rs:28:31 [INFO] [stdout] | [INFO] [stdout] 27 | fn on_map(self, len: Option) -> Self::MapVisitor { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | RedactMapVisitor::new(self.downstream.on_map(len)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `visitors` (bin "visitors" test) due to 2 previous errors; 8 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json/redact.rs:28:31 [INFO] [stdout] | [INFO] [stdout] 27 | fn on_map(self, len: Option) -> Self::MapVisitor { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | RedactMapVisitor::new(self.downstream.on_map(len)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `visitors` (bin "visitors") due to 2 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "4328f4bde5b1147ccc06c48d143a1c3948225bc8b1b1932c4295fd54f2c23fd3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4328f4bde5b1147ccc06c48d143a1c3948225bc8b1b1932c4295fd54f2c23fd3", kill_on_drop: false }` [INFO] [stdout] 4328f4bde5b1147ccc06c48d143a1c3948225bc8b1b1932c4295fd54f2c23fd3