[INFO] cloning repository https://github.com/brecert/google-photos-linkfarm [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/brecert/google-photos-linkfarm" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbrecert%2Fgoogle-photos-linkfarm", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbrecert%2Fgoogle-photos-linkfarm'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 42bd6b2faa4276ef5aa69b5217cfece24eae2211 [INFO] checking brecert/google-photos-linkfarm/42bd6b2faa4276ef5aa69b5217cfece24eae2211 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbrecert%2Fgoogle-photos-linkfarm" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/brecert/google-photos-linkfarm on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-1-tc2/source/.cargo/config.toml [INFO] started tweaking git repo https://github.com/brecert/google-photos-linkfarm [INFO] finished tweaking git repo https://github.com/brecert/google-photos-linkfarm [INFO] tweaked toml for git repo https://github.com/brecert/google-photos-linkfarm written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/brecert/google-photos-linkfarm already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4475487b47dbbec386887868d5a3618d458fb5fc6a24eff0977dc1842e5a4770 [INFO] running `Command { std: "docker" "start" "-a" "4475487b47dbbec386887868d5a3618d458fb5fc6a24eff0977dc1842e5a4770", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4475487b47dbbec386887868d5a3618d458fb5fc6a24eff0977dc1842e5a4770", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4475487b47dbbec386887868d5a3618d458fb5fc6a24eff0977dc1842e5a4770", kill_on_drop: false }` [INFO] [stdout] 4475487b47dbbec386887868d5a3618d458fb5fc6a24eff0977dc1842e5a4770 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ae37f4d2a52ff008e1c29e96a20769a0e7a0bf2ecfb34479a297ddb6cd4ea95d [INFO] running `Command { std: "docker" "start" "-a" "ae37f4d2a52ff008e1c29e96a20769a0e7a0bf2ecfb34479a297ddb6cd4ea95d", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.43 [INFO] [stderr] Compiling quote v1.0.21 [INFO] [stderr] Compiling unicode-ident v1.0.4 [INFO] [stderr] Compiling syn v1.0.99 [INFO] [stderr] Compiling libc v0.2.132 [INFO] [stderr] Compiling serde_derive v1.0.144 [INFO] [stderr] Compiling serde v1.0.144 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Checking once_cell v1.14.0 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.11 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling crossbeam-epoch v0.9.10 [INFO] [stderr] Compiling num-bigint v0.4.3 [INFO] [stderr] Compiling camino v1.1.1 [INFO] [stderr] Compiling serde_json v1.0.85 [INFO] [stderr] Compiling strsim v0.10.0 [INFO] [stderr] Compiling semver v1.0.14 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Compiling indexmap v1.9.1 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Compiling num-iter v0.1.43 [INFO] [stderr] Compiling regex-syntax v0.6.27 [INFO] [stderr] Compiling ryu v1.0.11 [INFO] [stderr] Compiling rayon-core v1.9.3 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Compiling itoa v1.0.3 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Compiling lock_api v0.4.8 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Checking gimli v0.26.2 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking os_str_bytes v6.3.0 [INFO] [stderr] Compiling parking_lot_core v0.9.3 [INFO] [stderr] Compiling rayon v1.5.3 [INFO] [stderr] Checking miniz_oxide v0.5.4 [INFO] [stderr] Compiling anyhow v1.0.65 [INFO] [stderr] Checking crossbeam-channel v0.5.6 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking smallvec v1.9.0 [INFO] [stderr] Compiling aho-corasick v0.7.19 [INFO] [stderr] Checking crossbeam-deque v0.8.2 [INFO] [stderr] Checking object v0.29.0 [INFO] [stderr] Checking textwrap v0.15.1 [INFO] [stderr] Checking rustc-demangle v0.1.21 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking iana-time-zone v0.1.48 [INFO] [stderr] Checking either v1.8.0 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking filetime v0.2.17 [INFO] [stderr] Compiling backtrace v0.3.66 [INFO] [stderr] Checking dashmap v5.4.0 [INFO] [stderr] Checking num-complex v0.4.2 [INFO] [stderr] Checking chrono v0.4.22 [INFO] [stderr] Compiling regex v1.6.0 [INFO] [stderr] Checking addr2line v0.17.0 [INFO] [stderr] Compiling Inflector v0.11.4 [INFO] [stderr] Checking num v0.4.0 [INFO] [stderr] Checking rexif v0.7.3 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling darling_core v0.13.4 [INFO] [stderr] Compiling clap_derive v3.2.18 [INFO] [stderr] Compiling darling_macro v0.13.4 [INFO] [stderr] Compiling darling v0.13.4 [INFO] [stderr] Checking clap v3.2.22 [INFO] [stderr] Compiling cargo-platform v0.1.2 [INFO] [stderr] Compiling cargo_metadata v0.14.2 [INFO] [stderr] Compiling fncmd-impl v1.2.5 [INFO] [stderr] Checking fncmd v1.2.5 [INFO] [stderr] Checking google_takeout v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: the feature `absolute_path` has been stable since 1.79.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/main.rs:2:12 [INFO] [stdout] | [INFO] [stdout] 2 | #![feature(absolute_path)] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `backtrace` has been stable since 1.65.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/main.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | #![feature(backtrace)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `fs_try_exists` has been stable since 1.81.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/main.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(fs_try_exists)] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `absolute_path` has been stable since 1.79.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/main.rs:2:12 [INFO] [stdout] | [INFO] [stdout] 2 | #![feature(absolute_path)] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `backtrace` has been stable since 1.65.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/main.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | #![feature(backtrace)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `fs_try_exists` has been stable since 1.81.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/main.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(fs_try_exists)] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `remove` and `count` are never used [INFO] [stdout] --> src/counter.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 4 | pub trait Counter { [INFO] [stdout] | ------- methods in this trait [INFO] [stdout] 5 | fn add(&self, key: K) -> T; [INFO] [stdout] 6 | fn remove(&self, key: K) -> T; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 7 | fn count(&self, key: &K) -> T; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/counter.rs:12:10 [INFO] [stdout] | [INFO] [stdout] 11 | fn add(&self, key: T) -> u64 { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | *self.entry(key).and_modify(|count| *count += 1).or_default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/counter.rs:16:10 [INFO] [stdout] | [INFO] [stdout] 15 | fn remove(&self, key: T) -> u64 { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | *self [INFO] [stdout] | __________^ [INFO] [stdout] 17 | | .entry(key) [INFO] [stdout] 18 | | .and_modify(|count| *count = count.saturating_sub(1)) [INFO] [stdout] 19 | | .or_default() [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `google_takeout` (bin "google_takeout" test) due to 3 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: methods `remove` and `count` are never used [INFO] [stdout] --> src/counter.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 4 | pub trait Counter { [INFO] [stdout] | ------- methods in this trait [INFO] [stdout] 5 | fn add(&self, key: K) -> T; [INFO] [stdout] 6 | fn remove(&self, key: K) -> T; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 7 | fn count(&self, key: &K) -> T; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/counter.rs:12:10 [INFO] [stdout] | [INFO] [stdout] 11 | fn add(&self, key: T) -> u64 { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | *self.entry(key).and_modify(|count| *count += 1).or_default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/counter.rs:16:10 [INFO] [stdout] | [INFO] [stdout] 15 | fn remove(&self, key: T) -> u64 { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | *self [INFO] [stdout] | __________^ [INFO] [stdout] 17 | | .entry(key) [INFO] [stdout] 18 | | .and_modify(|count| *count = count.saturating_sub(1)) [INFO] [stdout] 19 | | .or_default() [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `google_takeout` (bin "google_takeout") due to 3 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "ae37f4d2a52ff008e1c29e96a20769a0e7a0bf2ecfb34479a297ddb6cd4ea95d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ae37f4d2a52ff008e1c29e96a20769a0e7a0bf2ecfb34479a297ddb6cd4ea95d", kill_on_drop: false }` [INFO] [stdout] ae37f4d2a52ff008e1c29e96a20769a0e7a0bf2ecfb34479a297ddb6cd4ea95d