[INFO] cloning repository https://github.com/brdv/rtodo [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/brdv/rtodo" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbrdv%2Frtodo", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbrdv%2Frtodo'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 88bc6d83afc10da0af635decb844e75b3d5ac96a [INFO] checking brdv/rtodo/88bc6d83afc10da0af635decb844e75b3d5ac96a against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbrdv%2Frtodo" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/brdv/rtodo on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/brdv/rtodo [INFO] finished tweaking git repo https://github.com/brdv/rtodo [INFO] tweaked toml for git repo https://github.com/brdv/rtodo written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/brdv/rtodo already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 621c5af9c4839cc9f1c2fbfe2b8370329974c3ecfd75236596812803e3bd6d5f [INFO] running `Command { std: "docker" "start" "-a" "621c5af9c4839cc9f1c2fbfe2b8370329974c3ecfd75236596812803e3bd6d5f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "621c5af9c4839cc9f1c2fbfe2b8370329974c3ecfd75236596812803e3bd6d5f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "621c5af9c4839cc9f1c2fbfe2b8370329974c3ecfd75236596812803e3bd6d5f", kill_on_drop: false }` [INFO] [stdout] 621c5af9c4839cc9f1c2fbfe2b8370329974c3ecfd75236596812803e3bd6d5f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 24ce9875c95ba108048d9bc9d26f643fdc1c04cf897faf481c57dcb9d78babf9 [INFO] running `Command { std: "docker" "start" "-a" "24ce9875c95ba108048d9bc9d26f643fdc1c04cf897faf481c57dcb9d78babf9", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.80 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.59 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking rtodo v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/do_todo.rs:8:21 [INFO] [stdout] | [INFO] [stdout] 8 | item.map(|todo| todo.mark_done().expect("whoops")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:141:5 [INFO] [stdout] | [INFO] [stdout] 138 | let paths = fs::read_dir(location) [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 141 | / paths [INFO] [stdout] 142 | | .filter_map(|entry| { [INFO] [stdout] 143 | | if let Ok(path) = entry { [INFO] [stdout] 144 | | return Some(path); [INFO] [stdout] 145 | | } [INFO] [stdout] 146 | | None [INFO] [stdout] 147 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rtodo` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/do_todo.rs:8:21 [INFO] [stdout] | [INFO] [stdout] 8 | item.map(|todo| todo.mark_done().expect("whoops")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:141:5 [INFO] [stdout] | [INFO] [stdout] 138 | let paths = fs::read_dir(location) [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 141 | / paths [INFO] [stdout] 142 | | .filter_map(|entry| { [INFO] [stdout] 143 | | if let Ok(path) = entry { [INFO] [stdout] 144 | | return Some(path); [INFO] [stdout] 145 | | } [INFO] [stdout] 146 | | None [INFO] [stdout] 147 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rtodo` (lib test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "24ce9875c95ba108048d9bc9d26f643fdc1c04cf897faf481c57dcb9d78babf9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "24ce9875c95ba108048d9bc9d26f643fdc1c04cf897faf481c57dcb9d78babf9", kill_on_drop: false }` [INFO] [stdout] 24ce9875c95ba108048d9bc9d26f643fdc1c04cf897faf481c57dcb9d78babf9