[INFO] cloning repository https://github.com/brdgme/lost-cities [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/brdgme/lost-cities" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbrdgme%2Flost-cities", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbrdgme%2Flost-cities'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 25ce20c5cef5f6c0849da3e8514e18f086f5d605 [INFO] checking brdgme/lost-cities/25ce20c5cef5f6c0849da3e8514e18f086f5d605 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbrdgme%2Flost-cities" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/brdgme/lost-cities on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/brdgme/lost-cities [INFO] finished tweaking git repo https://github.com/brdgme/lost-cities [INFO] tweaked toml for git repo https://github.com/brdgme/lost-cities written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/brdgme/lost-cities already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c1ea5b17f04eec21f782a3c1a060d42675bf706cc8e6c6fd3dd20eb15cd0d58c [INFO] running `Command { std: "docker" "start" "-a" "c1ea5b17f04eec21f782a3c1a060d42675bf706cc8e6c6fd3dd20eb15cd0d58c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c1ea5b17f04eec21f782a3c1a060d42675bf706cc8e6c6fd3dd20eb15cd0d58c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c1ea5b17f04eec21f782a3c1a060d42675bf706cc8e6c6fd3dd20eb15cd0d58c", kill_on_drop: false }` [INFO] [stdout] c1ea5b17f04eec21f782a3c1a060d42675bf706cc8e6c6fd3dd20eb15cd0d58c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5e5920f3eb8bec894516a671b4e69bbd406c5a25d3887a44c74076f865545ac5 [INFO] running `Command { std: "docker" "start" "-a" "5e5920f3eb8bec894516a671b4e69bbd406c5a25d3887a44c74076f865545ac5", kill_on_drop: false }` [INFO] [stderr] Checking libc v0.2.40 [INFO] [stderr] Compiling unicode-xid v0.0.4 [INFO] [stderr] Compiling cc v1.0.15 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling quote v0.3.15 [INFO] [stderr] Checking cfg-if v0.1.3 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking serde v1.0.55 [INFO] [stderr] Checking ucd-util v0.1.1 [INFO] [stderr] Compiling regex v0.2.11 [INFO] [stderr] Checking rustc-demangle v0.1.8 [INFO] [stderr] Checking lazy_static v1.0.0 [INFO] [stderr] Compiling num-traits v0.2.4 [INFO] [stderr] Compiling num-integer v0.1.38 [INFO] [stderr] Compiling version_check v0.1.3 [INFO] [stderr] Checking utf8-ranges v1.0.0 [INFO] [stderr] Compiling proc-macro2 v0.3.8 [INFO] [stderr] Checking lazy_static v0.2.11 [INFO] [stderr] Checking regex-syntax v0.5.6 [INFO] [stderr] Checking byteorder v1.2.3 [INFO] [stderr] Checking unreachable v1.0.0 [INFO] [stderr] Checking thread_local v0.3.5 [INFO] [stderr] Compiling synom v0.11.3 [INFO] [stderr] Checking ascii v0.7.1 [INFO] [stderr] Checking log v0.4.1 [INFO] [stderr] Checking itoa v0.4.1 [INFO] [stderr] Compiling syn v0.11.11 [INFO] [stderr] Checking dtoa v0.4.2 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Compiling unicase v1.4.2 [INFO] [stderr] Checking combine v2.5.2 [INFO] [stderr] Checking memchr v2.0.1 [INFO] [stderr] Checking time v0.1.40 [INFO] [stderr] Checking rand v0.4.2 [INFO] [stderr] Checking term_size v0.2.3 [INFO] [stderr] Compiling quote v0.5.2 [INFO] [stderr] Checking aho-corasick v0.6.4 [INFO] [stderr] Compiling syn v0.13.10 [INFO] [stderr] Compiling backtrace-sys v0.1.16 [INFO] [stderr] Compiling synstructure v0.6.1 [INFO] [stderr] Checking rand v0.3.22 [INFO] [stderr] Compiling failure_derive v0.1.1 [INFO] [stderr] Compiling serde_derive v1.0.55 [INFO] [stderr] Checking chrono v0.4.2 [INFO] [stderr] Checking serde_json v1.0.17 [INFO] [stderr] Checking backtrace v0.3.7 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Checking brdgme-color v0.1.0 (https://github.com/brdgme/color.git#34fde167) [INFO] [stderr] Checking brdgme-markup v0.1.0 (https://github.com/brdgme/markup.git#aac7e8e8) [INFO] [stderr] Checking brdgme-game v0.1.0 (https://github.com/brdgme/game.git#4da0185a) [INFO] [stderr] Checking brdgme-cmd v0.1.0 (https://github.com/brdgme/cmd.git#b91ef50d) [INFO] [stderr] Checking brdgme-rand-bot v0.1.0 (https://github.com/brdgme/rand-bot.git#6de2d0ad) [INFO] [stderr] Checking lost-cities v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/command.rs:17:63 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn command_parser(&self, player: usize) -> Option>> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 17 | pub fn command_parser(&self, player: usize) -> Option>> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/command.rs:21:34 [INFO] [stdout] | [INFO] [stdout] 21 | let mut parsers: Vec>> = vec![]; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 21 | let mut parsers: Vec>> = vec![]; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/command.rs:17:63 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn command_parser(&self, player: usize) -> Option>> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 17 | pub fn command_parser(&self, player: usize) -> Option>> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/command.rs:21:34 [INFO] [stdout] | [INFO] [stdout] 21 | let mut parsers: Vec>> = vec![]; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 21 | let mut parsers: Vec>> = vec![]; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:35:52 [INFO] [stdout] | [INFO] [stdout] 35 | #[derive(PartialEq, Copy, Clone, Debug, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/card.rs:8:73 [INFO] [stdout] | [INFO] [stdout] 8 | #[derive(Copy, Clone, PartialEq, Eq, Debug, PartialOrd, Ord, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/card.rs:14:79 [INFO] [stdout] | [INFO] [stdout] 14 | #[derive(Copy, Clone, PartialEq, Eq, Debug, PartialOrd, Ord, Hash, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lost-cities` (lib) due to 4 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:35:52 [INFO] [stdout] | [INFO] [stdout] 35 | #[derive(PartialEq, Copy, Clone, Debug, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/card.rs:8:73 [INFO] [stdout] | [INFO] [stdout] 8 | #[derive(Copy, Clone, PartialEq, Eq, Debug, PartialOrd, Ord, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/card.rs:14:79 [INFO] [stdout] | [INFO] [stdout] 14 | #[derive(Copy, Clone, PartialEq, Eq, Debug, PartialOrd, Ord, Hash, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lost-cities` (lib test) due to 4 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "5e5920f3eb8bec894516a671b4e69bbd406c5a25d3887a44c74076f865545ac5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5e5920f3eb8bec894516a671b4e69bbd406c5a25d3887a44c74076f865545ac5", kill_on_drop: false }` [INFO] [stdout] 5e5920f3eb8bec894516a671b4e69bbd406c5a25d3887a44c74076f865545ac5