[INFO] cloning repository https://github.com/brapse/light-spike [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/brapse/light-spike" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbrapse%2Flight-spike", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbrapse%2Flight-spike'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d50858eaf167f022895018b65cbfef3e88b792f1 [INFO] checking brapse/light-spike/d50858eaf167f022895018b65cbfef3e88b792f1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbrapse%2Flight-spike" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/brapse/light-spike on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/brapse/light-spike [INFO] finished tweaking git repo https://github.com/brapse/light-spike [INFO] tweaked toml for git repo https://github.com/brapse/light-spike written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/brapse/light-spike already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ee98e9806ecf4d56ea53e45bb8454e3ed319f2a4d9ee823ddaeaaefbad422015 [INFO] running `Command { std: "docker" "start" "-a" "ee98e9806ecf4d56ea53e45bb8454e3ed319f2a4d9ee823ddaeaaefbad422015", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ee98e9806ecf4d56ea53e45bb8454e3ed319f2a4d9ee823ddaeaaefbad422015", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ee98e9806ecf4d56ea53e45bb8454e3ed319f2a4d9ee823ddaeaaefbad422015", kill_on_drop: false }` [INFO] [stdout] ee98e9806ecf4d56ea53e45bb8454e3ed319f2a4d9ee823ddaeaaefbad422015 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 990b6b6700999ca4be51d5cc5ddb7510a5a204cf85bf8c4ce62dcc37125e1afc [INFO] running `Command { std: "docker" "start" "-a" "990b6b6700999ca4be51d5cc5ddb7510a5a204cf85bf8c4ce62dcc37125e1afc", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling memoffset v0.5.4 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Checking crossbeam-channel v0.4.2 [INFO] [stderr] Checking crossbeam-queue v0.2.1 [INFO] [stderr] Checking crossbeam-deque v0.7.3 [INFO] [stderr] Checking crossbeam v0.7.3 [INFO] [stderr] Checking light-spike v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `time` [INFO] [stdout] --> src/light_client.rs:1:18 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{thread,time}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `time` [INFO] [stdout] --> src/light_client.rs:1:18 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{thread,time}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `peer_id` [INFO] [stdout] --> src/light_client.rs:43:36 [INFO] [stdout] | [INFO] [stdout] 43 | fn remove_secondary(&mut self, peer_id: PeerID) { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_peer_id` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `err` [INFO] [stdout] --> src/light_client.rs:205:21 [INFO] [stdout] | [INFO] [stdout] 205 | Err(err) => { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_err` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `peers` and `primary` are never read [INFO] [stdout] --> src/light_client.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 33 | struct PeerList { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] 34 | peers: HashMap, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 35 | primary: PeerID, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `PassedVerification` and `FailedVerification` are never constructed [INFO] [stdout] --> src/light_client.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 56 | enum Fork { [INFO] [stdout] | ---- variants in this enum [INFO] [stdout] 57 | PassedVerification(PeerID), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 58 | FailedVerification(PeerID), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `peer_id` is never read [INFO] [stdout] --> src/light_client.rs:62:5 [INFO] [stdout] | [INFO] [stdout] 61 | struct Instance { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] 62 | peer_id: PeerID, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Event` is never used [INFO] [stdout] --> src/relayer.rs:4:6 [INFO] [stdout] | [INFO] [stdout] 4 | enum Event { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `handle` and `run` are never used [INFO] [stdout] --> src/relayer.rs:22:8 [INFO] [stdout] | [INFO] [stdout] 16 | impl Relayer { [INFO] [stdout] | ------------ methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 22 | fn handle(&mut self, event: Event) -> Event { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 39 | fn run(mut self, [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/light_client.rs:214:15 [INFO] [stdout] | [INFO] [stdout] 198 | let (sender, receiver) = channel::bounded::(1); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 199 | let callback = Callback::new(move |result| { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 214 | match receiver.recv().unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `light-spike` (lib test) due to 2 previous errors; 8 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `peer_id` [INFO] [stdout] --> src/light_client.rs:43:36 [INFO] [stdout] | [INFO] [stdout] 43 | fn remove_secondary(&mut self, peer_id: PeerID) { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_peer_id` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `err` [INFO] [stdout] --> src/light_client.rs:205:21 [INFO] [stdout] | [INFO] [stdout] 205 | Err(err) => { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_err` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `peers` and `primary` are never read [INFO] [stdout] --> src/light_client.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 33 | struct PeerList { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] 34 | peers: HashMap, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 35 | primary: PeerID, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `PassedVerification` and `FailedVerification` are never constructed [INFO] [stdout] --> src/light_client.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 56 | enum Fork { [INFO] [stdout] | ---- variants in this enum [INFO] [stdout] 57 | PassedVerification(PeerID), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 58 | FailedVerification(PeerID), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `peer_id` is never read [INFO] [stdout] --> src/light_client.rs:62:5 [INFO] [stdout] | [INFO] [stdout] 61 | struct Instance { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] 62 | peer_id: PeerID, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Event` is never used [INFO] [stdout] --> src/relayer.rs:4:6 [INFO] [stdout] | [INFO] [stdout] 4 | enum Event { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `handle` and `run` are never used [INFO] [stdout] --> src/relayer.rs:22:8 [INFO] [stdout] | [INFO] [stdout] 16 | impl Relayer { [INFO] [stdout] | ------------ methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 22 | fn handle(&mut self, event: Event) -> Event { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 39 | fn run(mut self, [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/light_client.rs:214:15 [INFO] [stdout] | [INFO] [stdout] 198 | let (sender, receiver) = channel::bounded::(1); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 199 | let callback = Callback::new(move |result| { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 214 | match receiver.recv().unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `light-spike` (lib) due to 2 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "990b6b6700999ca4be51d5cc5ddb7510a5a204cf85bf8c4ce62dcc37125e1afc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "990b6b6700999ca4be51d5cc5ddb7510a5a204cf85bf8c4ce62dcc37125e1afc", kill_on_drop: false }` [INFO] [stdout] 990b6b6700999ca4be51d5cc5ddb7510a5a204cf85bf8c4ce62dcc37125e1afc