[INFO] cloning repository https://github.com/brandoncc/git-tools.rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/brandoncc/git-tools.rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbrandoncc%2Fgit-tools.rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbrandoncc%2Fgit-tools.rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] dc5b52d062bc0c1149926709dc231d2a03f8339d [INFO] checking brandoncc/git-tools.rs/dc5b52d062bc0c1149926709dc231d2a03f8339d against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbrandoncc%2Fgit-tools.rs" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/brandoncc/git-tools.rs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/brandoncc/git-tools.rs [INFO] finished tweaking git repo https://github.com/brandoncc/git-tools.rs [INFO] tweaked toml for git repo https://github.com/brandoncc/git-tools.rs written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/brandoncc/git-tools.rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f376e0ce56d560fca71760d5517063e40ea5c39fe61a21e0b6f584fe115a4d87 [INFO] running `Command { std: "docker" "start" "-a" "f376e0ce56d560fca71760d5517063e40ea5c39fe61a21e0b6f584fe115a4d87", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f376e0ce56d560fca71760d5517063e40ea5c39fe61a21e0b6f584fe115a4d87", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f376e0ce56d560fca71760d5517063e40ea5c39fe61a21e0b6f584fe115a4d87", kill_on_drop: false }` [INFO] [stdout] f376e0ce56d560fca71760d5517063e40ea5c39fe61a21e0b6f584fe115a4d87 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 23422637edf14a00f297bca666c83cafe0959ae02e9bf4e1be4f47dcf4d1294b [INFO] running `Command { std: "docker" "start" "-a" "23422637edf14a00f297bca666c83cafe0959ae02e9bf4e1be4f47dcf4d1294b", kill_on_drop: false }` [INFO] [stderr] Checking git-tools v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `exit_code` is never read [INFO] [stdout] --> src/commands.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct SuccessfulCommandExecution { [INFO] [stdout] | -------------------------- field in this struct [INFO] [stdout] 14 | pub exit_code: i32, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SuccessfulCommandExecution` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `exit_code` is never read [INFO] [stdout] --> src/commands.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 19 | pub struct FailedCommandExecution { [INFO] [stdout] | ---------------------- field in this struct [INFO] [stdout] 20 | pub exit_code: i32, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `FailedCommandExecution` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `as_any`, `is_bare`, and `main_branch_name` are never used [INFO] [stdout] --> src/repository.rs:32:8 [INFO] [stdout] | [INFO] [stdout] 31 | pub trait RepositoryInterface { [INFO] [stdout] | ------------------- methods in this trait [INFO] [stdout] 32 | fn as_any(&self) -> &dyn Any; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 33 | fn clean_merged(&self) -> Result<(), String>; [INFO] [stdout] 34 | fn is_bare(&self) -> bool; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 35 | fn root(&self) -> &PathBuf; [INFO] [stdout] 36 | fn main_branch_name(&self) -> &String; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `exit_code` is never read [INFO] [stdout] --> src/commands.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct SuccessfulCommandExecution { [INFO] [stdout] | -------------------------- field in this struct [INFO] [stdout] 14 | pub exit_code: i32, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SuccessfulCommandExecution` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `exit_code` is never read [INFO] [stdout] --> src/commands.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 19 | pub struct FailedCommandExecution { [INFO] [stdout] | ---------------------- field in this struct [INFO] [stdout] 20 | pub exit_code: i32, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `FailedCommandExecution` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repository/tests.rs:33:22 [INFO] [stdout] | [INFO] [stdout] 33 | |repo| match Repository::at(repo.root()) { [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repository/tests.rs:45:22 [INFO] [stdout] | [INFO] [stdout] 45 | |repo| match Repository::at(&repo.root().join("merged")) { [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repository/tests.rs:57:22 [INFO] [stdout] | [INFO] [stdout] 57 | |repo| match Repository::at(repo.root()) { [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `git-tools` (bin "git-tools" test) due to 4 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "23422637edf14a00f297bca666c83cafe0959ae02e9bf4e1be4f47dcf4d1294b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "23422637edf14a00f297bca666c83cafe0959ae02e9bf4e1be4f47dcf4d1294b", kill_on_drop: false }` [INFO] [stdout] 23422637edf14a00f297bca666c83cafe0959ae02e9bf4e1be4f47dcf4d1294b