[INFO] cloning repository https://github.com/brandon515/rusty_irc [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/brandon515/rusty_irc" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbrandon515%2Frusty_irc", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbrandon515%2Frusty_irc'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 882eb357a4bdcac2e66fda73200e3705898b5152 [INFO] checking brandon515/rusty_irc/882eb357a4bdcac2e66fda73200e3705898b5152 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbrandon515%2Frusty_irc" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/brandon515/rusty_irc on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/brandon515/rusty_irc [INFO] finished tweaking git repo https://github.com/brandon515/rusty_irc [INFO] tweaked toml for git repo https://github.com/brandon515/rusty_irc written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/brandon515/rusty_irc already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 63b09f7fa3ac3d9a2fb41d0f236f1acb42f680a64878115b991ad8c8a1f101dc [INFO] running `Command { std: "docker" "start" "-a" "63b09f7fa3ac3d9a2fb41d0f236f1acb42f680a64878115b991ad8c8a1f101dc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "63b09f7fa3ac3d9a2fb41d0f236f1acb42f680a64878115b991ad8c8a1f101dc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "63b09f7fa3ac3d9a2fb41d0f236f1acb42f680a64878115b991ad8c8a1f101dc", kill_on_drop: false }` [INFO] [stdout] 63b09f7fa3ac3d9a2fb41d0f236f1acb42f680a64878115b991ad8c8a1f101dc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 11264a3a7cc7b9c324c13f79e5b9ec31e38d59d85c19c97c0a77ea1d0b8657dd [INFO] running `Command { std: "docker" "start" "-a" "11264a3a7cc7b9c324c13f79e5b9ec31e38d59d85c19c97c0a77ea1d0b8657dd", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling winapi-build v0.1.1 [INFO] [stderr] Checking winapi v0.2.8 [INFO] [stderr] Checking libc v0.2.14 [INFO] [stderr] Checking cfg-if v0.1.0 [INFO] [stderr] Checking log v0.3.6 [INFO] [stderr] Checking bitflags v0.4.0 [INFO] [stderr] Checking slab v0.1.3 [INFO] [stderr] Checking bytes v0.3.0 [INFO] [stderr] Compiling kernel32-sys v0.2.2 [INFO] [stderr] Compiling ws2_32-sys v0.2.1 [INFO] [stderr] Checking rust-ini v0.9.8 [INFO] [stderr] Checking net2 v0.2.26 [INFO] [stderr] Checking time v0.1.35 [INFO] [stderr] Checking nix v0.5.1 [INFO] [stderr] Checking miow v0.1.3 [INFO] [stderr] Checking mio v0.5.1 [INFO] [stderr] Checking rusty_irc v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::thread` [INFO] [stdout] --> src/network_interface/handler.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | use std::thread; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::thread` [INFO] [stdout] --> src/network_interface/handler.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | use std::thread; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/network_interface/handler.rs:64:13 [INFO] [stdout] | [INFO] [stdout] 64 | let mut cli = match self.client_list.get_mut(&reciever){ [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `user` [INFO] [stdout] --> src/network_interface/handler.rs:117:29 [INFO] [stdout] | [INFO] [stdout] 117 | let user = x.remove(place); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_user` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `chan_name` [INFO] [stdout] --> src/network_interface/handler.rs:150:31 [INFO] [stdout] | [INFO] [stdout] 150 | 'search: for (chan_name, user_list) in self.channels.iter_mut(){ [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_chan_name` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `msg_stream` [INFO] [stdout] --> src/network_interface/handler.rs:176:21 [INFO] [stdout] | [INFO] [stdout] 176 | let msg_stream = event_loop.channel(); [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_msg_stream` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `in_str` [INFO] [stdout] --> src/network_interface/handler.rs:340:21 [INFO] [stdout] | [INFO] [stdout] 340 | let in_str = match String::from_utf8(input_bytes){ [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_in_str` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `message` [INFO] [stdout] --> src/irc/command.rs:8:15 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn handle(message: Message, sender: User, chan: Sender){ [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_message` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `sender` [INFO] [stdout] --> src/irc/command.rs:8:33 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn handle(message: Message, sender: User, chan: Sender){ [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_sender` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `chan` [INFO] [stdout] --> src/irc/command.rs:8:47 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn handle(message: Message, sender: User, chan: Sender){ [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_chan` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network_interface/handler.rs:47:26 [INFO] [stdout] | [INFO] [stdout] 45 | let server_listener = TcpListener::bind(&addr).unwrap(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | ServerHandler{ [INFO] [stdout] 47 | client_list: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/network_interface/handler.rs:201:17 [INFO] [stdout] | [INFO] [stdout] 201 | msg_stream.send(irc::message::ServerMessage::USERTOKENMSG(user_token.as_usize(), what.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 201 | let _ = msg_stream.send(irc::message::ServerMessage::USERTOKENMSG(user_token.as_usize(), what.clone())); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/irc/message.rs:119:37 [INFO] [stdout] | [INFO] [stdout] 119 | acc_string.push_str((&s).clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/network_interface/handler.rs:64:13 [INFO] [stdout] | [INFO] [stdout] 64 | let mut cli = match self.client_list.get_mut(&reciever){ [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `user` [INFO] [stdout] --> src/network_interface/handler.rs:117:29 [INFO] [stdout] | [INFO] [stdout] 117 | let user = x.remove(place); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_user` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `chan_name` [INFO] [stdout] --> src/network_interface/handler.rs:150:31 [INFO] [stdout] | [INFO] [stdout] 150 | 'search: for (chan_name, user_list) in self.channels.iter_mut(){ [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_chan_name` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `msg_stream` [INFO] [stdout] --> src/network_interface/handler.rs:176:21 [INFO] [stdout] | [INFO] [stdout] 176 | let msg_stream = event_loop.channel(); [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_msg_stream` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rusty_irc` (lib) due to 2 previous errors; 11 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `in_str` [INFO] [stdout] --> src/network_interface/handler.rs:340:21 [INFO] [stdout] | [INFO] [stdout] 340 | let in_str = match String::from_utf8(input_bytes){ [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_in_str` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `message` [INFO] [stdout] --> src/irc/command.rs:8:15 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn handle(message: Message, sender: User, chan: Sender){ [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_message` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `sender` [INFO] [stdout] --> src/irc/command.rs:8:33 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn handle(message: Message, sender: User, chan: Sender){ [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_sender` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `chan` [INFO] [stdout] --> src/irc/command.rs:8:47 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn handle(message: Message, sender: User, chan: Sender){ [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_chan` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network_interface/handler.rs:47:26 [INFO] [stdout] | [INFO] [stdout] 45 | let server_listener = TcpListener::bind(&addr).unwrap(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | ServerHandler{ [INFO] [stdout] 47 | client_list: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/network_interface/handler.rs:201:17 [INFO] [stdout] | [INFO] [stdout] 201 | msg_stream.send(irc::message::ServerMessage::USERTOKENMSG(user_token.as_usize(), what.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 201 | let _ = msg_stream.send(irc::message::ServerMessage::USERTOKENMSG(user_token.as_usize(), what.clone())); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/irc/message.rs:119:37 [INFO] [stdout] | [INFO] [stdout] 119 | acc_string.push_str((&s).clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rusty_irc` (lib test) due to 2 previous errors; 11 warnings emitted [INFO] running `Command { std: "docker" "inspect" "11264a3a7cc7b9c324c13f79e5b9ec31e38d59d85c19c97c0a77ea1d0b8657dd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "11264a3a7cc7b9c324c13f79e5b9ec31e38d59d85c19c97c0a77ea1d0b8657dd", kill_on_drop: false }` [INFO] [stdout] 11264a3a7cc7b9c324c13f79e5b9ec31e38d59d85c19c97c0a77ea1d0b8657dd