[INFO] cloning repository https://github.com/boweihan/rustfish [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/boweihan/rustfish" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fboweihan%2Frustfish", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fboweihan%2Frustfish'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] eb6d06bd823a535f2bae2cde617dddf77d3c762d [INFO] checking boweihan/rustfish/eb6d06bd823a535f2bae2cde617dddf77d3c762d against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fboweihan%2Frustfish" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/boweihan/rustfish on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/boweihan/rustfish [INFO] finished tweaking git repo https://github.com/boweihan/rustfish [INFO] tweaked toml for git repo https://github.com/boweihan/rustfish written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/boweihan/rustfish already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ca5d67649cd935be1c8b5a833c2f12ee046fa84fdcbcb08fca7992bae5a0e11e [INFO] running `Command { std: "docker" "start" "-a" "ca5d67649cd935be1c8b5a833c2f12ee046fa84fdcbcb08fca7992bae5a0e11e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ca5d67649cd935be1c8b5a833c2f12ee046fa84fdcbcb08fca7992bae5a0e11e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ca5d67649cd935be1c8b5a833c2f12ee046fa84fdcbcb08fca7992bae5a0e11e", kill_on_drop: false }` [INFO] [stdout] ca5d67649cd935be1c8b5a833c2f12ee046fa84fdcbcb08fca7992bae5a0e11e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0692658e7e74dfe1415408b3081be41c70921a497fb92677c6ca3541ede17769 [INFO] running `Command { std: "docker" "start" "-a" "0692658e7e74dfe1415408b3081be41c70921a497fb92677c6ca3541ede17769", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] [stderr] Checking rustfish-bot v0.1.0 (/opt/rustwide/workdir/rustfish-bot) [INFO] [stderr] Checking rustfish v0.1.0 (/opt/rustwide/workdir/rustfish) [INFO] [stdout] warning: unused variable: `f` [INFO] [stdout] --> rustfish-bot/src/position.rs:40:19 [INFO] [stdout] | [INFO] [stdout] 40 | fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_f` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `is_empty` and `any` are never used [INFO] [stdout] --> rustfish-bot/src/bitboard.rs:7:12 [INFO] [stdout] | [INFO] [stdout] 6 | impl BitBoard { [INFO] [stdout] | ------------- methods in this implementation [INFO] [stdout] 7 | pub fn is_empty(&self) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 10 | pub fn any(self) -> bool { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated constants `BEST_MOVE`, `COPY_PROTECTION`, `REGISTRATION`, `INFO`, and `OPTION` are never used [INFO] [stdout] --> rustfish-bot/src/constants.rs:22:15 [INFO] [stdout] | [INFO] [stdout] 18 | impl EngineOutput { [INFO] [stdout] | ----------------- associated constants in this implementation [INFO] [stdout] ... [INFO] [stdout] 22 | pub const BEST_MOVE: &str = "bestmove"; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 23 | pub const COPY_PROTECTION: &str = "copyprotection"; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 24 | pub const REGISTRATION: &str = "registration"; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 25 | pub const INFO: &str = "info"; [INFO] [stdout] | ^^^^ [INFO] [stdout] 26 | pub const OPTION: &str = "option"; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated constant `BLACK` is never used [INFO] [stdout] --> rustfish-bot/src/constants.rs:32:15 [INFO] [stdout] | [INFO] [stdout] 30 | impl Sides { [INFO] [stdout] | ---------- associated constant in this implementation [INFO] [stdout] 31 | pub const WHITE: usize = 0; [INFO] [stdout] 32 | pub const BLACK: usize = 1; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Pieces` is never constructed [INFO] [stdout] --> rustfish-bot/src/constants.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 35 | pub struct Pieces; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `f` [INFO] [stdout] --> rustfish-bot/src/position.rs:40:19 [INFO] [stdout] | [INFO] [stdout] 40 | fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_f` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated constants `PAWN`, `BISHOP`, `KNIGHT`, `ROOK`, `QUEEN`, and `KING` are never used [INFO] [stdout] --> rustfish-bot/src/constants.rs:37:15 [INFO] [stdout] | [INFO] [stdout] 36 | impl Pieces { [INFO] [stdout] | ----------- associated constants in this implementation [INFO] [stdout] 37 | pub const PAWN: usize = 0; [INFO] [stdout] | ^^^^ [INFO] [stdout] 38 | pub const BISHOP: usize = 1; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 39 | pub const KNIGHT: usize = 2; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 40 | pub const ROOK: usize = 3; [INFO] [stdout] | ^^^^ [INFO] [stdout] 41 | pub const QUEEN: usize = 4; [INFO] [stdout] | ^^^^^ [INFO] [stdout] 42 | pub const KING: usize = 5; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated constants `KING_SIDE` and `QUEEN_SIDE` are never used [INFO] [stdout] --> rustfish-bot/src/constants.rs:53:15 [INFO] [stdout] | [INFO] [stdout] 46 | impl Castling { [INFO] [stdout] | ------------- associated constants in this implementation [INFO] [stdout] ... [INFO] [stdout] 53 | pub const KING_SIDE: u8 = Self::BLACK_00 | Self::WHITE_00; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 54 | pub const QUEEN_SIDE: u8 = Self::BLACK_000 | Self::WHITE_000; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `SquareLabels` is never used [INFO] [stdout] --> rustfish-bot/src/enums.rs:48:10 [INFO] [stdout] | [INFO] [stdout] 48 | pub enum SquareLabels { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> rustfish-bot/src/controller.rs:18:31 [INFO] [stdout] | [INFO] [stdout] 14 | let (tx, rx) = mpsc::channel::(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 18 | thread::spawn(move || UCIEngine::new(rx).start()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> rustfish-bot/src/engine.rs:15:23 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn new(rx: mpsc::Receiver) -> UCIEngine { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 15 | position: Position::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `is_empty` and `any` are never used [INFO] [stdout] --> rustfish-bot/src/bitboard.rs:7:12 [INFO] [stdout] | [INFO] [stdout] 6 | impl BitBoard { [INFO] [stdout] | ------------- methods in this implementation [INFO] [stdout] 7 | pub fn is_empty(&self) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 10 | pub fn any(self) -> bool { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated constants `BEST_MOVE`, `COPY_PROTECTION`, `REGISTRATION`, `INFO`, and `OPTION` are never used [INFO] [stdout] --> rustfish-bot/src/constants.rs:22:15 [INFO] [stdout] | [INFO] [stdout] 18 | impl EngineOutput { [INFO] [stdout] | ----------------- associated constants in this implementation [INFO] [stdout] ... [INFO] [stdout] 22 | pub const BEST_MOVE: &str = "bestmove"; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 23 | pub const COPY_PROTECTION: &str = "copyprotection"; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 24 | pub const REGISTRATION: &str = "registration"; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 25 | pub const INFO: &str = "info"; [INFO] [stdout] | ^^^^ [INFO] [stdout] 26 | pub const OPTION: &str = "option"; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated constant `BLACK` is never used [INFO] [stdout] --> rustfish-bot/src/constants.rs:32:15 [INFO] [stdout] | [INFO] [stdout] 30 | impl Sides { [INFO] [stdout] | ---------- associated constant in this implementation [INFO] [stdout] 31 | pub const WHITE: usize = 0; [INFO] [stdout] 32 | pub const BLACK: usize = 1; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Pieces` is never constructed [INFO] [stdout] --> rustfish-bot/src/constants.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 35 | pub struct Pieces; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated constants `PAWN`, `BISHOP`, `KNIGHT`, `ROOK`, `QUEEN`, and `KING` are never used [INFO] [stdout] --> rustfish-bot/src/constants.rs:37:15 [INFO] [stdout] | [INFO] [stdout] 36 | impl Pieces { [INFO] [stdout] | ----------- associated constants in this implementation [INFO] [stdout] 37 | pub const PAWN: usize = 0; [INFO] [stdout] | ^^^^ [INFO] [stdout] 38 | pub const BISHOP: usize = 1; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 39 | pub const KNIGHT: usize = 2; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 40 | pub const ROOK: usize = 3; [INFO] [stdout] | ^^^^ [INFO] [stdout] 41 | pub const QUEEN: usize = 4; [INFO] [stdout] | ^^^^^ [INFO] [stdout] 42 | pub const KING: usize = 5; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated constants `KING_SIDE` and `QUEEN_SIDE` are never used [INFO] [stdout] --> rustfish-bot/src/constants.rs:53:15 [INFO] [stdout] | [INFO] [stdout] 46 | impl Castling { [INFO] [stdout] | ------------- associated constants in this implementation [INFO] [stdout] ... [INFO] [stdout] 53 | pub const KING_SIDE: u8 = Self::BLACK_00 | Self::WHITE_00; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 54 | pub const QUEEN_SIDE: u8 = Self::BLACK_000 | Self::WHITE_000; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `SquareLabels` is never used [INFO] [stdout] --> rustfish-bot/src/enums.rs:48:10 [INFO] [stdout] | [INFO] [stdout] 48 | pub enum SquareLabels { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> rustfish-bot/src/controller.rs:18:31 [INFO] [stdout] | [INFO] [stdout] 14 | let (tx, rx) = mpsc::channel::(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 18 | thread::spawn(move || UCIEngine::new(rx).start()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> rustfish-bot/src/engine.rs:15:23 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn new(rx: mpsc::Receiver) -> UCIEngine { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 15 | position: Position::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rustfish-bot` (bin "rustfish-bot" test) due to 3 previous errors; 8 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `rustfish-bot` (bin "rustfish-bot") due to 3 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "0692658e7e74dfe1415408b3081be41c70921a497fb92677c6ca3541ede17769", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0692658e7e74dfe1415408b3081be41c70921a497fb92677c6ca3541ede17769", kill_on_drop: false }` [INFO] [stdout] 0692658e7e74dfe1415408b3081be41c70921a497fb92677c6ca3541ede17769