[INFO] cloning repository https://github.com/borbrudar/rtracer [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/borbrudar/rtracer" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fborbrudar%2Frtracer", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fborbrudar%2Frtracer'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d68718d9eb95d6c235491959ff5ac9c4186c42c7 [INFO] checking borbrudar/rtracer/d68718d9eb95d6c235491959ff5ac9c4186c42c7 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fborbrudar%2Frtracer" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/borbrudar/rtracer on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/borbrudar/rtracer [INFO] finished tweaking git repo https://github.com/borbrudar/rtracer [INFO] tweaked toml for git repo https://github.com/borbrudar/rtracer written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/borbrudar/rtracer already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 33945a694ea9be722b8992e7973da58bb8e375e7ec116ed2bd96148885501ce9 [INFO] running `Command { std: "docker" "start" "-a" "33945a694ea9be722b8992e7973da58bb8e375e7ec116ed2bd96148885501ce9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "33945a694ea9be722b8992e7973da58bb8e375e7ec116ed2bd96148885501ce9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "33945a694ea9be722b8992e7973da58bb8e375e7ec116ed2bd96148885501ce9", kill_on_drop: false }` [INFO] [stdout] 33945a694ea9be722b8992e7973da58bb8e375e7ec116ed2bd96148885501ce9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 098147d8471a515bf5af72908b3a57fc5053e4b8a66ff23e15d1994b4be34d24 [INFO] running `Command { std: "docker" "start" "-a" "098147d8471a515bf5af72908b3a57fc5053e4b8a66ff23e15d1994b4be34d24", kill_on_drop: false }` [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Compiling crossbeam-epoch v0.9.15 [INFO] [stderr] Compiling proc-macro2 v1.0.66 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Compiling unicode-ident v1.0.11 [INFO] [stderr] Compiling rayon-core v1.11.0 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Compiling futures-core v0.3.28 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Checking nanorand v0.7.0 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Checking weezl v0.1.7 [INFO] [stderr] Checking futures-sink v0.3.28 [INFO] [stderr] Checking fdeflate v0.3.0 [INFO] [stderr] Checking zune-inflate v0.2.54 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking half v2.2.1 [INFO] [stderr] Checking lebe v0.5.2 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking crossbeam-channel v0.5.8 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Checking flate2 v1.0.27 [INFO] [stderr] Checking bit_field v0.10.2 [INFO] [stderr] Checking bytemuck v1.14.0 [INFO] [stderr] Checking gif v0.12.0 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking crossbeam-deque v0.8.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Compiling syn v2.0.32 [INFO] [stderr] Checking png v0.17.10 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking rayon v1.7.0 [INFO] [stderr] Checking jpeg-decoder v0.3.0 [INFO] [stderr] Checking tiff v0.9.0 [INFO] [stderr] Compiling pin-project-internal v1.1.3 [INFO] [stderr] Checking pin-project v1.1.3 [INFO] [stderr] Checking flume v0.10.14 [INFO] [stderr] Checking exr v1.7.0 [INFO] [stderr] Checking image v0.24.7 [INFO] [stderr] Checking rtracer v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::borrow::BorrowMut` [INFO] [stdout] --> hit.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use std::borrow::BorrowMut; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taking a mutable reference to a `const` item [INFO] [stdout] --> hit.rs:219:56 [INFO] [stdout] | [INFO] [stdout] 219 | if !self.boundary.as_ref().borrow_mut().hit(r, &mut Interval::UNIVERSE, &mut rec1) { return false;} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: each usage of a `const` item creates a new temporary [INFO] [stdout] = note: the mutable reference will refer to this temporary, not the original `const` item [INFO] [stdout] note: `const` item defined here [INFO] [stdout] --> interval.rs:62:5 [INFO] [stdout] | [INFO] [stdout] 62 | pub const UNIVERSE : Interval = Interval{min : -INFINITY, max : INFINITY}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(const_item_mutation)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> hit.rs:76:22 [INFO] [stdout] | [INFO] [stdout] 74 | pub fn new(p : Rc>, displacement : Rvec3) -> Self{ [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | Self { [INFO] [stdout] 76 | object : p.clone(), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> hit.rs:78:20 [INFO] [stdout] | [INFO] [stdout] 74 | pub fn new(p : Rc>, displacement : Rvec3) -> Self{ [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | bbox : p.borrow().bounding_box() + displacement [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> hit.rs:199:70 [INFO] [stdout] | [INFO] [stdout] 198 | pub fn new_tex(b : Rc>, d : f64, a : Rc) -> Self{ [INFO] [stdout] | ----------------------------- ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 199 | Self { boundary: b, neg_inv_density: -1.0/d, phase_function: Rc::new(RefCell::new(Isotropic::new_tex(a))) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> hit.rs:202:70 [INFO] [stdout] | [INFO] [stdout] 201 | pub fn new_col(b : Rc>, d : f64, c : Color) -> Self{ [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 202 | Self { boundary: b, neg_inv_density: -1.0/d, phase_function: Rc::new(RefCell::new(Isotropic::new(c))) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `enableDebug` should have a snake case name [INFO] [stdout] --> hit.rs:213:13 [INFO] [stdout] | [INFO] [stdout] 213 | let enableDebug = false; [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `enable_debug` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `hit__left` should have a snake case name [INFO] [stdout] --> bvh.rs:94:13 [INFO] [stdout] | [INFO] [stdout] 94 | let hit__left = self._left.borrow_mut().hit(ray,ray_t,rec); [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `hit_left` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `hit__right` should have a snake case name [INFO] [stdout] --> bvh.rs:98:13 [INFO] [stdout] | [INFO] [stdout] 98 | let hit__right = self._right.borrow_mut().hit(ray, &mut Interval::new_arg(ray_t.min, mx), rec); [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `hit_right` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rtracer` (bin "rtracer" test) due to 5 previous errors; 5 warnings emitted [INFO] [stdout] error: aborting due to 4 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused import: `std::borrow::BorrowMut` [INFO] [stdout] --> hit.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use std::borrow::BorrowMut; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taking a mutable reference to a `const` item [INFO] [stdout] --> hit.rs:219:56 [INFO] [stdout] | [INFO] [stdout] 219 | if !self.boundary.as_ref().borrow_mut().hit(r, &mut Interval::UNIVERSE, &mut rec1) { return false;} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: each usage of a `const` item creates a new temporary [INFO] [stdout] = note: the mutable reference will refer to this temporary, not the original `const` item [INFO] [stdout] note: `const` item defined here [INFO] [stdout] --> interval.rs:62:5 [INFO] [stdout] | [INFO] [stdout] 62 | pub const UNIVERSE : Interval = Interval{min : -INFINITY, max : INFINITY}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(const_item_mutation)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> hit.rs:76:22 [INFO] [stdout] | [INFO] [stdout] 74 | pub fn new(p : Rc>, displacement : Rvec3) -> Self{ [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | Self { [INFO] [stdout] 76 | object : p.clone(), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> hit.rs:78:20 [INFO] [stdout] | [INFO] [stdout] 74 | pub fn new(p : Rc>, displacement : Rvec3) -> Self{ [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | bbox : p.borrow().bounding_box() + displacement [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> hit.rs:199:70 [INFO] [stdout] | [INFO] [stdout] 198 | pub fn new_tex(b : Rc>, d : f64, a : Rc) -> Self{ [INFO] [stdout] | ----------------------------- ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 199 | Self { boundary: b, neg_inv_density: -1.0/d, phase_function: Rc::new(RefCell::new(Isotropic::new_tex(a))) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> hit.rs:202:70 [INFO] [stdout] | [INFO] [stdout] 201 | pub fn new_col(b : Rc>, d : f64, c : Color) -> Self{ [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 202 | Self { boundary: b, neg_inv_density: -1.0/d, phase_function: Rc::new(RefCell::new(Isotropic::new(c))) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `enableDebug` should have a snake case name [INFO] [stdout] --> hit.rs:213:13 [INFO] [stdout] | [INFO] [stdout] 213 | let enableDebug = false; [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `enable_debug` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `hit__left` should have a snake case name [INFO] [stdout] --> bvh.rs:94:13 [INFO] [stdout] | [INFO] [stdout] 94 | let hit__left = self._left.borrow_mut().hit(ray,ray_t,rec); [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `hit_left` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `hit__right` should have a snake case name [INFO] [stdout] --> bvh.rs:98:13 [INFO] [stdout] | [INFO] [stdout] 98 | let hit__right = self._right.borrow_mut().hit(ray, &mut Interval::new_arg(ray_t.min, mx), rec); [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `hit_right` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rtracer` (bin "rtracer") due to 5 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "098147d8471a515bf5af72908b3a57fc5053e4b8a66ff23e15d1994b4be34d24", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "098147d8471a515bf5af72908b3a57fc5053e4b8a66ff23e15d1994b4be34d24", kill_on_drop: false }` [INFO] [stdout] 098147d8471a515bf5af72908b3a57fc5053e4b8a66ff23e15d1994b4be34d24