[INFO] cloning repository https://github.com/bnarnold/adventofcode-2023 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/bnarnold/adventofcode-2023" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbnarnold%2Fadventofcode-2023", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbnarnold%2Fadventofcode-2023'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d57f809bc7720120fec814843fea4bcb6920faf0 [INFO] checking bnarnold/adventofcode-2023/d57f809bc7720120fec814843fea4bcb6920faf0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbnarnold%2Fadventofcode-2023" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/bnarnold/adventofcode-2023 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/bnarnold/adventofcode-2023 [INFO] finished tweaking git repo https://github.com/bnarnold/adventofcode-2023 [INFO] tweaked toml for git repo https://github.com/bnarnold/adventofcode-2023 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/bnarnold/adventofcode-2023 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7c6b9add6e6848736b4cfedb70e9aa4bab4beafbc6d6de0cc84b3a4827a51796 [INFO] running `Command { std: "docker" "start" "-a" "7c6b9add6e6848736b4cfedb70e9aa4bab4beafbc6d6de0cc84b3a4827a51796", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7c6b9add6e6848736b4cfedb70e9aa4bab4beafbc6d6de0cc84b3a4827a51796", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7c6b9add6e6848736b4cfedb70e9aa4bab4beafbc6d6de0cc84b3a4827a51796", kill_on_drop: false }` [INFO] [stdout] 7c6b9add6e6848736b4cfedb70e9aa4bab4beafbc6d6de0cc84b3a4827a51796 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5dba8c513d18000932f2c08f9edc487d76d53998c4e44b6253363be38cf66972 [INFO] running `Command { std: "docker" "start" "-a" "5dba8c513d18000932f2c08f9edc487d76d53998c4e44b6253363be38cf66972", kill_on_drop: false }` [INFO] [stderr] Compiling cc v1.0.77 [INFO] [stderr] Compiling libc v0.2.137 [INFO] [stderr] Checking once_cell v1.16.0 [INFO] [stderr] Compiling radium v0.7.0 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Checking percent-encoding v2.2.0 [INFO] [stderr] Compiling rustls v0.20.7 [INFO] [stderr] Checking miniz_oxide v0.6.2 [INFO] [stderr] Checking form_urlencoded v1.1.0 [INFO] [stderr] Checking tap v1.0.1 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Compiling anyhow v1.0.66 [INFO] [stderr] Checking nom v7.1.1 [INFO] [stderr] Checking wyz v0.5.1 [INFO] [stderr] Checking flate2 v1.0.25 [INFO] [stderr] Checking brownstone v3.0.0 [INFO] [stderr] Checking idna v0.3.0 [INFO] [stderr] Checking aho-corasick v0.7.20 [INFO] [stderr] Checking funty v2.0.0 [INFO] [stderr] Checking either v1.8.0 [INFO] [stderr] Checking regex-syntax v0.6.28 [INFO] [stderr] Checking joinery v2.1.0 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Checking indent_write v2.2.0 [INFO] [stderr] Checking base64 v0.13.1 [INFO] [stderr] Checking bitvec v1.0.1 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking url v2.3.1 [INFO] [stderr] Checking pico-args v0.5.0 [INFO] [stderr] Checking dotenvy v0.15.6 [INFO] [stderr] Checking nom-supreme v0.8.0 [INFO] [stderr] Checking regex v1.7.0 [INFO] [stderr] Checking webpki v0.22.0 [INFO] [stderr] Checking sct v0.7.0 [INFO] [stderr] Checking webpki-roots v0.22.5 [INFO] [stderr] Checking ureq v2.5.0 [INFO] [stderr] Checking adventofcode-2023 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/days/day2.rs:119:5 [INFO] [stdout] | [INFO] [stdout] 108 | let parse_color = tuple(( [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | / collect_separated_terminated( [INFO] [stdout] 120 | | parse_color, [INFO] [stdout] 121 | | tag(", "), [INFO] [stdout] 122 | | tag("; ").or(alt((tag("\n"), eof)).peek()), [INFO] [stdout] 123 | | ) [INFO] [stdout] 124 | | .context("set of cubes") [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/days/day3.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 8 | let regex = Regex::new(r"\d+").unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | let width = grid[0].len(); [INFO] [stdout] 10 | / regex [INFO] [stdout] 11 | | .find_iter(input) [INFO] [stdout] 12 | | .map(|number_match| { [INFO] [stdout] 13 | | let Range { start, end } = number_match.into(); [INFO] [stdout] ... | [INFO] [stdout] 41 | | } [INFO] [stdout] 42 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/days/day4.rs:27:18 [INFO] [stdout] | [INFO] [stdout] 27 | .map(|l| parse_line(l).expect("line parse")) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/days/day5.rs:42:13 [INFO] [stdout] | [INFO] [stdout] 40 | fn extend>(&mut self, iter: T) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | self.0.extend( [INFO] [stdout] 42 | / iter.into_iter() [INFO] [stdout] 43 | | .map(|(target, source, len)| (source, Segment { target, len })), [INFO] [stdout] | |_______________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/infra.rs:58:5 [INFO] [stdout] | [INFO] [stdout] 52 | data: impl Display, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | / ureq::post(&url) [INFO] [stdout] 59 | | .set("Content-Type", "x-www-form-urlencoded") [INFO] [stdout] 60 | | .set("Cookie", &session_cookie) [INFO] [stdout] 61 | | .send_string(&payload) [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/prelude.rs:96:28 [INFO] [stdout] | [INFO] [stdout] 94 | mut line_parser: F, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | ) -> impl Parser<&'a str, Self, ErrorTree<&'a str>> { [INFO] [stdout] 96 | move |input| match line_parser.parse(input) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/days/day2.rs:119:5 [INFO] [stdout] | [INFO] [stdout] 108 | let parse_color = tuple(( [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | / collect_separated_terminated( [INFO] [stdout] 120 | | parse_color, [INFO] [stdout] 121 | | tag(", "), [INFO] [stdout] 122 | | tag("; ").or(alt((tag("\n"), eof)).peek()), [INFO] [stdout] 123 | | ) [INFO] [stdout] 124 | | .context("set of cubes") [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `adventofcode-2023` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/days/day3.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 8 | let regex = Regex::new(r"\d+").unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | let width = grid[0].len(); [INFO] [stdout] 10 | / regex [INFO] [stdout] 11 | | .find_iter(input) [INFO] [stdout] 12 | | .map(|number_match| { [INFO] [stdout] 13 | | let Range { start, end } = number_match.into(); [INFO] [stdout] ... | [INFO] [stdout] 41 | | } [INFO] [stdout] 42 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/days/day4.rs:27:18 [INFO] [stdout] | [INFO] [stdout] 27 | .map(|l| parse_line(l).expect("line parse")) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/days/day5.rs:42:13 [INFO] [stdout] | [INFO] [stdout] 40 | fn extend>(&mut self, iter: T) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | self.0.extend( [INFO] [stdout] 42 | / iter.into_iter() [INFO] [stdout] 43 | | .map(|(target, source, len)| (source, Segment { target, len })), [INFO] [stdout] | |_______________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/infra.rs:58:5 [INFO] [stdout] | [INFO] [stdout] 52 | data: impl Display, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | / ureq::post(&url) [INFO] [stdout] 59 | | .set("Content-Type", "x-www-form-urlencoded") [INFO] [stdout] 60 | | .set("Cookie", &session_cookie) [INFO] [stdout] 61 | | .send_string(&payload) [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/prelude.rs:96:28 [INFO] [stdout] | [INFO] [stdout] 94 | mut line_parser: F, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | ) -> impl Parser<&'a str, Self, ErrorTree<&'a str>> { [INFO] [stdout] 96 | move |input| match line_parser.parse(input) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `adventofcode-2023` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "5dba8c513d18000932f2c08f9edc487d76d53998c4e44b6253363be38cf66972", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5dba8c513d18000932f2c08f9edc487d76d53998c4e44b6253363be38cf66972", kill_on_drop: false }` [INFO] [stdout] 5dba8c513d18000932f2c08f9edc487d76d53998c4e44b6253363be38cf66972