[INFO] cloning repository https://github.com/bm-w/advent20-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/bm-w/advent20-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbm-w%2Fadvent20-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbm-w%2Fadvent20-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c7080e0daf313deb1daf6ac4de5ac74f0ee3ce3f [INFO] checking bm-w/advent20-rs/c7080e0daf313deb1daf6ac4de5ac74f0ee3ce3f against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbm-w%2Fadvent20-rs" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/bm-w/advent20-rs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/bm-w/advent20-rs [INFO] finished tweaking git repo https://github.com/bm-w/advent20-rs [INFO] tweaked toml for git repo https://github.com/bm-w/advent20-rs written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/bm-w/advent20-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2688871be00d6e17d4a537cab7dd58277a6f9592c2c03b4cdc5cf8e8ce3023b6 [INFO] running `Command { std: "docker" "start" "-a" "2688871be00d6e17d4a537cab7dd58277a6f9592c2c03b4cdc5cf8e8ce3023b6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2688871be00d6e17d4a537cab7dd58277a6f9592c2c03b4cdc5cf8e8ce3023b6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2688871be00d6e17d4a537cab7dd58277a6f9592c2c03b4cdc5cf8e8ce3023b6", kill_on_drop: false }` [INFO] [stdout] 2688871be00d6e17d4a537cab7dd58277a6f9592c2c03b4cdc5cf8e8ce3023b6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a04199deb0dbcc419d8abeb14a9373e5bd4f801e7d663661aecaf7c6d2eec601 [INFO] running `Command { std: "docker" "start" "-a" "a04199deb0dbcc419d8abeb14a9373e5bd4f801e7d663661aecaf7c6d2eec601", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling num-bigint v0.4.3 [INFO] [stderr] Compiling num-iter v0.1.42 [INFO] [stderr] Compiling num-rational v0.4.0 [INFO] [stderr] Compiling unindent v0.1.8 [INFO] [stderr] Compiling paste v1.0.7 [INFO] [stderr] Checking itertools v0.10.3 [INFO] [stderr] Compiling indoc v1.0.4 [INFO] [stderr] Checking num-complex v0.4.0 [INFO] [stderr] Checking advent20 v0.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/day04.rs:106:38 [INFO] [stdout] | [INFO] [stdout] 106 | pub(super) struct InvalidFieldError(String); [INFO] [stdout] | ----------------- ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `InvalidFieldError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/day05.rs:88:36 [INFO] [stdout] | [INFO] [stdout] 88 | pub(super) struct InvalidRowError(char); [INFO] [stdout] | --------------- ^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `InvalidRowError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/day05.rs:102:39 [INFO] [stdout] | [INFO] [stdout] 102 | pub(super) struct InvalidColumnError(char); [INFO] [stdout] | ------------------ ^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `InvalidColumnError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/day07.rs:75:21 [INFO] [stdout] | [INFO] [stdout] 75 | InvalidColorWords(usize), [INFO] [stdout] | ----------------- ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `BagError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 75 | InvalidColorWords(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/day08.rs:81:35 [INFO] [stdout] | [INFO] [stdout] 81 | pub(super) struct InvalidOpError(String); [INFO] [stdout] | -------------- ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `InvalidOpError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/day13.rs:107:36 [INFO] [stdout] | [INFO] [stdout] 107 | pub(super) struct InvalidBusError(ParseIntError); [INFO] [stdout] | --------------- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `InvalidBusError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/day24.rs:115:8 [INFO] [stdout] | [INFO] [stdout] 115 | Char(char), [INFO] [stdout] | ---- ^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `DirError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 115 | Char(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/day24.rs:116:8 [INFO] [stdout] | [INFO] [stdout] 116 | Next(Option) [INFO] [stdout] | ---- ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `DirError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 116 | Next(()) [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/day03.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 51 | .map(|s| input_grid.spaces_along_slope(s).filter(|s| *s).count()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/day06.rs:45:30 [INFO] [stdout] | [INFO] [stdout] 45 | input_groups.iter().map(|g| g.unique_answers().len()).sum() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/day06.rs:54:30 [INFO] [stdout] | [INFO] [stdout] 54 | input_groups.iter().map(|g| g.common_answers().len()).sum() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/day06.rs:103:13 [INFO] [stdout] | [INFO] [stdout] 99 | fn try_from(lines: EnumeratedLines<'l, L>) -> Result { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | use GroupError::*; [INFO] [stdout] 101 | let mut lines = lines.0.peekable(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | if lines.peek().is_none() { return Err(InvalidFormat { line: 1 }) } [INFO] [stdout] 103 | Ok(Group(lines [INFO] [stdout] | ______________________^ [INFO] [stdout] 104 | | .map(|(l, line)| line.parse() [INFO] [stdout] 105 | | .map_err(|e| InvalidPerson { line: l + 1, source: e })) [INFO] [stdout] | |___________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/day12.rs:137:2 [INFO] [stdout] | [INFO] [stdout] 136 | fn part1_impl(input_instrs: impl Iterator + 'static) -> u32 { [INFO] [stdout] | --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | input_instrs.perform_wrong().last().map(|pos| pos[0].abs() as u32 + pos[1].abs() as u32).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/day12.rs:146:2 [INFO] [stdout] | [INFO] [stdout] 145 | fn part2_impl(input_instrs: impl Iterator + 'static) -> u32 { [INFO] [stdout] | --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | input_instrs.perform_right().last().map(|pos| pos[0].abs() as u32 + pos[1].abs() as u32).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/day12.rs:73:13 [INFO] [stdout] | [INFO] [stdout] 69 | fn perform_wrong(self) -> Box> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | Box::new(self.map(move |instr| { [INFO] [stdout] | ______________________^ [INFO] [stdout] 74 | | match instr { [INFO] [stdout] 75 | | MoveDir(card_dir, dist) => { [INFO] [stdout] 76 | | let vec = card_dir.vec(dist); [INFO] [stdout] ... | [INFO] [stdout] 89 | | pos.0 [INFO] [stdout] 90 | | })) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/day12.rs:99:13 [INFO] [stdout] | [INFO] [stdout] 94 | fn perform_right(self) -> Box> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | Box::new(self.map(move |instr| { [INFO] [stdout] | ______________________^ [INFO] [stdout] 100 | | match instr { [INFO] [stdout] 101 | | MoveDir(card_dir, dist) => { [INFO] [stdout] 102 | | let vec = card_dir.vec(dist); [INFO] [stdout] ... | [INFO] [stdout] 116 | | pos [INFO] [stdout] 117 | | })) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/day14.rs:63:3 [INFO] [stdout] | [INFO] [stdout] 57 | fn execute_common(self, map: Map, extend: Extend) -> u64 [INFO] [stdout] | ---- -------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | / self.into_iter() [INFO] [stdout] 64 | | .scan(Mask::default(), |accum_mask, instr| match instr { [INFO] [stdout] 65 | | Instr::SetMask(mask) => { *accum_mask = mask; Some(None) } [INFO] [stdout] 66 | | Instr::WriteVal { addr, val } => Some(Some(map(*accum_mask, addr, val))) [INFO] [stdout] 67 | | }) [INFO] [stdout] 68 | | .flatten() [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/day17.rs:170:7 [INFO] [stdout] | [INFO] [stdout] 151 | let active_spaces = lines.enumerate() [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 170 | Ok(Grid { active_spaces }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/day18.rs:51:2 [INFO] [stdout] | [INFO] [stdout] 49 | fn part1and2_impl(input_exprs: I) -> u64 [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | where I: IntoIterator> { [INFO] [stdout] 51 | input_exprs.into_iter().map(|expr| expr.evaluate()).sum() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/day18.rs:130:13 [INFO] [stdout] | [INFO] [stdout] 129 | .fold(None, |acc, (arg, op)| [INFO] [stdout] | --- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | Some(match acc { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 131 | | Some((acc_arg, acc_op)) => [INFO] [stdout] 132 | | (Arg::Expr(Box::new(Expr(acc_op, [acc_arg, arg]))), op), [INFO] [stdout] 133 | | None => (arg, op) [INFO] [stdout] 134 | | })) [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/day18.rs:139:22 [INFO] [stdout] | [INFO] [stdout] 138 | let into_acc_expr = |acc_arg, arg| [INFO] [stdout] | ------- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | Expr(Op::Plus, [acc_arg, arg]); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/day18.rs:141:17 [INFO] [stdout] | [INFO] [stdout] 140 | let into_acc_expr_arg = |acc_arg, arg| [INFO] [stdout] | ------- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 141 | Arg::Expr(Box::new(into_acc_expr(acc_arg, arg))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/day18.rs:144:8 [INFO] [stdout] | [INFO] [stdout] 142 | let into_incompl_plus_expr = |skipped_times_args: Vec<_>, tail_arg| [INFO] [stdout] | -------------------------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | IncompleteExpr( [INFO] [stdout] 144 | skipped_times_args.into_iter().map(|a| (a, Op::Times)).collect::>(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/day18.rs:145:8 [INFO] [stdout] | [INFO] [stdout] 142 | let into_incompl_plus_expr = |skipped_times_args: Vec<_>, tail_arg| [INFO] [stdout] | -------------------------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | Some(tail_arg)); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/day18.rs:148:14 [INFO] [stdout] | [INFO] [stdout] 147 | .fold((None, vec![]), |(acc_arg, mut skipped_times_args), (arg, op)| [INFO] [stdout] | --------------------------------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 148 | match (op, acc_arg) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/day18.rs:187:8 [INFO] [stdout] | [INFO] [stdout] 180 | incompl_expr: IncompleteExpr [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | Ok(Arg::Expr(Box::new(try_into_expr(plus_first, incompl_expr)?))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/day18.rs:236:3 [INFO] [stdout] | [INFO] [stdout] 234 | lines: impl Iterator + 'l [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 235 | ) -> impl Iterator, ExprsError>> + 'l { [INFO] [stdout] 236 | lines.enumerate() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/day18.rs:237:21 [INFO] [stdout] | [INFO] [stdout] 237 | .map(|(l, line)| line.parse() [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/day19.rs:206:2 [INFO] [stdout] | [INFO] [stdout] 204 | fn part1_impl(input: Input) -> usize { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 205 | let Input { rules, messages } = input; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 206 | messages.filter(|m| Input::message_matches_rule0(&rules, m)).count() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/day19.rs:218:2 [INFO] [stdout] | [INFO] [stdout] 214 | fn part2_impl(input: Input) -> usize { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 215 | let Input { mut rules, messages } = input; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 218 | messages.filter(|m| Input::message_matches_rule0(&rules, m)).count() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/day20.rs:167:3 [INFO] [stdout] | [INFO] [stdout] 166 | fn edge_indexed_tiles<'a>(iter: impl Iterator) -> HashMap, Vec<(Transform, &'a ImageTile)>> { [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 167 | / iter [INFO] [stdout] 168 | | .flat_map(|tile| { [INFO] [stdout] 169 | | let edges = tile.edges(); [INFO] [stdout] 170 | | let mut rev_edges = edges.clone(); [INFO] [stdout] ... | [INFO] [stdout] 178 | | not_flipped.chain(flipped) [INFO] [stdout] 179 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/day20.rs:441:7 [INFO] [stdout] | [INFO] [stdout] 435 | fn try_from(tiles: T) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 441 | Ok(_Image { tiles, tiles_width, per_tile_width, _pd: PhantomData }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/day21.rs:108:7 [INFO] [stdout] | [INFO] [stdout] 105 | let ingredients = ingredients.split(' ').collect(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | let allergens = allergens.split(", ").collect(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | [INFO] [stdout] 108 | Ok(Food { ingredients, allergens }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/day21.rs:122:5 [INFO] [stdout] | [INFO] [stdout] 122 | line.try_into() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/day24.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 42 | fn from(instrs: I) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | Floor(Floor::black_tiles_from_instrs(instrs).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 27 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `advent20` (bin "advent20") due to 28 previous errors; 8 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "a04199deb0dbcc419d8abeb14a9373e5bd4f801e7d663661aecaf7c6d2eec601", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a04199deb0dbcc419d8abeb14a9373e5bd4f801e7d663661aecaf7c6d2eec601", kill_on_drop: false }` [INFO] [stdout] a04199deb0dbcc419d8abeb14a9373e5bd4f801e7d663661aecaf7c6d2eec601