[INFO] cloning repository https://github.com/bloop-box/bloop-box-client [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/bloop-box/bloop-box-client" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbloop-box%2Fbloop-box-client", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbloop-box%2Fbloop-box-client'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c9a777cec8de623d7d05ea00941fdbca940fc291 [INFO] checking bloop-box/bloop-box-client/c9a777cec8de623d7d05ea00941fdbca940fc291 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbloop-box%2Fbloop-box-client" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/bloop-box/bloop-box-client on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/bloop-box/bloop-box-client [INFO] finished tweaking git repo https://github.com/bloop-box/bloop-box-client [INFO] tweaked toml for git repo https://github.com/bloop-box/bloop-box-client written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/bloop-box/bloop-box-client already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fc8a4cdda91deb611a3c095310938644363d60062571bbec81e7a3e1d008d295 [INFO] running `Command { std: "docker" "start" "-a" "fc8a4cdda91deb611a3c095310938644363d60062571bbec81e7a3e1d008d295", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fc8a4cdda91deb611a3c095310938644363d60062571bbec81e7a3e1d008d295", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fc8a4cdda91deb611a3c095310938644363d60062571bbec81e7a3e1d008d295", kill_on_drop: false }` [INFO] [stdout] fc8a4cdda91deb611a3c095310938644363d60062571bbec81e7a3e1d008d295 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c60230ac6e2b5147125d55d7925ccc528a82282a582925441f9280b3837dd03e [INFO] running `Command { std: "docker" "start" "-a" "c60230ac6e2b5147125d55d7925ccc528a82282a582925441f9280b3837dd03e", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.70 [INFO] [stderr] Compiling libc v0.2.151 [INFO] [stderr] Checking getrandom v0.2.11 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling futures-core v0.3.29 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Compiling semver v1.0.20 [INFO] [stderr] Compiling thiserror v1.0.50 [INFO] [stderr] Compiling futures-channel v0.3.29 [INFO] [stderr] Checking futures-sink v0.3.29 [INFO] [stderr] Compiling futures-task v0.3.29 [INFO] [stderr] Checking nix v0.23.2 [INFO] [stderr] Compiling alsa-sys v0.3.1 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Compiling futures-util v0.3.29 [INFO] [stderr] Checking untrusted v0.9.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking encoding_rs v0.8.33 [INFO] [stderr] Checking symphonia-core v0.5.3 [INFO] [stderr] Checking futures-io v0.3.29 [INFO] [stderr] Checking nb v1.1.0 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Checking nb v0.1.3 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling heapless v0.7.17 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling syn v2.0.39 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking nix v0.24.3 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling async-trait v0.1.74 [INFO] [stderr] Compiling either v1.9.0 [INFO] [stderr] Compiling cpal v0.15.2 [INFO] [stderr] Compiling rustls v0.21.10 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking embedded-hal v0.2.7 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking alsa v0.7.1 [INFO] [stderr] Checking symphonia-metadata v0.5.3 [INFO] [stderr] Checking symphonia-bundle-mp3 v0.5.3 [INFO] [stderr] Compiling ring v0.17.7 [INFO] [stderr] Checking hash32 v0.2.1 [INFO] [stderr] Checking ioctl-rs v0.1.6 [INFO] [stderr] Checking serial-core v0.4.0 [INFO] [stderr] Checking termios v0.2.2 [INFO] [stderr] Checking ogg v0.8.0 [INFO] [stderr] Compiling serde_json v1.0.108 [INFO] [stderr] Checking winnow v0.5.26 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking dasp_sample v0.11.0 [INFO] [stderr] Checking clap_builder v4.4.11 [INFO] [stderr] Checking symphonia v0.5.3 [INFO] [stderr] Checking lewton v0.10.2 [INFO] [stderr] Checking sysfs_gpio v0.6.1 [INFO] [stderr] Checking i2cdev v0.5.1 [INFO] [stderr] Checking gpio-cdev v0.5.1 [INFO] [stderr] Checking spidev v0.5.2 [INFO] [stderr] Checking serial-unix v0.4.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking rppal v0.16.0 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking claxon v0.4.3 [INFO] [stderr] Checking hound v3.5.1 [INFO] [stderr] Checking linux-embedded-hal v0.3.2 [INFO] [stderr] Checking env_logger v0.10.1 [INFO] [stderr] Checking rodio v0.17.3 [INFO] [stderr] Checking mfrc522 v0.6.1 [INFO] [stderr] Checking rand_distr v0.4.3 [INFO] [stderr] Checking untildify v0.1.1 [INFO] [stderr] Checking webpki-roots v0.25.3 [INFO] [stderr] Compiling serde_derive v1.0.193 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling thiserror-impl v1.0.50 [INFO] [stderr] Compiling futures-macro v0.3.29 [INFO] [stderr] Compiling miette-derive v5.10.0 [INFO] [stderr] Compiling async-recursion v1.0.5 [INFO] [stderr] Compiling clap_derive v4.4.7 [INFO] [stderr] Checking tokio v1.35.0 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking aw2013 v1.0.1 [INFO] [stderr] Checking miette v5.10.0 [INFO] [stderr] Checking clap v4.4.11 [INFO] [stderr] Checking serde v1.0.193 [INFO] [stderr] Checking futures-executor v0.3.29 [INFO] [stderr] Checking futures v0.3.29 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking tokio-io-timeout v1.2.0 [INFO] [stderr] Checking tokio-graceful-shutdown v0.13.0 [INFO] [stderr] Checking serde_spanned v0.6.4 [INFO] [stderr] Checking toml_datetime v0.6.5 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking toml_edit v0.21.0 [INFO] [stderr] Compiling neli-proc-macros v0.1.3 [INFO] [stderr] Checking neli v0.6.4 [INFO] [stderr] Checking toml v0.8.8 [INFO] [stderr] Checking local-ip-address v0.5.6 [INFO] [stderr] Checking bloop-box v4.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: struct `InvalidCredentialsError` is never constructed [INFO] [stdout] --> src/subsystems/networker.rs:34:8 [INFO] [stdout] | [INFO] [stdout] 34 | struct InvalidCredentialsError; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/subsystems/audio_player.rs:58:12 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn new(rx: mpsc::Receiver, volume_change_path: PathBuf) -> Result { [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 59 | | rx, [INFO] [stdout] 60 | | volume: 1.0, [INFO] [stdout] 61 | | volume_change_path, [INFO] [stdout] 62 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/subsystems/audio_player.rs:141:12 [INFO] [stdout] | [INFO] [stdout] 96 | command: InternalCommand, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 141 | Ok(None) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/subsystems/audio_player.rs:209:31 [INFO] [stdout] | [INFO] [stdout] 203 | config: mpsc::Sender, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 204 | rx: mpsc::Receiver, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 209 | bloop_collection: AudioCollection::from_dir(&share_path.join(Path::new("bloop"))) [INFO] [stdout] | _______________________________^ [INFO] [stdout] 210 | | .unwrap(), [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/subsystems/audio_player.rs:211:33 [INFO] [stdout] | [INFO] [stdout] 203 | config: mpsc::Sender, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 204 | rx: mpsc::Receiver, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 211 | confirm_collection: AudioCollection::from_dir(&share_path.join(Path::new("confirm"))) [INFO] [stdout] | _________________________________^ [INFO] [stdout] 212 | | .unwrap(), [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/subsystems/audio_player.rs:330:67 [INFO] [stdout] | [INFO] [stdout] 330 | async fn run(mut self, subsys: SubsystemHandle) -> Result<()> { [INFO] [stdout] | ______________________----__-----------------------________________^ [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 331 | | tokio::select! { [INFO] [stdout] 332 | | _ = subsys.on_shutdown_requested() => { [INFO] [stdout] 333 | | info!("Audio player shutting down"); [INFO] [stdout] ... | [INFO] [stdout] 338 | | Ok(()) [INFO] [stdout] 339 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/subsystems/button.rs:20:18 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new(pin: Pin, tx: mpsc::Sender, value: f32) -> Self { [INFO] [stdout] | -------- --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | Button { [INFO] [stdout] 20 | pin: pin.into_input(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/subsystems/button.rs:57:67 [INFO] [stdout] | [INFO] [stdout] 57 | async fn run(mut self, subsys: SubsystemHandle) -> Result<()> { [INFO] [stdout] | ______________________----__-----------------------________________^ [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | | tokio::select! { [INFO] [stdout] 59 | | _ = subsys.on_shutdown_requested() => { [INFO] [stdout] 60 | | info!("Button shutting down"); [INFO] [stdout] ... | [INFO] [stdout] 65 | | Ok(()) [INFO] [stdout] 66 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/subsystems/config_manager.rs:143:67 [INFO] [stdout] | [INFO] [stdout] 143 | async fn run(mut self, subsys: SubsystemHandle) -> Result<()> { [INFO] [stdout] | ______________________----__-----------------------________________^ [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | | tokio::select! { [INFO] [stdout] 145 | | _ = subsys.on_shutdown_requested() => { [INFO] [stdout] 146 | | info!("Config Manager shutting down"); [INFO] [stdout] ... | [INFO] [stdout] 151 | | Ok(()) [INFO] [stdout] 152 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/subsystems/controller.rs:338:67 [INFO] [stdout] | [INFO] [stdout] 338 | async fn run(mut self, subsys: SubsystemHandle) -> Result<()> { [INFO] [stdout] | ______________________----__-----------------------________________^ [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 339 | | let (nfc_tx, nfc_rx) = mpsc::channel(1); [INFO] [stdout] 340 | | start_nfc_listener(nfc_rx, self.etc_config.nfc.clone()); [INFO] [stdout] ... | [INFO] [stdout] 349 | | Ok(()) [INFO] [stdout] 350 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/subsystems/led.rs:47:67 [INFO] [stdout] | [INFO] [stdout] 47 | async fn run(mut self, subsys: SubsystemHandle) -> Result<()> { [INFO] [stdout] | ______________________----__-----------------------________________^ [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | | let (internal_tx, internal_rx) = mpsc::channel(8); [INFO] [stdout] 49 | | [INFO] [stdout] 50 | | subsys.start( [INFO] [stdout] ... | [INFO] [stdout] 62 | | Ok(()) [INFO] [stdout] 63 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/subsystems/led.rs:111:67 [INFO] [stdout] | [INFO] [stdout] 111 | async fn run(mut self, subsys: SubsystemHandle) -> Result<()> { [INFO] [stdout] | ______________________----__-----------------------________________^ [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | | let mut aw2013 = Aw2013::from_default_address([Current::Five; 3])?; [INFO] [stdout] 113 | | aw2013.reset()?; [INFO] [stdout] 114 | | sleep(Duration::from_millis(10)).await; [INFO] [stdout] ... | [INFO] [stdout] 128 | | Ok(()) [INFO] [stdout] 129 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/subsystems/networker.rs:88:27 [INFO] [stdout] | [INFO] [stdout] 78 | rx: mpsc::Receiver, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | status_tx: mpsc::Sender, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | config: mpsc::Sender, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | maybe_stream: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/subsystems/networker.rs:235:28 [INFO] [stdout] | [INFO] [stdout] 230 | let client_config = ClientConfig::builder() [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 235 | TlsConnector::from(Arc::new(client_config)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/subsystems/networker.rs:356:67 [INFO] [stdout] | [INFO] [stdout] 356 | async fn run(mut self, subsys: SubsystemHandle) -> Result<()> { [INFO] [stdout] | ______________________----__-----------------------________________^ [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 357 | | tokio::select! { [INFO] [stdout] 358 | | _ = subsys.on_shutdown_requested() => { [INFO] [stdout] 359 | | info!("Networker shutting down"); [INFO] [stdout] ... | [INFO] [stdout] 368 | | Ok(()) [INFO] [stdout] 369 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/subsystems/volume_control.rs:48:67 [INFO] [stdout] | [INFO] [stdout] 48 | async fn run(mut self, subsys: SubsystemHandle) -> Result<()> { [INFO] [stdout] | ______________________----__-----------------------________________^ [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | | let gpio = Gpio::new()?; [INFO] [stdout] 50 | | let (button_tx, button_rx) = mpsc::channel::(1); [INFO] [stdout] 51 | | let volume_down_pin = gpio.get(self.etc_config.gpio.volume_down_button)?; [INFO] [stdout] ... | [INFO] [stdout] 70 | | Ok(()) [INFO] [stdout] 71 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 15 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bloop-box` (bin "bloop-box") due to 16 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: struct `InvalidCredentialsError` is never constructed [INFO] [stdout] --> src/subsystems/networker.rs:34:8 [INFO] [stdout] | [INFO] [stdout] 34 | struct InvalidCredentialsError; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/subsystems/audio_player.rs:58:12 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn new(rx: mpsc::Receiver, volume_change_path: PathBuf) -> Result { [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 59 | | rx, [INFO] [stdout] 60 | | volume: 1.0, [INFO] [stdout] 61 | | volume_change_path, [INFO] [stdout] 62 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/subsystems/audio_player.rs:141:12 [INFO] [stdout] | [INFO] [stdout] 96 | command: InternalCommand, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 141 | Ok(None) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/subsystems/audio_player.rs:209:31 [INFO] [stdout] | [INFO] [stdout] 203 | config: mpsc::Sender, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 204 | rx: mpsc::Receiver, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 209 | bloop_collection: AudioCollection::from_dir(&share_path.join(Path::new("bloop"))) [INFO] [stdout] | _______________________________^ [INFO] [stdout] 210 | | .unwrap(), [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/subsystems/audio_player.rs:211:33 [INFO] [stdout] | [INFO] [stdout] 203 | config: mpsc::Sender, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 204 | rx: mpsc::Receiver, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 211 | confirm_collection: AudioCollection::from_dir(&share_path.join(Path::new("confirm"))) [INFO] [stdout] | _________________________________^ [INFO] [stdout] 212 | | .unwrap(), [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/subsystems/audio_player.rs:330:67 [INFO] [stdout] | [INFO] [stdout] 330 | async fn run(mut self, subsys: SubsystemHandle) -> Result<()> { [INFO] [stdout] | ______________________----__-----------------------________________^ [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 331 | | tokio::select! { [INFO] [stdout] 332 | | _ = subsys.on_shutdown_requested() => { [INFO] [stdout] 333 | | info!("Audio player shutting down"); [INFO] [stdout] ... | [INFO] [stdout] 338 | | Ok(()) [INFO] [stdout] 339 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/subsystems/button.rs:20:18 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new(pin: Pin, tx: mpsc::Sender, value: f32) -> Self { [INFO] [stdout] | -------- --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | Button { [INFO] [stdout] 20 | pin: pin.into_input(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/subsystems/button.rs:57:67 [INFO] [stdout] | [INFO] [stdout] 57 | async fn run(mut self, subsys: SubsystemHandle) -> Result<()> { [INFO] [stdout] | ______________________----__-----------------------________________^ [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | | tokio::select! { [INFO] [stdout] 59 | | _ = subsys.on_shutdown_requested() => { [INFO] [stdout] 60 | | info!("Button shutting down"); [INFO] [stdout] ... | [INFO] [stdout] 65 | | Ok(()) [INFO] [stdout] 66 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/subsystems/config_manager.rs:143:67 [INFO] [stdout] | [INFO] [stdout] 143 | async fn run(mut self, subsys: SubsystemHandle) -> Result<()> { [INFO] [stdout] | ______________________----__-----------------------________________^ [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | | tokio::select! { [INFO] [stdout] 145 | | _ = subsys.on_shutdown_requested() => { [INFO] [stdout] 146 | | info!("Config Manager shutting down"); [INFO] [stdout] ... | [INFO] [stdout] 151 | | Ok(()) [INFO] [stdout] 152 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/subsystems/controller.rs:338:67 [INFO] [stdout] | [INFO] [stdout] 338 | async fn run(mut self, subsys: SubsystemHandle) -> Result<()> { [INFO] [stdout] | ______________________----__-----------------------________________^ [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 339 | | let (nfc_tx, nfc_rx) = mpsc::channel(1); [INFO] [stdout] 340 | | start_nfc_listener(nfc_rx, self.etc_config.nfc.clone()); [INFO] [stdout] ... | [INFO] [stdout] 349 | | Ok(()) [INFO] [stdout] 350 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/subsystems/led.rs:47:67 [INFO] [stdout] | [INFO] [stdout] 47 | async fn run(mut self, subsys: SubsystemHandle) -> Result<()> { [INFO] [stdout] | ______________________----__-----------------------________________^ [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | | let (internal_tx, internal_rx) = mpsc::channel(8); [INFO] [stdout] 49 | | [INFO] [stdout] 50 | | subsys.start( [INFO] [stdout] ... | [INFO] [stdout] 62 | | Ok(()) [INFO] [stdout] 63 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/subsystems/led.rs:111:67 [INFO] [stdout] | [INFO] [stdout] 111 | async fn run(mut self, subsys: SubsystemHandle) -> Result<()> { [INFO] [stdout] | ______________________----__-----------------------________________^ [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | | let mut aw2013 = Aw2013::from_default_address([Current::Five; 3])?; [INFO] [stdout] 113 | | aw2013.reset()?; [INFO] [stdout] 114 | | sleep(Duration::from_millis(10)).await; [INFO] [stdout] ... | [INFO] [stdout] 128 | | Ok(()) [INFO] [stdout] 129 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/subsystems/networker.rs:88:27 [INFO] [stdout] | [INFO] [stdout] 78 | rx: mpsc::Receiver, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | status_tx: mpsc::Sender, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | config: mpsc::Sender, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | maybe_stream: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/subsystems/networker.rs:235:28 [INFO] [stdout] | [INFO] [stdout] 230 | let client_config = ClientConfig::builder() [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 235 | TlsConnector::from(Arc::new(client_config)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/subsystems/networker.rs:356:67 [INFO] [stdout] | [INFO] [stdout] 356 | async fn run(mut self, subsys: SubsystemHandle) -> Result<()> { [INFO] [stdout] | ______________________----__-----------------------________________^ [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 357 | | tokio::select! { [INFO] [stdout] 358 | | _ = subsys.on_shutdown_requested() => { [INFO] [stdout] 359 | | info!("Networker shutting down"); [INFO] [stdout] ... | [INFO] [stdout] 368 | | Ok(()) [INFO] [stdout] 369 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/subsystems/volume_control.rs:48:67 [INFO] [stdout] | [INFO] [stdout] 48 | async fn run(mut self, subsys: SubsystemHandle) -> Result<()> { [INFO] [stdout] | ______________________----__-----------------------________________^ [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | | let gpio = Gpio::new()?; [INFO] [stdout] 50 | | let (button_tx, button_rx) = mpsc::channel::(1); [INFO] [stdout] 51 | | let volume_down_pin = gpio.get(self.etc_config.gpio.volume_down_button)?; [INFO] [stdout] ... | [INFO] [stdout] 70 | | Ok(()) [INFO] [stdout] 71 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 15 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bloop-box` (bin "bloop-box" test) due to 16 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "c60230ac6e2b5147125d55d7925ccc528a82282a582925441f9280b3837dd03e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c60230ac6e2b5147125d55d7925ccc528a82282a582925441f9280b3837dd03e", kill_on_drop: false }` [INFO] [stdout] c60230ac6e2b5147125d55d7925ccc528a82282a582925441f9280b3837dd03e