[INFO] cloning repository https://github.com/blockbandit1337/lp-manager [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/blockbandit1337/lp-manager" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fblockbandit1337%2Flp-manager", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fblockbandit1337%2Flp-manager'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 7d9d760912ceb612088f374ab4e87165e90018da [INFO] checking blockbandit1337/lp-manager/7d9d760912ceb612088f374ab4e87165e90018da against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fblockbandit1337%2Flp-manager" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/blockbandit1337/lp-manager on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/blockbandit1337/lp-manager [INFO] finished tweaking git repo https://github.com/blockbandit1337/lp-manager [INFO] tweaked toml for git repo https://github.com/blockbandit1337/lp-manager written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/blockbandit1337/lp-manager already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 141b660200fd0b42111dd1aa1799f283c3d050855fd03386391fa6450cf2edf8 [INFO] running `Command { std: "docker" "start" "-a" "141b660200fd0b42111dd1aa1799f283c3d050855fd03386391fa6450cf2edf8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "141b660200fd0b42111dd1aa1799f283c3d050855fd03386391fa6450cf2edf8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "141b660200fd0b42111dd1aa1799f283c3d050855fd03386391fa6450cf2edf8", kill_on_drop: false }` [INFO] [stdout] 141b660200fd0b42111dd1aa1799f283c3d050855fd03386391fa6450cf2edf8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5e02a4d8b04a0a835b555d50215938caa9cb021e9cb9d1644a2d2b757b2ee523 [INFO] running `Command { std: "docker" "start" "-a" "5e02a4d8b04a0a835b555d50215938caa9cb021e9cb9d1644a2d2b757b2ee523", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Compiling pkg-config v0.3.27 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Compiling cc v1.0.90 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling openssl v0.10.57 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Compiling thiserror v1.0.58 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking data-encoding v2.5.0 [INFO] [stderr] Compiling serde_json v1.0.115 [INFO] [stderr] Checking utf-8 v0.7.6 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling syn v2.0.58 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Compiling openssl-sys v0.9.93 [INFO] [stderr] Checking getrandom v0.2.13 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking socket2 v0.5.6 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling thiserror-impl v1.0.58 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tungstenite v0.21.0 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking tokio-tungstenite v0.21.0 [INFO] [stderr] Checking liquidity-manager v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/liquidity_manager.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 35 | if (bbo.best_ask_price > tight_ask || bbo.best_bid_price < tight_bid) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 35 - if (bbo.best_ask_price > tight_ask || bbo.best_bid_price < tight_bid) { [INFO] [stdout] 35 + if bbo.best_ask_price > tight_ask || bbo.best_bid_price < tight_bid { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/liquidity_manager.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 35 | if (bbo.best_ask_price > tight_ask || bbo.best_bid_price < tight_bid) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 35 - if (bbo.best_ask_price > tight_ask || bbo.best_bid_price < tight_bid) { [INFO] [stdout] 35 + if bbo.best_ask_price > tight_ask || bbo.best_bid_price < tight_bid { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `size` is never read [INFO] [stdout] --> src/liquidity_manager.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 4 | struct LiquidityPosition { [INFO] [stdout] | ----------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 7 | size: i64, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `size` is never read [INFO] [stdout] --> src/liquidity_manager.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 4 | struct LiquidityPosition { [INFO] [stdout] | ----------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 7 | size: i64, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/market_pricing.rs:43:19 [INFO] [stdout] | [INFO] [stdout] 41 | read.for_each(|message| async { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | let data = message.unwrap().into_text().unwrap(); [INFO] [stdout] 43 | match serde_json::from_str::(&data){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/market_pricing.rs:43:19 [INFO] [stdout] | [INFO] [stdout] 41 | read.for_each(|message| async { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | let data = message.unwrap().into_text().unwrap(); [INFO] [stdout] 43 | match serde_json::from_str::(&data){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `liquidity-manager` (bin "liquidity-manager" test) due to 2 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `liquidity-manager` (bin "liquidity-manager") due to 2 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "5e02a4d8b04a0a835b555d50215938caa9cb021e9cb9d1644a2d2b757b2ee523", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5e02a4d8b04a0a835b555d50215938caa9cb021e9cb9d1644a2d2b757b2ee523", kill_on_drop: false }` [INFO] [stdout] 5e02a4d8b04a0a835b555d50215938caa9cb021e9cb9d1644a2d2b757b2ee523