[INFO] cloning repository https://github.com/blasrodri/hashx [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/blasrodri/hashx" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fblasrodri%2Fhashx", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fblasrodri%2Fhashx'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 2d9520dd8c2cfe57214ee62fb1ba0d0312333932 [INFO] checking blasrodri/hashx/2d9520dd8c2cfe57214ee62fb1ba0d0312333932 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fblasrodri%2Fhashx" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/blasrodri/hashx on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/blasrodri/hashx [INFO] finished tweaking git repo https://github.com/blasrodri/hashx [INFO] tweaked toml for git repo https://github.com/blasrodri/hashx written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/blasrodri/hashx already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6b8064f216a4dccd24e3a73bdbeaee6ecab4e905b7387313a4df01fd507a0dd0 [INFO] running `Command { std: "docker" "start" "-a" "6b8064f216a4dccd24e3a73bdbeaee6ecab4e905b7387313a4df01fd507a0dd0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6b8064f216a4dccd24e3a73bdbeaee6ecab4e905b7387313a4df01fd507a0dd0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6b8064f216a4dccd24e3a73bdbeaee6ecab4e905b7387313a4df01fd507a0dd0", kill_on_drop: false }` [INFO] [stdout] 6b8064f216a4dccd24e3a73bdbeaee6ecab4e905b7387313a4df01fd507a0dd0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1de1d39973293ec07ac38e2f990479ae3b693d1dbab07d4e00d655b8cc936ee2 [INFO] running `Command { std: "docker" "start" "-a" "1de1d39973293ec07ac38e2f990479ae3b693d1dbab07d4e00d655b8cc936ee2", kill_on_drop: false }` [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling bitflags v1.3.2 [INFO] [stderr] Compiling byteorder v1.5.0 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Compiling lazy_static v1.5.0 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking fixed-capacity-vec v1.0.1 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking hex-literal v0.4.1 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking memmap2 v0.5.10 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling dynasm v2.0.0 [INFO] [stderr] Checking dynasmrt v2.0.0 [INFO] [stderr] Checking hashx v0.1.5 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:217:12 [INFO] [stdout] | [INFO] [stdout] 216 | fn build_from_program(&self, program: Program, register_key: SipState) -> Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 217 | Ok(HashX { [INFO] [stdout] | ____________^ [INFO] [stdout] 218 | | register_key, [INFO] [stdout] 219 | | program: match self.runtime { [INFO] [stdout] 220 | | RuntimeOption::InterpretOnly => RuntimeProgram::Interpret(program), [INFO] [stdout] ... | [INFO] [stdout] 228 | | }, [INFO] [stdout] 229 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:217:12 [INFO] [stdout] | [INFO] [stdout] 216 | fn build_from_program(&self, program: Program, register_key: SipState) -> Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 217 | Ok(HashX { [INFO] [stdout] | ____________^ [INFO] [stdout] 218 | | register_key, [INFO] [stdout] 219 | | program: match self.runtime { [INFO] [stdout] 220 | | RuntimeOption::InterpretOnly => RuntimeProgram::Interpret(program), [INFO] [stdout] ... | [INFO] [stdout] 228 | | }, [INFO] [stdout] 229 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compiler/util.rs:79:12 [INFO] [stdout] | [INFO] [stdout] 76 | let mut mut_buf = MutableBuffer::new(self.buffer.len())?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | Ok(Executable { [INFO] [stdout] | ____________^ [INFO] [stdout] 80 | | buffer: mut_buf.make_exec()?, [INFO] [stdout] 81 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/err.rs:34:23 [INFO] [stdout] | [INFO] [stdout] 33 | fn from(err: std::io::Error) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | Self::Runtime(Arc::new(err)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hashx` (lib test) due to 5 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/program.rs:215:12 [INFO] [stdout] | [INFO] [stdout] 213 | let mut instructions = FixedCapacityVec::new(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 214 | Generator::new(rng).generate_program(&mut instructions)?; [INFO] [stdout] 215 | Ok(Program( [INFO] [stdout] | ____________^ [INFO] [stdout] 216 | | instructions [INFO] [stdout] 217 | | .try_into() [INFO] [stdout] 218 | | .map_err(|_| ()) [INFO] [stdout] 219 | | .expect("wrong length!"), [INFO] [stdout] 220 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hashx` (lib) due to 5 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compiler/util.rs:79:12 [INFO] [stdout] | [INFO] [stdout] 76 | let mut mut_buf = MutableBuffer::new(self.buffer.len())?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | Ok(Executable { [INFO] [stdout] | ____________^ [INFO] [stdout] 80 | | buffer: mut_buf.make_exec()?, [INFO] [stdout] 81 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/err.rs:34:23 [INFO] [stdout] | [INFO] [stdout] 33 | fn from(err: std::io::Error) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | Self::Runtime(Arc::new(err)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/program.rs:215:12 [INFO] [stdout] | [INFO] [stdout] 213 | let mut instructions = FixedCapacityVec::new(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 214 | Generator::new(rng).generate_program(&mut instructions)?; [INFO] [stdout] 215 | Ok(Program( [INFO] [stdout] | ____________^ [INFO] [stdout] 216 | | instructions [INFO] [stdout] 217 | | .try_into() [INFO] [stdout] 218 | | .map_err(|_| ()) [INFO] [stdout] 219 | | .expect("wrong length!"), [INFO] [stdout] 220 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "1de1d39973293ec07ac38e2f990479ae3b693d1dbab07d4e00d655b8cc936ee2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1de1d39973293ec07ac38e2f990479ae3b693d1dbab07d4e00d655b8cc936ee2", kill_on_drop: false }` [INFO] [stdout] 1de1d39973293ec07ac38e2f990479ae3b693d1dbab07d4e00d655b8cc936ee2