[INFO] cloning repository https://github.com/blargg/rust-tracer [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/blargg/rust-tracer" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fblargg%2Frust-tracer", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fblargg%2Frust-tracer'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] fc8ca0d165ea56691329d754117d178b5245dc28 [INFO] checking blargg/rust-tracer/fc8ca0d165ea56691329d754117d178b5245dc28 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fblargg%2Frust-tracer" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/blargg/rust-tracer on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/blargg/rust-tracer [INFO] finished tweaking git repo https://github.com/blargg/rust-tracer [INFO] tweaked toml for git repo https://github.com/blargg/rust-tracer written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/blargg/rust-tracer already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 52df6d994f0eedf201468fab6521ce85743e5941e2412a1227f1d0888e6d98fb [INFO] running `Command { std: "docker" "start" "-a" "52df6d994f0eedf201468fab6521ce85743e5941e2412a1227f1d0888e6d98fb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "52df6d994f0eedf201468fab6521ce85743e5941e2412a1227f1d0888e6d98fb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "52df6d994f0eedf201468fab6521ce85743e5941e2412a1227f1d0888e6d98fb", kill_on_drop: false }` [INFO] [stdout] 52df6d994f0eedf201468fab6521ce85743e5941e2412a1227f1d0888e6d98fb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 28e37c6c1205db04a5f488b8de121f4baf3a9733c5473241076cf29d168c0aaf [INFO] running `Command { std: "docker" "start" "-a" "28e37c6c1205db04a5f488b8de121f4baf3a9733c5473241076cf29d168c0aaf", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.6 [INFO] [stderr] Compiling libc v0.2.51 [INFO] [stderr] Checking rand_core v0.4.0 [INFO] [stderr] Compiling autocfg v0.1.2 [INFO] [stderr] Checking cfg-if v0.1.7 [INFO] [stderr] Compiling byteorder v1.3.1 [INFO] [stderr] Compiling arrayvec v0.4.10 [INFO] [stderr] Compiling num-integer v0.1.39 [INFO] [stderr] Compiling proc-macro2 v0.4.27 [INFO] [stderr] Checking lazy_static v1.3.0 [INFO] [stderr] Checking nodrop v0.1.13 [INFO] [stderr] Compiling rayon-core v1.4.1 [INFO] [stderr] Checking scopeguard v0.3.3 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Checking memoffset v0.2.1 [INFO] [stderr] Compiling num-complex v0.2.1 [INFO] [stderr] Checking crossbeam-utils v0.2.2 [INFO] [stderr] Compiling syn v0.15.32 [INFO] [stderr] Compiling num-iter v0.1.37 [INFO] [stderr] Compiling num-bigint v0.2.2 [INFO] [stderr] Compiling num-rational v0.2.1 [INFO] [stderr] Compiling typenum v1.10.0 [INFO] [stderr] Checking adler32 v1.0.3 [INFO] [stderr] Compiling rayon v1.0.3 [INFO] [stderr] Compiling num-derive v0.2.4 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_jitter v0.1.3 [INFO] [stderr] Checking bitflags v1.0.4 [INFO] [stderr] Checking lzw v0.10.0 [INFO] [stderr] Checking either v1.5.2 [INFO] [stderr] Checking inflate v0.4.5 [INFO] [stderr] Checking rawpointer v0.1.0 [INFO] [stderr] Checking remove_dir_all v0.5.1 [INFO] [stderr] Checking color_quant v1.0.1 [INFO] [stderr] Checking libm v0.1.2 [INFO] [stderr] Checking ucd-util v0.1.3 [INFO] [stderr] Checking quick-error v1.2.2 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Checking bit-vec v0.5.1 [INFO] [stderr] Checking matrixmultiply v0.2.2 [INFO] [stderr] Checking fnv v1.0.6 [INFO] [stderr] Checking regex-syntax v0.6.6 [INFO] [stderr] Checking obj v0.9.0 [INFO] [stderr] Checking gif v0.10.1 [INFO] [stderr] Checking deflate v0.7.19 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Checking bit-set v0.5.1 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking num_cpus v1.10.0 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking approx v0.3.2 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Compiling quote v0.6.12 [INFO] [stderr] Checking png v0.14.0 [INFO] [stderr] Checking generic-array v0.12.0 [INFO] [stderr] Checking alga v0.9.0 [INFO] [stderr] Checking tempfile v3.0.7 [INFO] [stderr] Checking nalgebra v0.18.0 [INFO] [stderr] Checking rusty-fork v0.2.2 [INFO] [stderr] Checking proptest v0.9.2 [INFO] [stderr] Checking num v0.2.0 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking tiff v0.2.2 [INFO] [stderr] Checking image v0.21.1 [INFO] [stderr] Checking rust-tracer v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: associated type `BSDF_fn` should have an upper camel case name [INFO] [stdout] --> src/render/material.rs:32:10 [INFO] [stdout] | [INFO] [stdout] 32 | type BSDF_fn; [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper camel case: `BsdfFn` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::plane::Plane` [INFO] [stdout] --> src/render/triangle.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use super::plane::Plane; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated type `BSDF_fn` should have an upper camel case name [INFO] [stdout] --> src/render/material.rs:32:10 [INFO] [stdout] | [INFO] [stdout] 32 | type BSDF_fn; [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper camel case: `BsdfFn` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/render/material.rs:87:33 [INFO] [stdout] | [INFO] [stdout] 87 | fn is_BSDF() {}; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/render/material.rs:93:41 [INFO] [stdout] | [INFO] [stdout] 93 | fn is_material() {}; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/render/ray.rs:75:54 [INFO] [stdout] | [INFO] [stdout] 75 | let r: Ray = Ray::new_normalize(v0, (point - v0)); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 75 - let r: Ray = Ray::new_normalize(v0, (point - v0)); [INFO] [stdout] 75 + let r: Ray = Ray::new_normalize(v0, point - v0); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::number::*` [INFO] [stdout] --> src/render/renderable.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | use crate::number::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/render/renderable.rs:56:45 [INFO] [stdout] | [INFO] [stdout] 56 | fn is_renderable() {}; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/render/renderable.rs:61:41 [INFO] [stdout] | [INFO] [stdout] 61 | fn is_material() {}; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/render/sphere.rs:90:11 [INFO] [stdout] | [INFO] [stdout] 90 | };; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `EPSILON_64` is never used [INFO] [stdout] --> src/number.rs:1:11 [INFO] [stdout] | [INFO] [stdout] 1 | pub const EPSILON_64: f64 = 0.00001; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Plane` is never constructed [INFO] [stdout] --> src/render/plane.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct Plane { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/render/plane.rs:9:12 [INFO] [stdout] | [INFO] [stdout] 8 | impl Plane { [INFO] [stdout] | ------------------------ associated function in this implementation [INFO] [stdout] 9 | pub fn new(normal: Vector3, dist: T) -> Plane { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new_at_point` and `distance_to` are never used [INFO] [stdout] --> src/render/plane.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 14 | impl Plane { [INFO] [stdout] | --------------------------- associated items in this implementation [INFO] [stdout] 15 | pub fn new_at_point(position: Point3, normal: Vector3) -> Plane { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 19 | pub fn distance_to(&self, point: Point3) -> T { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/render/ray.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 10 | impl Ray { [INFO] [stdout] | ---------------------- associated function in this implementation [INFO] [stdout] 11 | pub fn new(origin: Point3, direction: UnitVec3) -> Ray { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `closest_point` is never used [INFO] [stdout] --> src/render/ray.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 16 | impl Ray { [INFO] [stdout] | ------------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 24 | pub fn closest_point(&self, p: Point3) -> Point3 { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `Renderable` is never used [INFO] [stdout] --> src/render/renderable.rs:8:11 [INFO] [stdout] | [INFO] [stdout] 8 | pub trait Renderable: Shape + Material::NumTy> { } [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `position` and `normal` are never read [INFO] [stdout] --> src/render/shape.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 20 | pub struct DiffGeom { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] 21 | position: Point3, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 22 | normal: Vector3, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/render/sphere.rs:14:12 [INFO] [stdout] | [INFO] [stdout] 13 | impl Sphere { [INFO] [stdout] | --------------------------------------------- associated function in this implementation [INFO] [stdout] 14 | pub fn new(center: Point3, radius: T) -> Sphere { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render/material.rs:45:20 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn new(red: T, green: T, blue: T) -> Lambert { [INFO] [stdout] | ------ -------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | Lambert { [INFO] [stdout] 45 | color: Spec::new(red, green, blue), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render/spectrum.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 27 | fn mul(self, rhs: Spec) -> Spec { [INFO] [stdout] | ---- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | Spec::new( [INFO] [stdout] 29 | self.red * rhs.red, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render/spectrum.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 27 | fn mul(self, rhs: Spec) -> Spec { [INFO] [stdout] | ---- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | self.green * rhs.green, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render/spectrum.rs:31:13 [INFO] [stdout] | [INFO] [stdout] 27 | fn mul(self, rhs: Spec) -> Spec { [INFO] [stdout] | ---- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | self.blue * rhs.blue, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust-tracer` (bin "rust-tracer") due to 5 previous errors; 11 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: constant `EPSILON_64` is never used [INFO] [stdout] --> src/number.rs:1:11 [INFO] [stdout] | [INFO] [stdout] 1 | pub const EPSILON_64: f64 = 0.00001; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `lambert_is_BSDF` is never used [INFO] [stdout] --> src/render/material.rs:86:8 [INFO] [stdout] | [INFO] [stdout] 86 | fn lambert_is_BSDF() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `uniform_is_material` is never used [INFO] [stdout] --> src/render/material.rs:92:8 [INFO] [stdout] | [INFO] [stdout] 92 | fn uniform_is_material() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/render/ray.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 10 | impl Ray { [INFO] [stdout] | ---------------------- associated function in this implementation [INFO] [stdout] 11 | pub fn new(origin: Point3, direction: UnitVec3) -> Ray { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `Renderable` is never used [INFO] [stdout] --> src/render/renderable.rs:8:11 [INFO] [stdout] | [INFO] [stdout] 8 | pub trait Renderable: Shape + Material::NumTy> { } [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `shapemat_is_renderable` is never used [INFO] [stdout] --> src/render/renderable.rs:55:8 [INFO] [stdout] | [INFO] [stdout] 55 | fn shapemat_is_renderable() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `uniform_is_material` is never used [INFO] [stdout] --> src/render/renderable.rs:60:8 [INFO] [stdout] | [INFO] [stdout] 60 | fn uniform_is_material() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `position` and `normal` are never read [INFO] [stdout] --> src/render/shape.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 20 | pub struct DiffGeom { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] 21 | position: Point3, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 22 | normal: Vector3, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `arb_tri` is never used [INFO] [stdout] --> src/render/triangle.rs:81:12 [INFO] [stdout] | [INFO] [stdout] 81 | pub fn arb_tri( [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render/material.rs:45:20 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn new(red: T, green: T, blue: T) -> Lambert { [INFO] [stdout] | ------ -------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | Lambert { [INFO] [stdout] 45 | color: Spec::new(red, green, blue), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `lambert_is_BSDF` should have a snake case name [INFO] [stdout] --> src/render/material.rs:86:8 [INFO] [stdout] | [INFO] [stdout] 86 | fn lambert_is_BSDF() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `lambert_is_bsdf` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `is_BSDF` should have a snake case name [INFO] [stdout] --> src/render/material.rs:87:12 [INFO] [stdout] | [INFO] [stdout] 87 | fn is_BSDF() {}; [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `is_bsdf` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render/ray.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 46 | s: impl Strategy + Clone, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | (s.clone(), s.clone(), s.clone()).prop_map(|(x, y, z)| Vector3::new(x, y, z)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render/ray.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn arb_point(st: impl Strategy + Clone) -> impl Strategy> [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | st_vec3(st).prop_map(Point3::from) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render/ray.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 62 | orig_st: impl Strategy + Clone, [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | dir_st: impl Strategy + Clone, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | (arb_point(orig_st), st_vec3(dir_st)).prop_map(|(o, d)| Ray::new_normalize(o, d)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render/spectrum.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 27 | fn mul(self, rhs: Spec) -> Spec { [INFO] [stdout] | ---- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | Spec::new( [INFO] [stdout] 29 | self.red * rhs.red, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render/spectrum.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 27 | fn mul(self, rhs: Spec) -> Spec { [INFO] [stdout] | ---- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | self.green * rhs.green, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render/spectrum.rs:31:13 [INFO] [stdout] | [INFO] [stdout] 27 | fn mul(self, rhs: Spec) -> Spec { [INFO] [stdout] | ---- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | self.blue * rhs.blue, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render/sphere.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 76 | c: impl Strategy + Clone, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | r: impl Strategy + Clone, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | (arb_point(c.clone()), r.clone()).prop_map(|(cnt, rad)| Sphere::new(cnt, rad)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render/triangle.rs:87:9 [INFO] [stdout] | [INFO] [stdout] 82 | s: impl Strategy + Clone, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | (st_vec3(s.clone()), st_vec3(s.clone()), st_vec3(s.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 19 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust-tracer` (bin "rust-tracer" test) due to 10 previous errors; 19 warnings emitted [INFO] running `Command { std: "docker" "inspect" "28e37c6c1205db04a5f488b8de121f4baf3a9733c5473241076cf29d168c0aaf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "28e37c6c1205db04a5f488b8de121f4baf3a9733c5473241076cf29d168c0aaf", kill_on_drop: false }` [INFO] [stdout] 28e37c6c1205db04a5f488b8de121f4baf3a9733c5473241076cf29d168c0aaf