[INFO] cloning repository https://github.com/bl0rk/rust_learning [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/bl0rk/rust_learning" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbl0rk%2Frust_learning", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbl0rk%2Frust_learning'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3fdd98539f4c1f4c2302300e11a5f729495ac77f [INFO] checking bl0rk/rust_learning/3fdd98539f4c1f4c2302300e11a5f729495ac77f against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbl0rk%2Frust_learning" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/bl0rk/rust_learning on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/bl0rk/rust_learning [INFO] finished tweaking git repo https://github.com/bl0rk/rust_learning [INFO] tweaked toml for git repo https://github.com/bl0rk/rust_learning written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/bl0rk/rust_learning already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6dc27347fb4ecd1f340e077539d8015564f0201e6fdf87c80440edcfe069be7d [INFO] running `Command { std: "docker" "start" "-a" "6dc27347fb4ecd1f340e077539d8015564f0201e6fdf87c80440edcfe069be7d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6dc27347fb4ecd1f340e077539d8015564f0201e6fdf87c80440edcfe069be7d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6dc27347fb4ecd1f340e077539d8015564f0201e6fdf87c80440edcfe069be7d", kill_on_drop: false }` [INFO] [stdout] 6dc27347fb4ecd1f340e077539d8015564f0201e6fdf87c80440edcfe069be7d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8bfafbb48f96fed4f749d1116c6ca6860851e8293daeda459246309cd30bf759 [INFO] running `Command { std: "docker" "start" "-a" "8bfafbb48f96fed4f749d1116c6ca6860851e8293daeda459246309cd30bf759", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.142 [INFO] [stderr] Checking getrandom v0.2.9 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking general_testing v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linked_lists/persistent_stack.rs:21:19 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn prepend(&self, elem: T) -> List { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | List { [INFO] [stdout] 21 | head: Some(Rc::new(Node { [INFO] [stdout] | ___________________^ [INFO] [stdout] 22 | | elem, [INFO] [stdout] 23 | | next: self.head.clone() [INFO] [stdout] 24 | | })) [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linked_lists/bad_safe_double_linked_deque.rs:21:17 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn new(elem: T) -> Rc> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | Rc::new(RefCell::new(Node { [INFO] [stdout] | _________________^ [INFO] [stdout] 22 | | elem, [INFO] [stdout] 23 | | prev: None, [INFO] [stdout] 24 | | next: None [INFO] [stdout] 25 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linked_lists/bad_safe_double_linked_deque.rs:40:15 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn push_front(&mut self, elem: T) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | // Initialise a new head (a Rc>>). [INFO] [stdout] 36 | let new_head = Node::new(elem); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | match self.head.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linked_lists/bad_safe_double_linked_deque.rs:92:13 [INFO] [stdout] | [INFO] [stdout] 65 | self.head.take().map(|old_head| { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | Rc::try_unwrap(old_head).ok().unwrap().into_inner().elem [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `general_testing` (bin "general_testing") due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linked_lists/persistent_stack.rs:21:19 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn prepend(&self, elem: T) -> List { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | List { [INFO] [stdout] 21 | head: Some(Rc::new(Node { [INFO] [stdout] | ___________________^ [INFO] [stdout] 22 | | elem, [INFO] [stdout] 23 | | next: self.head.clone() [INFO] [stdout] 24 | | })) [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linked_lists/bad_safe_double_linked_deque.rs:21:17 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn new(elem: T) -> Rc> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | Rc::new(RefCell::new(Node { [INFO] [stdout] | _________________^ [INFO] [stdout] 22 | | elem, [INFO] [stdout] 23 | | prev: None, [INFO] [stdout] 24 | | next: None [INFO] [stdout] 25 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linked_lists/bad_safe_double_linked_deque.rs:40:15 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn push_front(&mut self, elem: T) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | // Initialise a new head (a Rc>>). [INFO] [stdout] 36 | let new_head = Node::new(elem); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | match self.head.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linked_lists/bad_safe_double_linked_deque.rs:92:13 [INFO] [stdout] | [INFO] [stdout] 65 | self.head.take().map(|old_head| { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | Rc::try_unwrap(old_head).ok().unwrap().into_inner().elem [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `general_testing` (bin "general_testing" test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "8bfafbb48f96fed4f749d1116c6ca6860851e8293daeda459246309cd30bf759", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8bfafbb48f96fed4f749d1116c6ca6860851e8293daeda459246309cd30bf759", kill_on_drop: false }` [INFO] [stdout] 8bfafbb48f96fed4f749d1116c6ca6860851e8293daeda459246309cd30bf759