[INFO] cloning repository https://github.com/bjmoore/rs-httpd [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/bjmoore/rs-httpd" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbjmoore%2Frs-httpd", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbjmoore%2Frs-httpd'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 14293258b40b5d168105d4361268659af4359f88 [INFO] checking bjmoore/rs-httpd/14293258b40b5d168105d4361268659af4359f88 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbjmoore%2Frs-httpd" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/bjmoore/rs-httpd on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/bjmoore/rs-httpd [INFO] finished tweaking git repo https://github.com/bjmoore/rs-httpd [INFO] tweaked toml for git repo https://github.com/bjmoore/rs-httpd written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/bjmoore/rs-httpd already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a9236dff18c5d295914c374100b2ba4e63adc652e99b57e0a4de0eb62794ad9d [INFO] running `Command { std: "docker" "start" "-a" "a9236dff18c5d295914c374100b2ba4e63adc652e99b57e0a4de0eb62794ad9d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a9236dff18c5d295914c374100b2ba4e63adc652e99b57e0a4de0eb62794ad9d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a9236dff18c5d295914c374100b2ba4e63adc652e99b57e0a4de0eb62794ad9d", kill_on_drop: false }` [INFO] [stdout] a9236dff18c5d295914c374100b2ba4e63adc652e99b57e0a4de0eb62794ad9d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7b38269384ff25b78f8d2d30ae428d2cb0c905d8d3243771989ab6bf49878dc7 [INFO] running `Command { std: "docker" "start" "-a" "7b38269384ff25b78f8d2d30ae428d2cb0c905d8d3243771989ab6bf49878dc7", kill_on_drop: false }` [INFO] [stderr] Checking rs-httpd v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/main.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 29 | / loop { [INFO] [stdout] 30 | | for stream in listener.incoming() { [INFO] [stdout] 31 | | // these should be spun off into a thread ig [INFO] [stdout] 32 | | handle_client(stream?)?; [INFO] [stdout] 33 | | } [INFO] [stdout] 34 | | } [INFO] [stdout] | |_____- any code following this expression is unreachable [INFO] [stdout] 35 | [INFO] [stdout] 36 | Ok(()) [INFO] [stdout] | ^^^^^^ unreachable expression [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/main.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 29 | / loop { [INFO] [stdout] 30 | | for stream in listener.incoming() { [INFO] [stdout] 31 | | // these should be spun off into a thread ig [INFO] [stdout] 32 | | handle_client(stream?)?; [INFO] [stdout] 33 | | } [INFO] [stdout] 34 | | } [INFO] [stdout] | |_____- any code following this expression is unreachable [INFO] [stdout] 35 | [INFO] [stdout] 36 | Ok(()) [INFO] [stdout] | ^^^^^^ unreachable expression [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `POST` and `HEAD` are never constructed [INFO] [stdout] --> src/request.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 4 | pub enum HttpMethod { [INFO] [stdout] | ---------- variants in this enum [INFO] [stdout] 5 | GET, [INFO] [stdout] 6 | POST, [INFO] [stdout] | ^^^^ [INFO] [stdout] 7 | HEAD, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `HttpMethod` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `method` and `target` are never read [INFO] [stdout] --> src/request.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct HttpRequest { [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] 12 | pub method: HttpMethod, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 13 | pub target: String, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `HttpRequest` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | conn.send_response(response); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 22 | let _ = conn.send_response(response); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:19:21 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn new(socket: TcpStream) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | Self { [INFO] [stdout] 19 | socket: BufReader::new(socket), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `POST` and `HEAD` are never constructed [INFO] [stdout] --> src/request.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 4 | pub enum HttpMethod { [INFO] [stdout] | ---------- variants in this enum [INFO] [stdout] 5 | GET, [INFO] [stdout] 6 | POST, [INFO] [stdout] | ^^^^ [INFO] [stdout] 7 | HEAD, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `HttpMethod` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `method` and `target` are never read [INFO] [stdout] --> src/request.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct HttpRequest { [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] 12 | pub method: HttpMethod, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 13 | pub target: String, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `HttpRequest` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | conn.send_response(response); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 22 | let _ = conn.send_response(response); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:19:21 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn new(socket: TcpStream) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | Self { [INFO] [stdout] 19 | socket: BufReader::new(socket), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rs-httpd` (bin "rs-httpd") due to 2 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `rs-httpd` (bin "rs-httpd" test) due to 2 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "7b38269384ff25b78f8d2d30ae428d2cb0c905d8d3243771989ab6bf49878dc7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7b38269384ff25b78f8d2d30ae428d2cb0c905d8d3243771989ab6bf49878dc7", kill_on_drop: false }` [INFO] [stdout] 7b38269384ff25b78f8d2d30ae428d2cb0c905d8d3243771989ab6bf49878dc7