[INFO] cloning repository https://github.com/bitcrshr/rcon-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/bitcrshr/rcon-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbitcrshr%2Frcon-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbitcrshr%2Frcon-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9e8f3e054c63a7f51be17c47ff273d2cae955292 [INFO] checking bitcrshr/rcon-rs/9e8f3e054c63a7f51be17c47ff273d2cae955292 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbitcrshr%2Frcon-rs" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/bitcrshr/rcon-rs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/bitcrshr/rcon-rs [INFO] finished tweaking git repo https://github.com/bitcrshr/rcon-rs [INFO] tweaked toml for git repo https://github.com/bitcrshr/rcon-rs written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/bitcrshr/rcon-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d7c03a0e072b68342ebcd5e9014831c250ae77d8e3268dd9ebbb4c31fb9cc322 [INFO] running `Command { std: "docker" "start" "-a" "d7c03a0e072b68342ebcd5e9014831c250ae77d8e3268dd9ebbb4c31fb9cc322", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d7c03a0e072b68342ebcd5e9014831c250ae77d8e3268dd9ebbb4c31fb9cc322", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d7c03a0e072b68342ebcd5e9014831c250ae77d8e3268dd9ebbb4c31fb9cc322", kill_on_drop: false }` [INFO] [stdout] d7c03a0e072b68342ebcd5e9014831c250ae77d8e3268dd9ebbb4c31fb9cc322 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a7e5233a047c7d6d149cb9cdb92a37159db0717dd10806b58f3d19dbb108e8a2 [INFO] running `Command { std: "docker" "start" "-a" "a7e5233a047c7d6d149cb9cdb92a37159db0717dd10806b58f3d19dbb108e8a2", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.152 [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Checking smallvec v1.13.1 [INFO] [stderr] Compiling thiserror v1.0.56 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking parking_lot_core v0.9.9 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking scheduled-thread-pool v0.2.7 [INFO] [stderr] Checking r2d2 v0.8.10 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling thiserror-impl v1.0.56 [INFO] [stderr] Compiling strum_macros v0.25.3 [INFO] [stderr] Checking strum v0.25.0 [INFO] [stderr] Checking rcon-rs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: constant `MAX_PACKET_SIZE` is never used [INFO] [stdout] --> src/packet.rs:26:11 [INFO] [stdout] | [INFO] [stdout] 26 | pub const MAX_PACKET_SIZE: i32 = 4096 + MIN_PACKET_SIZE; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `get_size` and `get_type` are never used [INFO] [stdout] --> src/packet.rs:91:12 [INFO] [stdout] | [INFO] [stdout] 36 | impl Packet { [INFO] [stdout] | ----------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 91 | pub fn get_size(&self) -> i32 { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 99 | pub fn get_type(&self) -> PacketType { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/packet.rs:132:13 [INFO] [stdout] | [INFO] [stdout] 132 | let mut actual_bytes: Vec = vec![ [INFO] [stdout] | ----^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `MAX_PACKET_SIZE` is never used [INFO] [stdout] --> src/packet.rs:26:11 [INFO] [stdout] | [INFO] [stdout] 26 | pub const MAX_PACKET_SIZE: i32 = 4096 + MIN_PACKET_SIZE; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `get_size` and `get_type` are never used [INFO] [stdout] --> src/packet.rs:91:12 [INFO] [stdout] | [INFO] [stdout] 36 | impl Packet { [INFO] [stdout] | ----------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 91 | pub fn get_size(&self) -> i32 { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 99 | pub fn get_type(&self) -> PacketType { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/conn.rs:234:15 [INFO] [stdout] | [INFO] [stdout] 232 | let mut conn = RCONStream::dial(&addr, &password).expect("must connect"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 233 | [INFO] [stdout] 234 | match conn.execute("ping") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rcon-rs` (lib test) due to 2 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "a7e5233a047c7d6d149cb9cdb92a37159db0717dd10806b58f3d19dbb108e8a2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a7e5233a047c7d6d149cb9cdb92a37159db0717dd10806b58f3d19dbb108e8a2", kill_on_drop: false }` [INFO] [stdout] a7e5233a047c7d6d149cb9cdb92a37159db0717dd10806b58f3d19dbb108e8a2