[INFO] cloning repository https://github.com/binier/payments-engine-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/binier/payments-engine-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbinier%2Fpayments-engine-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbinier%2Fpayments-engine-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 0c30b0595a83a57d6f72fb38f814a7cacc8effa8 [INFO] checking binier/payments-engine-rs/0c30b0595a83a57d6f72fb38f814a7cacc8effa8 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbinier%2Fpayments-engine-rs" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/binier/payments-engine-rs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/binier/payments-engine-rs [INFO] finished tweaking git repo https://github.com/binier/payments-engine-rs [INFO] tweaked toml for git repo https://github.com/binier/payments-engine-rs written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/binier/payments-engine-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1ab292c81cbcb2b35f4a75807b542de186371ffe9d90cf20f55018ccb3260e34 [INFO] running `Command { std: "docker" "start" "-a" "1ab292c81cbcb2b35f4a75807b542de186371ffe9d90cf20f55018ccb3260e34", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1ab292c81cbcb2b35f4a75807b542de186371ffe9d90cf20f55018ccb3260e34", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1ab292c81cbcb2b35f4a75807b542de186371ffe9d90cf20f55018ccb3260e34", kill_on_drop: false }` [INFO] [stdout] 1ab292c81cbcb2b35f4a75807b542de186371ffe9d90cf20f55018ccb3260e34 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 90c584a6b634da28225035de9356f9874eb673158151763339dc9cd7f9b78c9f [INFO] running `Command { std: "docker" "start" "-a" "90c584a6b634da28225035de9356f9874eb673158151763339dc9cd7f9b78c9f", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling syn v1.0.48 [INFO] [stderr] Compiling serde_derive v1.0.117 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling libc v0.2.80 [INFO] [stderr] Compiling serde v1.0.117 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling const_fn v0.4.3 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking itoa v0.4.6 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling crossbeam-utils v0.8.0 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking regex-automata v0.1.9 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Checking crossbeam-channel v0.5.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking bstr v0.2.14 [INFO] [stderr] Checking rust_decimal v1.8.1 [INFO] [stderr] Checking csv v1.1.4 [INFO] [stderr] Checking payments-engine-rs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bank.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 26 | fn from_input_transactions_csv(reader: R) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | Self::from_input_transactions( [INFO] [stdout] 28 | / csv::Reader::from_reader(reader) [INFO] [stdout] 29 | | .deserialize::() [INFO] [stdout] 30 | | .filter_map(Result::ok) [INFO] [stdout] | |_______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/concurrent_bank.rs:27:21 [INFO] [stdout] | [INFO] [stdout] 16 | let (sender, rx) = crossbeam_channel::unbounded(); [INFO] [stdout] | ------ -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let thread = thread::spawn(move || { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | sender: Some(sender), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/concurrent_bank.rs:28:21 [INFO] [stdout] | [INFO] [stdout] 16 | let (sender, rx) = crossbeam_channel::unbounded(); [INFO] [stdout] | ------ -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let thread = thread::spawn(move || { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | thread: Some(thread), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/concurrent_bank.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 117 | fn into_inner_banks(self) -> impl Iterator { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | self.threads.into_iter() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `payments-engine-rs` (bin "payments-engine-rs") due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/output_account.rs:32:27 [INFO] [stdout] | [INFO] [stdout] 26 | fn serialize_to_string, T: Serialize>(it: I) -> String { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | let mut wtr = csv::Writer::from_writer(vec![]); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | String::from_utf8(wtr.into_inner().unwrap()).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/output_account.rs:29:37 [INFO] [stdout] | [INFO] [stdout] 29 | it.into_iter().for_each(|v| wtr.serialize(v).unwrap()); [INFO] [stdout] | - ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bank.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 26 | fn from_input_transactions_csv(reader: R) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | Self::from_input_transactions( [INFO] [stdout] 28 | / csv::Reader::from_reader(reader) [INFO] [stdout] 29 | | .deserialize::() [INFO] [stdout] 30 | | .filter_map(Result::ok) [INFO] [stdout] | |_______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/concurrent_bank.rs:27:21 [INFO] [stdout] | [INFO] [stdout] 16 | let (sender, rx) = crossbeam_channel::unbounded(); [INFO] [stdout] | ------ -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let thread = thread::spawn(move || { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | sender: Some(sender), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `payments-engine-rs` (bin "payments-engine-rs" test) due to 7 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/concurrent_bank.rs:28:21 [INFO] [stdout] | [INFO] [stdout] 16 | let (sender, rx) = crossbeam_channel::unbounded(); [INFO] [stdout] | ------ -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let thread = thread::spawn(move || { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | thread: Some(thread), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/concurrent_bank.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 117 | fn into_inner_banks(self) -> impl Iterator { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | self.threads.into_iter() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "90c584a6b634da28225035de9356f9874eb673158151763339dc9cd7f9b78c9f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "90c584a6b634da28225035de9356f9874eb673158151763339dc9cd7f9b78c9f", kill_on_drop: false }` [INFO] [stdout] 90c584a6b634da28225035de9356f9874eb673158151763339dc9cd7f9b78c9f