[INFO] cloning repository https://github.com/bidoubiwa/jsonboat [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/bidoubiwa/jsonboat" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbidoubiwa%2Fjsonboat", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbidoubiwa%2Fjsonboat'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8c6a2990350f9178134bd9c748cbd88674166014 [INFO] checking bidoubiwa/jsonboat/8c6a2990350f9178134bd9c748cbd88674166014 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbidoubiwa%2Fjsonboat" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/bidoubiwa/jsonboat on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/bidoubiwa/jsonboat [INFO] finished tweaking git repo https://github.com/bidoubiwa/jsonboat [INFO] tweaked toml for git repo https://github.com/bidoubiwa/jsonboat written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/bidoubiwa/jsonboat already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f7c6fcd30a53153eaa19a86c45cdfd428c0564c994bfdc181823664cc1f4743c [INFO] running `Command { std: "docker" "start" "-a" "f7c6fcd30a53153eaa19a86c45cdfd428c0564c994bfdc181823664cc1f4743c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f7c6fcd30a53153eaa19a86c45cdfd428c0564c994bfdc181823664cc1f4743c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f7c6fcd30a53153eaa19a86c45cdfd428c0564c994bfdc181823664cc1f4743c", kill_on_drop: false }` [INFO] [stdout] f7c6fcd30a53153eaa19a86c45cdfd428c0564c994bfdc181823664cc1f4743c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7e96b8a1d99406d55cce0ce976f0ec59629cd6aac13f929c4aed763a887c582b [INFO] running `Command { std: "docker" "start" "-a" "7e96b8a1d99406d55cce0ce976f0ec59629cd6aac13f929c4aed763a887c582b", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.125 [INFO] [stderr] Compiling crossbeam-utils v0.8.8 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling crossbeam-epoch v0.9.8 [INFO] [stderr] Compiling rayon-core v1.9.2 [INFO] [stderr] Compiling rayon v1.5.2 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Compiling serde v1.0.137 [INFO] [stderr] Checking numtoa v0.1.0 [INFO] [stderr] Compiling serde_json v1.0.80 [INFO] [stderr] Checking turbo-json-checker v2.0.1 [INFO] [stderr] Checking itoa v1.0.1 [INFO] [stderr] Checking ryu v1.0.9 [INFO] [stderr] Checking crossbeam-channel v0.5.4 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking terminal_size v0.1.17 [INFO] [stderr] Checking termion v1.5.6 [INFO] [stderr] Checking regex v1.5.5 [INFO] [stderr] Checking console v0.15.0 [INFO] [stderr] Checking indicatif v0.17.0-rc.10 [INFO] [stderr] Checking turbo-json v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `serde_json::json` [INFO] [stdout] --> tests/combine.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use serde_json::json; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `turbo_json_checker::*` [INFO] [stdout] --> tests/combine.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use turbo_json_checker::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `json_paths` [INFO] [stdout] --> tests/combine.rs:15:13 [INFO] [stdout] | [INFO] [stdout] 15 | let mut json_paths = ["./misc/empty.json", "./misc/hello.json"]; [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_json_paths` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `output` [INFO] [stdout] --> tests/combine.rs:16:13 [INFO] [stdout] | [INFO] [stdout] 16 | let mut output = String::new(); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_output` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/combine.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | let mut json_paths = ["./misc/empty.json", "./misc/hello.json"]; [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/combine.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | let mut output = String::new(); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/validator.rs:17:8 [INFO] [stdout] | [INFO] [stdout] 12 | mut reader: impl Read + Seek, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 17 | Ok(reader.take(end - start)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/validator.rs:49:8 [INFO] [stdout] | [INFO] [stdout] 21 | reader: impl Read + Seek, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | let mut trimmed_reader = trim_reader_to_content(reader, start, end)?; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | Ok(Some(Cursor::new(c.clone()).chain(trimmed_reader))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/validator.rs:65:5 [INFO] [stdout] | [INFO] [stdout] 56 | let files_validator_progress_bar = ProgressBar::new(number_of_files); [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | / files_path [INFO] [stdout] 66 | | .par_iter() // Method from Rayon crate [INFO] [stdout] 67 | | .progress_with(files_validator_progress_bar) [INFO] [stdout] 68 | | .map(|&file_path| { [INFO] [stdout] ... | [INFO] [stdout] 103 | | } [INFO] [stdout] 104 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/validator.rs:78:19 [INFO] [stdout] | [INFO] [stdout] 69 | let file = match File::open(file_path) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | Ok(file) => file, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | Err(error) => { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | match turbo_json_checker::validate(&file) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/validator.rs:82:56 [INFO] [stdout] | [INFO] [stdout] 82 | ... cursor_option.map(|reader| Box::new(reader) as Box) [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `turbo-json` (bin "turbo-json") due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/validator.rs:17:8 [INFO] [stdout] | [INFO] [stdout] 12 | mut reader: impl Read + Seek, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 17 | Ok(reader.take(end - start)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/validator.rs:49:8 [INFO] [stdout] | [INFO] [stdout] 21 | reader: impl Read + Seek, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | let mut trimmed_reader = trim_reader_to_content(reader, start, end)?; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | Ok(Some(Cursor::new(c.clone()).chain(trimmed_reader))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/validator.rs:65:5 [INFO] [stdout] | [INFO] [stdout] 56 | let files_validator_progress_bar = ProgressBar::new(number_of_files); [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | / files_path [INFO] [stdout] 66 | | .par_iter() // Method from Rayon crate [INFO] [stdout] 67 | | .progress_with(files_validator_progress_bar) [INFO] [stdout] 68 | | .map(|&file_path| { [INFO] [stdout] ... | [INFO] [stdout] 103 | | } [INFO] [stdout] 104 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/validator.rs:78:19 [INFO] [stdout] | [INFO] [stdout] 69 | let file = match File::open(file_path) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | Ok(file) => file, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | Err(error) => { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | match turbo_json_checker::validate(&file) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/validator.rs:82:56 [INFO] [stdout] | [INFO] [stdout] 82 | ... cursor_option.map(|reader| Box::new(reader) as Box) [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `turbo-json` (bin "turbo-json" test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "7e96b8a1d99406d55cce0ce976f0ec59629cd6aac13f929c4aed763a887c582b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7e96b8a1d99406d55cce0ce976f0ec59629cd6aac13f929c4aed763a887c582b", kill_on_drop: false }` [INFO] [stdout] 7e96b8a1d99406d55cce0ce976f0ec59629cd6aac13f929c4aed763a887c582b