[INFO] cloning repository https://github.com/bgermann/offwall [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/bgermann/offwall" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbgermann%2Foffwall", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbgermann%2Foffwall'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 6e0bf7b883dcd41f50166564b31b4c36fa7936d9 [INFO] checking bgermann/offwall/6e0bf7b883dcd41f50166564b31b4c36fa7936d9 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbgermann%2Foffwall" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/bgermann/offwall on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/bgermann/offwall [INFO] finished tweaking git repo https://github.com/bgermann/offwall [INFO] tweaked toml for git repo https://github.com/bgermann/offwall written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/bgermann/offwall already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 90049bba173112b1c8b49adf954b7d66716db9e2cb810bfcd8a346aa812ae19f [INFO] running `Command { std: "docker" "start" "-a" "90049bba173112b1c8b49adf954b7d66716db9e2cb810bfcd8a346aa812ae19f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "90049bba173112b1c8b49adf954b7d66716db9e2cb810bfcd8a346aa812ae19f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "90049bba173112b1c8b49adf954b7d66716db9e2cb810bfcd8a346aa812ae19f", kill_on_drop: false }` [INFO] [stdout] 90049bba173112b1c8b49adf954b7d66716db9e2cb810bfcd8a346aa812ae19f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2f8c38e2cc7af5a883f21b114e5db9046444e4117233462de59c201d8fe6e7cc [INFO] running `Command { std: "docker" "start" "-a" "2f8c38e2cc7af5a883f21b114e5db9046444e4117233462de59c201d8fe6e7cc", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling libc v0.2.51 [INFO] [stderr] Compiling autocfg v0.1.2 [INFO] [stderr] Checking cfg-if v0.1.7 [INFO] [stderr] Checking rand_core v0.4.0 [INFO] [stderr] Compiling cc v1.0.34 [INFO] [stderr] Compiling num-traits v0.2.6 [INFO] [stderr] Compiling num-integer v0.1.39 [INFO] [stderr] Compiling serde v1.0.90 [INFO] [stderr] Checking log v0.4.6 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking lazycell v1.2.1 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Checking rustc-demangle v0.1.13 [INFO] [stderr] Checking bitflags v1.0.4 [INFO] [stderr] Compiling backtrace v0.3.14 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking unicode-width v0.1.5 [INFO] [stderr] Checking same-file v1.0.4 [INFO] [stderr] Compiling byteorder v1.3.1 [INFO] [stderr] Checking textwrap v0.10.0 [INFO] [stderr] Checking walkdir v2.2.7 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_jitter v0.1.3 [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Checking tls-api v0.1.20 [INFO] [stderr] Checking log-panics v2.0.0 [INFO] [stderr] Checking rust-ini v0.13.0 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking iovec v0.1.2 [INFO] [stderr] Compiling backtrace-sys v0.1.28 [INFO] [stderr] Checking inotify-sys v0.1.3 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking inotify v0.6.1 [INFO] [stderr] Checking filetime v0.2.4 [INFO] [stderr] Checking mio v0.6.16 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking mio-extras v2.0.5 [INFO] [stderr] Checking notify v4.0.10 [INFO] [stderr] Checking simple_logger v1.0.1 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking syslog v4.0.1 [INFO] [stderr] Checking ipnetwork v0.14.0 [INFO] [stderr] Checking offwall v1.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::fs::File` [INFO] [stdout] --> src/conf.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | use std::fs::File; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Read` [INFO] [stdout] --> src/conf.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 44 | use std::io::Read; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `tls_api` [INFO] [stdout] --> src/conf.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 51 | use tls_api; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `tls_api::TlsAcceptorBuilder` [INFO] [stdout] --> src/conf.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | use tls_api::TlsAcceptorBuilder; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fs::File` [INFO] [stdout] --> src/conf.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | use std::fs::File; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Read` [INFO] [stdout] --> src/conf.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 44 | use std::io::Read; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `tls_api` [INFO] [stdout] --> src/conf.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 51 | use tls_api; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `tls_api::TlsAcceptorBuilder` [INFO] [stdout] --> src/conf.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | use tls_api::TlsAcceptorBuilder; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/conf.rs:252:21 [INFO] [stdout] | [INFO] [stdout] 252 | let mut conn = OfConnection::from_str(uri)?; [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/conf.rs:252:21 [INFO] [stdout] | [INFO] [stdout] 252 | let mut conn = OfConnection::from_str(uri)?; [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `P12_KEY` is never used [INFO] [stdout] --> src/conf.rs:65:7 [INFO] [stdout] | [INFO] [stdout] 65 | const P12_KEY: &str = "pkcs12"; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `PASS_KEY` is never used [INFO] [stdout] --> src/conf.rs:66:7 [INFO] [stdout] | [INFO] [stdout] 66 | const PASS_KEY: &str = "passwd"; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `proto` and `pkcs12` are never read [INFO] [stdout] --> src/conf.rs:218:5 [INFO] [stdout] | [INFO] [stdout] 217 | pub struct OfConnection { [INFO] [stdout] | ------------ fields in this struct [INFO] [stdout] 218 | proto: ConnectionProtocol, [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 222 | pkcs12: Option<(Vec, String)>, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `OfConnection` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Tls` is never constructed [INFO] [stdout] --> src/openflow/mod.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 45 | enum Stream { [INFO] [stdout] | ------ variant in this enum [INFO] [stdout] 46 | Tcp(TcpStream), [INFO] [stdout] 47 | Tls(TlsStream), [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Stream` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/openflow/mod.rs:63:12 [INFO] [stdout] | [INFO] [stdout] 50 | fn from(_connection: &OfConnection, stream: TcpStream) -> tls_api::Result { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | Ok(Stream::Tcp(stream)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `offwall` (bin "offwall") due to 2 previous errors; 9 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: constant `P12_KEY` is never used [INFO] [stdout] --> src/conf.rs:65:7 [INFO] [stdout] | [INFO] [stdout] 65 | const P12_KEY: &str = "pkcs12"; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `PASS_KEY` is never used [INFO] [stdout] --> src/conf.rs:66:7 [INFO] [stdout] | [INFO] [stdout] 66 | const PASS_KEY: &str = "passwd"; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `proto` and `pkcs12` are never read [INFO] [stdout] --> src/conf.rs:218:5 [INFO] [stdout] | [INFO] [stdout] 217 | pub struct OfConnection { [INFO] [stdout] | ------------ fields in this struct [INFO] [stdout] 218 | proto: ConnectionProtocol, [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 222 | pkcs12: Option<(Vec, String)>, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `OfConnection` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Tls` is never constructed [INFO] [stdout] --> src/openflow/mod.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 45 | enum Stream { [INFO] [stdout] | ------ variant in this enum [INFO] [stdout] 46 | Tcp(TcpStream), [INFO] [stdout] 47 | Tls(TlsStream), [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Stream` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/openflow/mod.rs:63:12 [INFO] [stdout] | [INFO] [stdout] 50 | fn from(_connection: &OfConnection, stream: TcpStream) -> tls_api::Result { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | Ok(Stream::Tcp(stream)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `offwall` (bin "offwall" test) due to 2 previous errors; 9 warnings emitted [INFO] running `Command { std: "docker" "inspect" "2f8c38e2cc7af5a883f21b114e5db9046444e4117233462de59c201d8fe6e7cc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2f8c38e2cc7af5a883f21b114e5db9046444e4117233462de59c201d8fe6e7cc", kill_on_drop: false }` [INFO] [stdout] 2f8c38e2cc7af5a883f21b114e5db9046444e4117233462de59c201d8fe6e7cc