[INFO] cloning repository https://github.com/benthecarman/memepool [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/benthecarman/memepool" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbenthecarman%2Fmemepool", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbenthecarman%2Fmemepool'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e5cbebc6d6cfdba7c520114ad02130c0fecebb1b [INFO] checking benthecarman/memepool/e5cbebc6d6cfdba7c520114ad02130c0fecebb1b against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbenthecarman%2Fmemepool" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/benthecarman/memepool on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/benthecarman/memepool [INFO] finished tweaking git repo https://github.com/benthecarman/memepool [INFO] tweaked toml for git repo https://github.com/benthecarman/memepool written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/benthecarman/memepool already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 55335fa1e9366b96779ee664dfd76fcfe6ec155067423cdeca5ae14f32f7b2eb [INFO] running `Command { std: "docker" "start" "-a" "55335fa1e9366b96779ee664dfd76fcfe6ec155067423cdeca5ae14f32f7b2eb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "55335fa1e9366b96779ee664dfd76fcfe6ec155067423cdeca5ae14f32f7b2eb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "55335fa1e9366b96779ee664dfd76fcfe6ec155067423cdeca5ae14f32f7b2eb", kill_on_drop: false }` [INFO] [stdout] 55335fa1e9366b96779ee664dfd76fcfe6ec155067423cdeca5ae14f32f7b2eb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e565b0ff995d562b24beebd5f61eea38e712ac200e1023646ebea46b5998f78d [INFO] running `Command { std: "docker" "start" "-a" "e565b0ff995d562b24beebd5f61eea38e712ac200e1023646ebea46b5998f78d", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.139 [INFO] [stderr] Compiling cc v1.0.78 [INFO] [stderr] Compiling anyhow v1.0.71 [INFO] [stderr] Checking bitcoin_hashes v0.11.0 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking bech32 v0.9.1 [INFO] [stderr] Compiling secp256k1-sys v0.6.1 [INFO] [stderr] Checking getrandom v0.2.8 [INFO] [stderr] Checking socks v0.3.4 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking secp256k1 v0.24.2 [INFO] [stderr] Checking bitcoin v0.29.2 [INFO] [stderr] Checking memepool v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/networking/error.rs:26:8 [INFO] [stdout] | [INFO] [stdout] 26 | Io(std::io::Error), [INFO] [stdout] | -- ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `NetworkingError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 26 | Io(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/networking/error.rs:28:10 [INFO] [stdout] | [INFO] [stdout] 28 | Time(std::time::SystemTimeError), [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `NetworkingError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 28 | Time(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `InvalidTransaction`, `NotConnected`, and `NoPeers` are never constructed [INFO] [stdout] --> src/networking/error.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 4 | pub enum NetworkingError { [INFO] [stdout] | --------------- variants in this enum [INFO] [stdout] ... [INFO] [stdout] 8 | InvalidTransaction, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 13 | NotConnected, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 21 | NoPeers, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `NetworkingError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `connect_proxy`, `get_version`, `get_network`, `get_mempool`, and `is_connected` are never used [INFO] [stdout] --> src/networking/peer.rs:64:12 [INFO] [stdout] | [INFO] [stdout] 44 | impl Peer { [INFO] [stdout] | --------- associated items in this implementation [INFO] [stdout] ... [INFO] [stdout] 64 | pub fn connect_proxy( [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 207 | pub fn get_version(&self) -> &VersionMessage { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 212 | pub fn get_network(&self) -> Network { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 217 | pub fn get_mempool(&self) -> Arc { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 222 | pub fn is_connected(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `get_block`, `ask_for_mempool`, and `broadcast_tx` are never used [INFO] [stdout] --> src/networking/peer.rs:363:8 [INFO] [stdout] | [INFO] [stdout] 362 | pub trait InvPeer { [INFO] [stdout] | ------- methods in this trait [INFO] [stdout] 363 | fn get_block(&self, block_hash: BlockHash) -> Result, NetworkingError>; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 364 | fn ask_for_mempool(&self) -> Result<(), NetworkingError>; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 365 | fn broadcast_tx(&self, tx: Transaction) -> Result<(), NetworkingError>; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mempool.rs:37:23 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn add_tx(&self, tx: Transaction) -> anyhow::Result<()> { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | self.add_txs(&[tx]) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/networking/peer.rs:77:27 [INFO] [stdout] | [INFO] [stdout] 65 | target: T, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | proxy: P, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | credentials: Option<(&str, &str)>, [INFO] [stdout] 68 | mempool: Arc, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | let socks_stream = if let Some((username, password)) = credentials { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | Peer::from_stream(socks_stream.into_inner(), mempool, network) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/networking/error.rs:26:8 [INFO] [stdout] | [INFO] [stdout] 26 | Io(std::io::Error), [INFO] [stdout] | -- ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `NetworkingError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 26 | Io(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/networking/error.rs:28:10 [INFO] [stdout] | [INFO] [stdout] 28 | Time(std::time::SystemTimeError), [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `NetworkingError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 28 | Time(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `InvalidTransaction`, `NotConnected`, and `NoPeers` are never constructed [INFO] [stdout] --> src/networking/error.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 4 | pub enum NetworkingError { [INFO] [stdout] | --------------- variants in this enum [INFO] [stdout] ... [INFO] [stdout] 8 | InvalidTransaction, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 13 | NotConnected, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 21 | NoPeers, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `NetworkingError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/networking/peer.rs:149:12 [INFO] [stdout] | [INFO] [stdout] 82 | stream: TcpStream, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | mempool: Arc, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | let writer = Arc::new(Mutex::new(stream.try_clone()?)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | let responses: Arc> = Arc::new(RwLock::new(HashMap::new())); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | let connected = Arc::new(RwLock::new(true)); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | [INFO] [stdout] 90 | let reader_thread_responses = Arc::clone(&responses); [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | let reader_thread_writer = Arc::clone(&writer); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | let reader_thread_mempool = Arc::clone(&mempool); [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | let reader_thread_connected = Arc::clone(&connected); [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | let reader_thread = thread::spawn(move || { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | let mut locked_writer = writer.lock().unwrap(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 149 | Ok(Peer { [INFO] [stdout] | ____________^ [INFO] [stdout] 150 | | writer, [INFO] [stdout] 151 | | responses, [INFO] [stdout] 152 | | reader_thread, [INFO] [stdout] ... | [INFO] [stdout] 156 | | network, [INFO] [stdout] 157 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `connect_proxy`, `get_version`, `get_network`, `get_mempool`, and `is_connected` are never used [INFO] [stdout] --> src/networking/peer.rs:64:12 [INFO] [stdout] | [INFO] [stdout] 44 | impl Peer { [INFO] [stdout] | --------- associated items in this implementation [INFO] [stdout] ... [INFO] [stdout] 64 | pub fn connect_proxy( [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 207 | pub fn get_version(&self) -> &VersionMessage { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 212 | pub fn get_network(&self) -> Network { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 217 | pub fn get_mempool(&self) -> Arc { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 222 | pub fn is_connected(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `get_block`, `ask_for_mempool`, and `broadcast_tx` are never used [INFO] [stdout] --> src/networking/peer.rs:363:8 [INFO] [stdout] | [INFO] [stdout] 362 | pub trait InvPeer { [INFO] [stdout] | ------- methods in this trait [INFO] [stdout] 363 | fn get_block(&self, block_hash: BlockHash) -> Result, NetworkingError>; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 364 | fn ask_for_mempool(&self) -> Result<(), NetworkingError>; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 365 | fn broadcast_tx(&self, tx: Transaction) -> Result<(), NetworkingError>; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mempool.rs:37:23 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn add_tx(&self, tx: Transaction) -> anyhow::Result<()> { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | self.add_txs(&[tx]) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/networking/peer.rs:77:27 [INFO] [stdout] | [INFO] [stdout] 65 | target: T, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | proxy: P, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | credentials: Option<(&str, &str)>, [INFO] [stdout] 68 | mempool: Arc, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | let socks_stream = if let Some((username, password)) = credentials { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | Peer::from_stream(socks_stream.into_inner(), mempool, network) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/networking/peer.rs:149:12 [INFO] [stdout] | [INFO] [stdout] 82 | stream: TcpStream, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | mempool: Arc, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | let writer = Arc::new(Mutex::new(stream.try_clone()?)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | let responses: Arc> = Arc::new(RwLock::new(HashMap::new())); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | let connected = Arc::new(RwLock::new(true)); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | [INFO] [stdout] 90 | let reader_thread_responses = Arc::clone(&responses); [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | let reader_thread_writer = Arc::clone(&writer); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | let reader_thread_mempool = Arc::clone(&mempool); [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | let reader_thread_connected = Arc::clone(&connected); [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | let reader_thread = thread::spawn(move || { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | let mut locked_writer = writer.lock().unwrap(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 149 | Ok(Peer { [INFO] [stdout] | ____________^ [INFO] [stdout] 150 | | writer, [INFO] [stdout] 151 | | responses, [INFO] [stdout] 152 | | reader_thread, [INFO] [stdout] ... | [INFO] [stdout] 156 | | network, [INFO] [stdout] 157 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/networking/peer.rs:304:45 [INFO] [stdout] | [INFO] [stdout] 304 | .map(|item| (*item, reader_thread_mempool.get_tx(item))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/networking/peer.rs:305:67 [INFO] [stdout] | [INFO] [stdout] 305 | .partition(|(_, d)| d.as_ref().unwrap_or(&None).is_some()); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/networking/peer.rs:304:45 [INFO] [stdout] | [INFO] [stdout] 304 | .map(|item| (*item, reader_thread_mempool.get_tx(item))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/networking/peer.rs:305:67 [INFO] [stdout] | [INFO] [stdout] 305 | .partition(|(_, d)| d.as_ref().unwrap_or(&None).is_some()); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `memepool` (bin "memepool" test) due to 6 previous errors; 5 warnings emitted [INFO] [stdout] error: aborting due to 5 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `memepool` (bin "memepool") due to 6 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "e565b0ff995d562b24beebd5f61eea38e712ac200e1023646ebea46b5998f78d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e565b0ff995d562b24beebd5f61eea38e712ac200e1023646ebea46b5998f78d", kill_on_drop: false }` [INFO] [stdout] e565b0ff995d562b24beebd5f61eea38e712ac200e1023646ebea46b5998f78d