[INFO] cloning repository https://github.com/bennyboer/md2letter [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/bennyboer/md2letter" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbennyboer%2Fmd2letter", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbennyboer%2Fmd2letter'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] fc27dc506b06c45797cfeb7ff7b517e0aeca2c60 [INFO] checking bennyboer/md2letter/fc27dc506b06c45797cfeb7ff7b517e0aeca2c60 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbennyboer%2Fmd2letter" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/bennyboer/md2letter on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/bennyboer/md2letter [INFO] finished tweaking git repo https://github.com/bennyboer/md2letter [INFO] tweaked toml for git repo https://github.com/bennyboer/md2letter written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/bennyboer/md2letter already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1453b55efcaf1c46316a3e45cc7a9ea7ecca8cc61893683d65fdd17aafe899d3 [INFO] running `Command { std: "docker" "start" "-a" "1453b55efcaf1c46316a3e45cc7a9ea7ecca8cc61893683d65fdd17aafe899d3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1453b55efcaf1c46316a3e45cc7a9ea7ecca8cc61893683d65fdd17aafe899d3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1453b55efcaf1c46316a3e45cc7a9ea7ecca8cc61893683d65fdd17aafe899d3", kill_on_drop: false }` [INFO] [stdout] 1453b55efcaf1c46316a3e45cc7a9ea7ecca8cc61893683d65fdd17aafe899d3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d21612d24d43229ab7e29458c8ea39fd76cbd4c1cd90d6acccc347870040e779 [INFO] running `Command { std: "docker" "start" "-a" "d21612d24d43229ab7e29458c8ea39fd76cbd4c1cd90d6acccc347870040e779", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] [stderr] Checking arrayvec v0.7.2 [INFO] [stderr] Checking utf8-chars v2.0.3 [INFO] [stderr] Checking md2letter-convert v0.1.0 (/opt/rustwide/workdir/convert) [INFO] [stdout] warning: methods `kind`, `src`, and `span` are never used [INFO] [stdout] --> convert/src/categorizer/block.rs:28:19 [INFO] [stdout] | [INFO] [stdout] 23 | impl CategorizedBlock { [INFO] [stdout] | --------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 28 | pub(crate) fn kind(&self) -> &BlockKind { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | pub(crate) fn src(&self) -> &str { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 36 | pub(crate) fn span(&self) -> &SourceSpan { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple methods are never used [INFO] [stdout] --> convert/src/parser/block/mod.rs:41:19 [INFO] [stdout] | [INFO] [stdout] 36 | impl ParsedBlock { [INFO] [stdout] | ---------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 41 | pub(crate) fn kind(&self) -> &ParsedBlockKind { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 53 | pub(crate) fn is_text(&self) -> bool { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 57 | pub(crate) fn is_list(&self) -> bool { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 61 | pub(crate) fn is_heading(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 65 | pub(crate) fn is_table(&self) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 69 | pub(crate) fn is_image(&self) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 73 | pub(crate) fn is_quote(&self) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 77 | pub(crate) fn is_code(&self) -> bool { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 81 | pub(crate) fn is_function(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 85 | pub(crate) fn is_horizontal_rule(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `tree` is never used [INFO] [stdout] --> convert/src/parser/block/text/mod.rs:15:19 [INFO] [stdout] | [INFO] [stdout] 10 | impl TextBlock { [INFO] [stdout] | -------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 15 | pub(crate) fn tree(&self) -> &TextTree { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `message` and `source_position` are never read [INFO] [stdout] --> convert/src/parser/result.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 6 | pub(crate) struct ParseError { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 7 | pub message: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 8 | pub source_position: SourcePosition, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ParseError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `src` is never used [INFO] [stdout] --> convert/src/splitter/block.rs:14:19 [INFO] [stdout] | [INFO] [stdout] 9 | impl SplitterBlock { [INFO] [stdout] | ------------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 14 | pub(crate) fn src(&self) -> &str { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `block` is never read [INFO] [stdout] --> convert/src/transformer/result.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 6 | pub(crate) struct TransformError { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 7 | pub message: String, [INFO] [stdout] 8 | pub block: ParsedBlock, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TransformError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `id` and `span` are never read [INFO] [stdout] --> convert/src/transformer/tree/node.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 7 | pub(crate) struct LetterScriptNode { [INFO] [stdout] | ---------------- fields in this struct [INFO] [stdout] 8 | id: LetterScriptNodeId, [INFO] [stdout] | ^^ [INFO] [stdout] ... [INFO] [stdout] 11 | span: SourceSpan, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `id` and `span` are never used [INFO] [stdout] --> convert/src/transformer/tree/node.rs:61:19 [INFO] [stdout] | [INFO] [stdout] 47 | impl LetterScriptNode { [INFO] [stdout] | --------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 61 | pub(crate) fn id(&self) -> LetterScriptNodeId { [INFO] [stdout] | ^^ [INFO] [stdout] ... [INFO] [stdout] 73 | pub(crate) fn span(&self) -> &SourceSpan { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> convert/src/splitter/mod.rs:25:21 [INFO] [stdout] | [INFO] [stdout] 23 | pub(crate) fn new(reader: Box) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | Self { [INFO] [stdout] 25 | reader: BufReader::new(reader), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> convert/src/splitter/mod.rs:36:46 [INFO] [stdout] | [INFO] [stdout] 36 | let next_char = next_char.or_else(|| self.reader.read_char().ok().flatten()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `md2letter-convert` (lib) due to 3 previous errors; 8 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `source_position` is never read [INFO] [stdout] --> convert/src/parser/result.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 6 | pub(crate) struct ParseError { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] 7 | pub message: String, [INFO] [stdout] 8 | pub source_position: SourcePosition, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ParseError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `block` is never read [INFO] [stdout] --> convert/src/transformer/result.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 6 | pub(crate) struct TransformError { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 7 | pub message: String, [INFO] [stdout] 8 | pub block: ParsedBlock, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TransformError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `id` and `span` are never read [INFO] [stdout] --> convert/src/transformer/tree/node.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 7 | pub(crate) struct LetterScriptNode { [INFO] [stdout] | ---------------- fields in this struct [INFO] [stdout] 8 | id: LetterScriptNodeId, [INFO] [stdout] | ^^ [INFO] [stdout] ... [INFO] [stdout] 11 | span: SourceSpan, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `id` and `span` are never used [INFO] [stdout] --> convert/src/transformer/tree/node.rs:61:19 [INFO] [stdout] | [INFO] [stdout] 47 | impl LetterScriptNode { [INFO] [stdout] | --------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 61 | pub(crate) fn id(&self) -> LetterScriptNodeId { [INFO] [stdout] | ^^ [INFO] [stdout] ... [INFO] [stdout] 73 | pub(crate) fn span(&self) -> &SourceSpan { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> convert/src/splitter/mod.rs:25:21 [INFO] [stdout] | [INFO] [stdout] 23 | pub(crate) fn new(reader: Box) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | Self { [INFO] [stdout] 25 | reader: BufReader::new(reader), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> convert/src/splitter/mod.rs:36:46 [INFO] [stdout] | [INFO] [stdout] 36 | let next_char = next_char.or_else(|| self.reader.read_char().ok().flatten()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `md2letter-convert` (lib test) due to 3 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "d21612d24d43229ab7e29458c8ea39fd76cbd4c1cd90d6acccc347870040e779", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d21612d24d43229ab7e29458c8ea39fd76cbd4c1cd90d6acccc347870040e779", kill_on_drop: false }` [INFO] [stdout] d21612d24d43229ab7e29458c8ea39fd76cbd4c1cd90d6acccc347870040e779