[INFO] cloning repository https://github.com/benjaminhirsch/raytracer [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/benjaminhirsch/raytracer" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbenjaminhirsch%2Fraytracer", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbenjaminhirsch%2Fraytracer'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] dd6246246698803c62d539a4962f9a142e39e399 [INFO] checking benjaminhirsch/raytracer/dd6246246698803c62d539a4962f9a142e39e399 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbenjaminhirsch%2Fraytracer" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/benjaminhirsch/raytracer on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/benjaminhirsch/raytracer [INFO] finished tweaking git repo https://github.com/benjaminhirsch/raytracer [INFO] tweaked toml for git repo https://github.com/benjaminhirsch/raytracer written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/benjaminhirsch/raytracer already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5316e6be024ee9bd0b7138f5cc6828cb3592e13a6715a54ab835ba896629e8a2 [INFO] running `Command { std: "docker" "start" "-a" "5316e6be024ee9bd0b7138f5cc6828cb3592e13a6715a54ab835ba896629e8a2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5316e6be024ee9bd0b7138f5cc6828cb3592e13a6715a54ab835ba896629e8a2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5316e6be024ee9bd0b7138f5cc6828cb3592e13a6715a54ab835ba896629e8a2", kill_on_drop: false }` [INFO] [stdout] 5316e6be024ee9bd0b7138f5cc6828cb3592e13a6715a54ab835ba896629e8a2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2b110bdd0dc868b602bbf7fb9ec4d4b840641f1ee5a0157a4150403758514419 [INFO] running `Command { std: "docker" "start" "-a" "2b110bdd0dc868b602bbf7fb9ec4d4b840641f1ee5a0157a4150403758514419", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.97 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Checking approx v0.5.0 [INFO] [stderr] Checking ray-tracer v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused `#[macro_use]` import [INFO] [stdout] --> src/main.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | #[macro_use] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `create`, `write`, and `pixel_at` are never used [INFO] [stdout] --> src/canvas/canvas.rs:13:12 [INFO] [stdout] | [INFO] [stdout] 12 | impl Canvas { [INFO] [stdout] | ----------- associated items in this implementation [INFO] [stdout] 13 | pub fn create(width: usize, height: usize) -> Canvas { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 21 | pub fn write(&mut self, x: usize, y: usize, color: Color) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 25 | pub fn pixel_at(&self, x: usize, y: usize) -> Color { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/canvas/ppm_writer.rs:30:8 [INFO] [stdout] | [INFO] [stdout] 27 | let output = File::create(target_path)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | Ok(Box::new(target_path.to_str().unwrap().to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `create` and `multiply_by` are never used [INFO] [stdout] --> src/color/color.rs:11:19 [INFO] [stdout] | [INFO] [stdout] 10 | impl Color { [INFO] [stdout] | ---------- associated items in this implementation [INFO] [stdout] 11 | pub(crate) fn create(red: f64, green: f64, blue: f64) -> Color { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 15 | pub fn multiply_by(&self, factor: f64) -> Color { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `IDENTITY_MATRIX` is never used [INFO] [stdout] --> src/math/matrix.rs:34:11 [INFO] [stdout] | [INFO] [stdout] 34 | pub const IDENTITY_MATRIX: Matrix = Matrix { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `transpose` is never used [INFO] [stdout] --> src/math/matrix.rs:144:12 [INFO] [stdout] | [INFO] [stdout] 56 | impl Matrix { [INFO] [stdout] | ----------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 144 | pub fn transpose(&self) -> Self { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple associated items are never used [INFO] [stdout] --> src/math/tuple.rs:16:12 [INFO] [stdout] | [INFO] [stdout] 11 | impl Tuple { [INFO] [stdout] | ---------- associated items in this implementation [INFO] [stdout] ... [INFO] [stdout] 16 | pub fn vector(x: f64, y: f64, z: f64) -> Tuple { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 20 | pub fn point(x: f64, y: f64, z: f64) -> Tuple { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 24 | pub fn is_vector(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 28 | pub fn is_point(&self) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | pub fn magnitude(&self) -> f64 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 36 | pub fn normalize(&self) -> Tuple { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 49 | pub fn cross(&self, that: Tuple) -> Tuple { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/canvas/ppm_writer.rs:30:8 [INFO] [stdout] | [INFO] [stdout] 27 | let output = File::create(target_path)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | Ok(Box::new(target_path.to_str().unwrap().to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ray-tracer` (bin "ray-tracer" test) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `ray-tracer` (bin "ray-tracer") due to 2 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "2b110bdd0dc868b602bbf7fb9ec4d4b840641f1ee5a0157a4150403758514419", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2b110bdd0dc868b602bbf7fb9ec4d4b840641f1ee5a0157a4150403758514419", kill_on_drop: false }` [INFO] [stdout] 2b110bdd0dc868b602bbf7fb9ec4d4b840641f1ee5a0157a4150403758514419