[INFO] cloning repository https://github.com/beeper/synapse [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/beeper/synapse" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbeeper%2Fsynapse", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbeeper%2Fsynapse'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] cecd55c94437b8222585bf96c837b12a405fa9c5 [INFO] checking beeper/synapse/cecd55c94437b8222585bf96c837b12a405fa9c5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbeeper%2Fsynapse" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/beeper/synapse on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/beeper/synapse [INFO] finished tweaking git repo https://github.com/beeper/synapse [INFO] tweaked toml for git repo https://github.com/beeper/synapse written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/beeper/synapse already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2ed610525817362199ad51813fa5b18d28a0523bda485fb0f82e07d2331fde00 [INFO] running `Command { std: "docker" "start" "-a" "2ed610525817362199ad51813fa5b18d28a0523bda485fb0f82e07d2331fde00", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2ed610525817362199ad51813fa5b18d28a0523bda485fb0f82e07d2331fde00", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2ed610525817362199ad51813fa5b18d28a0523bda485fb0f82e07d2331fde00", kill_on_drop: false }` [INFO] [stdout] 2ed610525817362199ad51813fa5b18d28a0523bda485fb0f82e07d2331fde00 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e247bf9a8daf0d2ab79a7789063a20567677742344e1895aacf32bb0ab342b8c [INFO] running `Command { std: "docker" "start" "-a" "e247bf9a8daf0d2ab79a7789063a20567677742344e1895aacf32bb0ab342b8c", kill_on_drop: false }` [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling target-lexicon v0.12.14 [INFO] [stderr] Compiling libc v0.2.154 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling proc-macro2 v1.0.82 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Compiling portable-atomic v1.6.0 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Compiling subtle v2.5.0 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Compiling indoc v2.0.5 [INFO] [stderr] Checking unindent v0.2.3 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Compiling hex v0.4.3 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling memoffset v0.9.1 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking httpdate v1.0.3 [INFO] [stderr] Checking arc-swap v1.7.1 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking base64 v0.21.7 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling pyo3-build-config v0.21.2 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.61 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot v0.12.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking headers-core v0.3.0 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling blake2 v0.10.6 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking headers v0.4.0 [INFO] [stderr] Compiling pyo3-ffi v0.21.2 [INFO] [stderr] Compiling pyo3 v0.21.2 [INFO] [stderr] Compiling synapse v0.1.0 (/opt/rustwide/workdir/rust) [INFO] [stderr] Checking ulid v1.1.2 [INFO] [stderr] Compiling pyo3-macros-backend v0.21.2 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Compiling pyo3-macros v0.21.2 [INFO] [stderr] Checking pyo3-log v0.10.0 [INFO] [stderr] Checking pythonize v0.21.1 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> rust/src/acl/mod.rs:74:12 [INFO] [stdout] | [INFO] [stdout] 62 | allow: Vec, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | deny: Vec, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | ) -> Result { [INFO] [stdout] 65 | let allow = allow [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | let deny = deny [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | Ok(ServerAclEvaluator { [INFO] [stdout] | ____________^ [INFO] [stdout] 75 | | allow_ip_literals, [INFO] [stdout] 76 | | allow, [INFO] [stdout] 77 | | deny, [INFO] [stdout] 78 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> rust/src/events/internal_metadata.rs:153:12 [INFO] [stdout] | [INFO] [stdout] 98 | let key_str: PyBackedStr = key.extract()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | [INFO] [stdout] 100 | let e = match &*key_str { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | Ok(Some(e)) [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> rust/src/events/internal_metadata.rs:232:12 [INFO] [stdout] | [INFO] [stdout] 218 | let mut data = Vec::with_capacity(dict.len()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 232 | Ok(EventInternalMetadata { [INFO] [stdout] | ____________^ [INFO] [stdout] 233 | | data, [INFO] [stdout] 234 | | stream_ordering: None, [INFO] [stdout] 235 | | outlier: false, [INFO] [stdout] 236 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> rust/src/events/internal_metadata.rs:254:12 [INFO] [stdout] | [INFO] [stdout] 247 | let dict = PyDict::new_bound(py); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 254 | Ok(dict.into()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `synapse` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> rust/src/acl/mod.rs:74:12 [INFO] [stdout] | [INFO] [stdout] 62 | allow: Vec, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | deny: Vec, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | ) -> Result { [INFO] [stdout] 65 | let allow = allow [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | let deny = deny [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | Ok(ServerAclEvaluator { [INFO] [stdout] | ____________^ [INFO] [stdout] 75 | | allow_ip_literals, [INFO] [stdout] 76 | | allow, [INFO] [stdout] 77 | | deny, [INFO] [stdout] 78 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> rust/src/events/internal_metadata.rs:153:12 [INFO] [stdout] | [INFO] [stdout] 98 | let key_str: PyBackedStr = key.extract()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | [INFO] [stdout] 100 | let e = match &*key_str { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | Ok(Some(e)) [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> rust/src/events/internal_metadata.rs:232:12 [INFO] [stdout] | [INFO] [stdout] 218 | let mut data = Vec::with_capacity(dict.len()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 232 | Ok(EventInternalMetadata { [INFO] [stdout] | ____________^ [INFO] [stdout] 233 | | data, [INFO] [stdout] 234 | | stream_ordering: None, [INFO] [stdout] 235 | | outlier: false, [INFO] [stdout] 236 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> rust/src/events/internal_metadata.rs:254:12 [INFO] [stdout] | [INFO] [stdout] 247 | let dict = PyDict::new_bound(py); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 254 | Ok(dict.into()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `synapse` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "e247bf9a8daf0d2ab79a7789063a20567677742344e1895aacf32bb0ab342b8c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e247bf9a8daf0d2ab79a7789063a20567677742344e1895aacf32bb0ab342b8c", kill_on_drop: false }` [INFO] [stdout] e247bf9a8daf0d2ab79a7789063a20567677742344e1895aacf32bb0ab342b8c