[INFO] cloning repository https://github.com/bednabedna/GrammarRs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/bednabedna/GrammarRs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbednabedna%2FGrammarRs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbednabedna%2FGrammarRs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 0f90638e8defe272e5e34424994743b7b5e5da98 [INFO] checking bednabedna/GrammarRs/0f90638e8defe272e5e34424994743b7b5e5da98 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbednabedna%2FGrammarRs" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/bednabedna/GrammarRs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/bednabedna/GrammarRs [INFO] finished tweaking git repo https://github.com/bednabedna/GrammarRs [INFO] tweaked toml for git repo https://github.com/bednabedna/GrammarRs written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/bednabedna/GrammarRs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9e8170550b62dff8bcd627e8a1716305cc23bc6c3517c981ab59196982d66c2d [INFO] running `Command { std: "docker" "start" "-a" "9e8170550b62dff8bcd627e8a1716305cc23bc6c3517c981ab59196982d66c2d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9e8170550b62dff8bcd627e8a1716305cc23bc6c3517c981ab59196982d66c2d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9e8170550b62dff8bcd627e8a1716305cc23bc6c3517c981ab59196982d66c2d", kill_on_drop: false }` [INFO] [stdout] 9e8170550b62dff8bcd627e8a1716305cc23bc6c3517c981ab59196982d66c2d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f4478b2ddff4d0dca3b33bbbaad9a1445b7049a001ac604ed05f9429fd359088 [INFO] running `Command { std: "docker" "start" "-a" "f4478b2ddff4d0dca3b33bbbaad9a1445b7049a001ac604ed05f9429fd359088", kill_on_drop: false }` [INFO] [stderr] Checking grammar v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/grammar.rs:22:13 [INFO] [stdout] | [INFO] [stdout] 21 | let mut matches = Vec::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | / first_rule [INFO] [stdout] 23 | | .pattern() [INFO] [stdout] 24 | | .consume(&self.rules, &mut matches, input) [INFO] [stdout] 25 | | .map_err(|maybe_err| maybe_err.map(|err| err.to_boxed_slice())) [INFO] [stdout] | |_______________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/grammar.rs:26:27 [INFO] [stdout] | [INFO] [stdout] 21 | let mut matches = Vec::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | .and_then(|remainder| { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 27 | | if remainder.is_empty() { [INFO] [stdout] 28 | | Ok(Token { [INFO] [stdout] 29 | | rule: first_rule.name(), [INFO] [stdout] ... | [INFO] [stdout] 39 | | } [INFO] [stdout] 40 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/parser.rs:42:8 [INFO] [stdout] | [INFO] [stdout] 22 | let tokens = Tokenizer::new(input).consume_grammar()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | let mut rules = Vec::with_capacity(tokens.len()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | Ok(Grammar::new(rules.into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this method call resolves to `<&Box<[T]> as IntoIterator>::into_iter` (due to backwards compatibility), but will resolve to ` as IntoIterator>::into_iter` in Rust 2024 [INFO] [stdout] --> src/parser/parser.rs:24:25 [INFO] [stdout] | [INFO] [stdout] 24 | for token in tokens.into_iter() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: `#[warn(boxed_slice_into_iter)]` on by default [INFO] [stdout] help: use `.iter()` instead of `.into_iter()` to avoid ambiguity [INFO] [stdout] | [INFO] [stdout] 24 | for token in tokens.iter() { [INFO] [stdout] | ~~~~ [INFO] [stdout] help: or remove `.into_iter()` to iterate by value [INFO] [stdout] | [INFO] [stdout] 24 - for token in tokens.into_iter() { [INFO] [stdout] 24 + for token in tokens { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this method call resolves to `<&Box<[T]> as IntoIterator>::into_iter` (due to backwards compatibility), but will resolve to ` as IntoIterator>::into_iter` in Rust 2024 [INFO] [stdout] --> src/parser/parser.rs:30:25 [INFO] [stdout] | [INFO] [stdout] 30 | for token in tokens.into_iter() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] help: use `.iter()` instead of `.into_iter()` to avoid ambiguity [INFO] [stdout] | [INFO] [stdout] 30 | for token in tokens.iter() { [INFO] [stdout] | ~~~~ [INFO] [stdout] help: or remove `.into_iter()` to iterate by value [INFO] [stdout] | [INFO] [stdout] 30 - for token in tokens.into_iter() { [INFO] [stdout] 30 + for token in tokens { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/parser.rs:79:32 [INFO] [stdout] | [INFO] [stdout] 79 | self.try_parse(|s| s.parse_p2().and_then(|p| s.parse_cardinality(p))) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/parser.rs:104:20 [INFO] [stdout] | [INFO] [stdout] 100 | s.parse_p1().and_then(|p1| { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | let mut patterns = Vec::with_capacity(6); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | Ok(if patterns.len() == 1 { [INFO] [stdout] | ____________________^ [INFO] [stdout] 105 | | patterns.pop().unwrap() [INFO] [stdout] 106 | | } else { [INFO] [stdout] 107 | | Pattern::And(patterns.into()) [INFO] [stdout] 108 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/parser.rs:126:20 [INFO] [stdout] | [INFO] [stdout] 116 | s.parse_and_no_par().and_then(|p1| { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | let mut patterns = Vec::with_capacity(6); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | Ok(if patterns.len() == 1 { [INFO] [stdout] | ____________________^ [INFO] [stdout] 127 | | patterns.pop().unwrap() [INFO] [stdout] 128 | | } else { [INFO] [stdout] 129 | | Pattern::Or(patterns.into()) [INFO] [stdout] 130 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/parser.rs:121:56 [INFO] [stdout] | [INFO] [stdout] 121 | or(s.parse_and_no_par(), || Ok(Pattern::word(""))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/parser.rs:195:13 [INFO] [stdout] | [INFO] [stdout] 193 | fn parse_cardinality(&mut self, pattern: Pattern) -> ParserResult<'input> { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 194 | Ok( [INFO] [stdout] 195 | / if let Some((min, max)) = self.tokenizer.consume_cardinality() { [INFO] [stdout] 196 | | Pattern::Cardinality { [INFO] [stdout] 197 | | min, [INFO] [stdout] 198 | | max, [INFO] [stdout] ... | [INFO] [stdout] 202 | | pattern [INFO] [stdout] 203 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/parser.rs:273:24 [INFO] [stdout] | [INFO] [stdout] 267 | parser: F, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 273 | self.try_parse(|s| { [INFO] [stdout] | ________________________^ [INFO] [stdout] 274 | | if s.tokenizer.lexer.consume_char(start_del) { [INFO] [stdout] 275 | | let result = parser(s)?; [INFO] [stdout] 276 | | if s.tokenizer.lexer.consume_char(end_del) { [INFO] [stdout] ... | [INFO] [stdout] 280 | | Err(InvalidPattern) [INFO] [stdout] 281 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/tokenizer.rs:46:26 [INFO] [stdout] | [INFO] [stdout] 40 | consumer: F, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | self.try_consume(|s| { [INFO] [stdout] | __________________________^ [INFO] [stdout] 47 | | if s.lexer.consume_char(start_del) { [INFO] [stdout] 48 | | let result = s.try_consume(consumer)?; [INFO] [stdout] 49 | | if s.lexer.consume_char(end_del) { [INFO] [stdout] ... | [INFO] [stdout] 53 | | None [INFO] [stdout] 54 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pattern.rs:14:19 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn new(name: &str, pattern: Pattern, error: &str) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | Self { [INFO] [stdout] 14 | name: name.into(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pattern.rs:16:20 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn new(name: &str, pattern: Pattern, error: &str) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 16 | error: if error.is_empty() { [INFO] [stdout] | ____________________^ [INFO] [stdout] 17 | | None [INFO] [stdout] 18 | | } else { [INFO] [stdout] 19 | | Some(error.into()) [INFO] [stdout] 20 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pattern.rs:129:22 [INFO] [stdout] | [INFO] [stdout] 125 | pub fn zero_or_one(pattern: Pattern) -> Pattern { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | pattern: pattern.into(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pattern.rs:137:22 [INFO] [stdout] | [INFO] [stdout] 133 | pub fn zero_or_more(pattern: Pattern) -> Pattern { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | pattern: pattern.into(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pattern.rs:145:22 [INFO] [stdout] | [INFO] [stdout] 141 | pub fn one_or_more(pattern: Pattern) -> Pattern { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | pattern: pattern.into(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 15 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `grammar` (lib) due to 16 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/grammar.rs:22:13 [INFO] [stdout] | [INFO] [stdout] 21 | let mut matches = Vec::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | / first_rule [INFO] [stdout] 23 | | .pattern() [INFO] [stdout] 24 | | .consume(&self.rules, &mut matches, input) [INFO] [stdout] 25 | | .map_err(|maybe_err| maybe_err.map(|err| err.to_boxed_slice())) [INFO] [stdout] | |_______________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/grammar.rs:26:27 [INFO] [stdout] | [INFO] [stdout] 21 | let mut matches = Vec::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | .and_then(|remainder| { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 27 | | if remainder.is_empty() { [INFO] [stdout] 28 | | Ok(Token { [INFO] [stdout] 29 | | rule: first_rule.name(), [INFO] [stdout] ... | [INFO] [stdout] 39 | | } [INFO] [stdout] 40 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/parser.rs:42:8 [INFO] [stdout] | [INFO] [stdout] 22 | let tokens = Tokenizer::new(input).consume_grammar()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | let mut rules = Vec::with_capacity(tokens.len()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | Ok(Grammar::new(rules.into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this method call resolves to `<&Box<[T]> as IntoIterator>::into_iter` (due to backwards compatibility), but will resolve to ` as IntoIterator>::into_iter` in Rust 2024 [INFO] [stdout] --> src/parser/parser.rs:24:25 [INFO] [stdout] | [INFO] [stdout] 24 | for token in tokens.into_iter() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: `#[warn(boxed_slice_into_iter)]` on by default [INFO] [stdout] help: use `.iter()` instead of `.into_iter()` to avoid ambiguity [INFO] [stdout] | [INFO] [stdout] 24 | for token in tokens.iter() { [INFO] [stdout] | ~~~~ [INFO] [stdout] help: or remove `.into_iter()` to iterate by value [INFO] [stdout] | [INFO] [stdout] 24 - for token in tokens.into_iter() { [INFO] [stdout] 24 + for token in tokens { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this method call resolves to `<&Box<[T]> as IntoIterator>::into_iter` (due to backwards compatibility), but will resolve to ` as IntoIterator>::into_iter` in Rust 2024 [INFO] [stdout] --> src/parser/parser.rs:30:25 [INFO] [stdout] | [INFO] [stdout] 30 | for token in tokens.into_iter() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] help: use `.iter()` instead of `.into_iter()` to avoid ambiguity [INFO] [stdout] | [INFO] [stdout] 30 | for token in tokens.iter() { [INFO] [stdout] | ~~~~ [INFO] [stdout] help: or remove `.into_iter()` to iterate by value [INFO] [stdout] | [INFO] [stdout] 30 - for token in tokens.into_iter() { [INFO] [stdout] 30 + for token in tokens { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/parser.rs:79:32 [INFO] [stdout] | [INFO] [stdout] 79 | self.try_parse(|s| s.parse_p2().and_then(|p| s.parse_cardinality(p))) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/parser.rs:104:20 [INFO] [stdout] | [INFO] [stdout] 100 | s.parse_p1().and_then(|p1| { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | let mut patterns = Vec::with_capacity(6); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | Ok(if patterns.len() == 1 { [INFO] [stdout] | ____________________^ [INFO] [stdout] 105 | | patterns.pop().unwrap() [INFO] [stdout] 106 | | } else { [INFO] [stdout] 107 | | Pattern::And(patterns.into()) [INFO] [stdout] 108 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/parser.rs:126:20 [INFO] [stdout] | [INFO] [stdout] 116 | s.parse_and_no_par().and_then(|p1| { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | let mut patterns = Vec::with_capacity(6); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | Ok(if patterns.len() == 1 { [INFO] [stdout] | ____________________^ [INFO] [stdout] 127 | | patterns.pop().unwrap() [INFO] [stdout] 128 | | } else { [INFO] [stdout] 129 | | Pattern::Or(patterns.into()) [INFO] [stdout] 130 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/parser.rs:121:56 [INFO] [stdout] | [INFO] [stdout] 121 | or(s.parse_and_no_par(), || Ok(Pattern::word(""))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/parser.rs:195:13 [INFO] [stdout] | [INFO] [stdout] 193 | fn parse_cardinality(&mut self, pattern: Pattern) -> ParserResult<'input> { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 194 | Ok( [INFO] [stdout] 195 | / if let Some((min, max)) = self.tokenizer.consume_cardinality() { [INFO] [stdout] 196 | | Pattern::Cardinality { [INFO] [stdout] 197 | | min, [INFO] [stdout] 198 | | max, [INFO] [stdout] ... | [INFO] [stdout] 202 | | pattern [INFO] [stdout] 203 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/parser.rs:273:24 [INFO] [stdout] | [INFO] [stdout] 267 | parser: F, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 273 | self.try_parse(|s| { [INFO] [stdout] | ________________________^ [INFO] [stdout] 274 | | if s.tokenizer.lexer.consume_char(start_del) { [INFO] [stdout] 275 | | let result = parser(s)?; [INFO] [stdout] 276 | | if s.tokenizer.lexer.consume_char(end_del) { [INFO] [stdout] ... | [INFO] [stdout] 280 | | Err(InvalidPattern) [INFO] [stdout] 281 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/tokenizer.rs:46:26 [INFO] [stdout] | [INFO] [stdout] 40 | consumer: F, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | self.try_consume(|s| { [INFO] [stdout] | __________________________^ [INFO] [stdout] 47 | | if s.lexer.consume_char(start_del) { [INFO] [stdout] 48 | | let result = s.try_consume(consumer)?; [INFO] [stdout] 49 | | if s.lexer.consume_char(end_del) { [INFO] [stdout] ... | [INFO] [stdout] 53 | | None [INFO] [stdout] 54 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pattern.rs:14:19 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn new(name: &str, pattern: Pattern, error: &str) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | Self { [INFO] [stdout] 14 | name: name.into(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pattern.rs:16:20 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn new(name: &str, pattern: Pattern, error: &str) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 16 | error: if error.is_empty() { [INFO] [stdout] | ____________________^ [INFO] [stdout] 17 | | None [INFO] [stdout] 18 | | } else { [INFO] [stdout] 19 | | Some(error.into()) [INFO] [stdout] 20 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pattern.rs:129:22 [INFO] [stdout] | [INFO] [stdout] 125 | pub fn zero_or_one(pattern: Pattern) -> Pattern { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | pattern: pattern.into(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pattern.rs:137:22 [INFO] [stdout] | [INFO] [stdout] 133 | pub fn zero_or_more(pattern: Pattern) -> Pattern { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | pattern: pattern.into(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pattern.rs:145:22 [INFO] [stdout] | [INFO] [stdout] 141 | pub fn one_or_more(pattern: Pattern) -> Pattern { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | pattern: pattern.into(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/lib.rs:47:24 [INFO] [stdout] | [INFO] [stdout] 47 | panic!(format!("invalid regex '{}'", test[0])); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 47 - panic!(format!("invalid regex '{}'", test[0])); [INFO] [stdout] 47 + panic!("invalid regex '{}'", test[0]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/lib.rs:83:24 [INFO] [stdout] | [INFO] [stdout] 83 | panic!(format!("invalid regex '{}'", test[0])); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 83 - panic!(format!("invalid regex '{}'", test[0])); [INFO] [stdout] 83 + panic!("invalid regex '{}'", test[0]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 15 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `grammar` (lib test) due to 16 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "f4478b2ddff4d0dca3b33bbbaad9a1445b7049a001ac604ed05f9429fd359088", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f4478b2ddff4d0dca3b33bbbaad9a1445b7049a001ac604ed05f9429fd359088", kill_on_drop: false }` [INFO] [stdout] f4478b2ddff4d0dca3b33bbbaad9a1445b7049a001ac604ed05f9429fd359088