[INFO] cloning repository https://github.com/beagleknight/fag-rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/beagleknight/fag-rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbeagleknight%2Ffag-rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbeagleknight%2Ffag-rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 110267987cd829141152cdaf18afa267f50ce26c [INFO] checking beagleknight/fag-rust/110267987cd829141152cdaf18afa267f50ce26c against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbeagleknight%2Ffag-rust" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/beagleknight/fag-rust on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/beagleknight/fag-rust [INFO] finished tweaking git repo https://github.com/beagleknight/fag-rust [INFO] tweaked toml for git repo https://github.com/beagleknight/fag-rust written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/beagleknight/fag-rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3a756e804f48aa9f3c5905ff5ee4ca7898c09e5c6a84ca88115d44b63e78afc4 [INFO] running `Command { std: "docker" "start" "-a" "3a756e804f48aa9f3c5905ff5ee4ca7898c09e5c6a84ca88115d44b63e78afc4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3a756e804f48aa9f3c5905ff5ee4ca7898c09e5c6a84ca88115d44b63e78afc4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3a756e804f48aa9f3c5905ff5ee4ca7898c09e5c6a84ca88115d44b63e78afc4", kill_on_drop: false }` [INFO] [stdout] 3a756e804f48aa9f3c5905ff5ee4ca7898c09e5c6a84ca88115d44b63e78afc4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c91d77146f67e3becfe45bd46418bd8f51ee8680a55548de4e01859619888f7a [INFO] running `Command { std: "docker" "start" "-a" "c91d77146f67e3becfe45bd46418bd8f51ee8680a55548de4e01859619888f7a", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.51 [INFO] [stderr] Compiling xml-rs v0.8.0 [INFO] [stderr] Compiling proc-macro2 v0.4.27 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Checking lazy_static v1.3.0 [INFO] [stderr] Checking cfg-if v0.1.7 [INFO] [stderr] Compiling num-traits v0.2.6 [INFO] [stderr] Compiling byteorder v1.3.1 [INFO] [stderr] Compiling autocfg v0.1.2 [INFO] [stderr] Compiling arrayvec v0.4.10 [INFO] [stderr] Checking rand_core v0.4.0 [INFO] [stderr] Compiling khronos_api v3.0.0 [INFO] [stderr] Checking nodrop v0.1.13 [INFO] [stderr] Checking bitflags v1.0.4 [INFO] [stderr] Compiling cc v1.0.32 [INFO] [stderr] Checking scopeguard v0.3.3 [INFO] [stderr] Checking crossbeam-utils v0.2.2 [INFO] [stderr] Checking memoffset v0.2.1 [INFO] [stderr] Compiling log v0.4.6 [INFO] [stderr] Compiling syn v0.15.29 [INFO] [stderr] Compiling nix v0.12.0 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling rayon-core v1.4.1 [INFO] [stderr] Compiling num-integer v0.1.39 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Compiling num-derive v0.2.4 [INFO] [stderr] Compiling pkg-config v0.3.14 [INFO] [stderr] Compiling num-iter v0.1.37 [INFO] [stderr] Checking adler32 v1.0.3 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Compiling rayon v1.0.3 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Compiling gl_generator v0.10.0 [INFO] [stderr] Checking num_cpus v1.10.0 [INFO] [stderr] Checking stb_truetype v0.2.6 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_jitter v0.1.3 [INFO] [stderr] Compiling parking_lot_core v0.4.0 [INFO] [stderr] Checking downcast-rs v1.0.3 [INFO] [stderr] Compiling nix v0.13.0 [INFO] [stderr] Compiling quote v0.6.11 [INFO] [stderr] Checking either v1.5.1 [INFO] [stderr] Checking same-file v1.0.4 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Compiling num-rational v0.2.1 [INFO] [stderr] Checking lzw v0.10.0 [INFO] [stderr] Checking stable_deref_trait v1.1.1 [INFO] [stderr] Checking walkdir v2.2.7 [INFO] [stderr] Compiling wayland-scanner v0.21.11 [INFO] [stderr] Checking ordered-float v1.0.2 [INFO] [stderr] Checking approx v0.3.2 [INFO] [stderr] Compiling x11-dl v2.18.3 [INFO] [stderr] Checking owning_ref v0.4.0 [INFO] [stderr] Compiling libloading v0.5.0 [INFO] [stderr] Checking line_drawing v0.7.0 [INFO] [stderr] Checking deflate v0.7.19 [INFO] [stderr] Checking inflate v0.4.5 [INFO] [stderr] Checking color_quant v1.0.1 [INFO] [stderr] Checking xdg v2.2.0 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking smallvec v0.6.9 [INFO] [stderr] Checking rusttype v0.7.5 [INFO] [stderr] Checking lock_api v0.1.5 [INFO] [stderr] Checking gif v0.10.1 [INFO] [stderr] Compiling glutin_glx_sys v0.1.2 [INFO] [stderr] Compiling glutin_egl_sys v0.1.2 [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Checking dlib v0.4.1 [INFO] [stderr] Checking safe-transmute v0.10.1 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Compiling gl v0.11.0 [INFO] [stderr] Checking wayland-sys v0.21.11 [INFO] [stderr] Checking shared_library v0.1.9 [INFO] [stderr] Checking percent-encoding v1.0.1 [INFO] [stderr] Checking png v0.14.0 [INFO] [stderr] Checking andrew v0.2.1 [INFO] [stderr] Compiling serde v1.0.89 [INFO] [stderr] Checking futures v0.1.25 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking parking_lot v0.7.1 [INFO] [stderr] Compiling wayland-client v0.21.11 [INFO] [stderr] Compiling wayland-protocols v0.21.11 [INFO] [stderr] Checking wayland-commons v0.21.11 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Compiling serde_derive v1.0.89 [INFO] [stderr] Checking tiff v0.2.2 [INFO] [stderr] Checking image v0.21.0 [INFO] [stderr] Checking smithay-client-toolkit v0.4.5 [INFO] [stderr] Checking winit v0.19.0 [INFO] [stderr] Checking glutin v0.20.0 [INFO] [stderr] Checking quicksilver v0.3.10 [INFO] [stderr] Checking fag-rust v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/physics.rs:5:40 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn sprite_collision(sprite_1: &mut Sprite, sprite_2: &mut Sprite) -> bool { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 5 | pub fn sprite_collision(sprite_1: &mut dyn Sprite, sprite_2: &mut Sprite) -> bool { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/physics.rs:5:63 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn sprite_collision(sprite_1: &mut Sprite, sprite_2: &mut Sprite) -> bool { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 5 | pub fn sprite_collision(sprite_1: &mut Sprite, sprite_2: &mut dyn Sprite) -> bool { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/physics.rs:5:40 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn sprite_collision(sprite_1: &mut Sprite, sprite_2: &mut Sprite) -> bool { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 5 | pub fn sprite_collision(sprite_1: &mut dyn Sprite, sprite_2: &mut Sprite) -> bool { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/physics.rs:5:63 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn sprite_collision(sprite_1: &mut Sprite, sprite_2: &mut Sprite) -> bool { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 5 | pub fn sprite_collision(sprite_1: &mut Sprite, sprite_2: &mut dyn Sprite) -> bool { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/enemy.rs:64:16 [INFO] [stdout] | [INFO] [stdout] 53 | let asset = Asset::new(Image::load("sprites/tiefighter.gif")); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | bullets: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:25:8 [INFO] [stdout] | [INFO] [stdout] 23 | let tile_map = TileMap::new(21, 21, 30, 30, 0.1); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | let player = Player::new(300, 550, 38, 43); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | Ok(Game { [INFO] [stdout] | ________^ [INFO] [stdout] 26 | | tile_map, [INFO] [stdout] 27 | | player, [INFO] [stdout] 28 | | enemies: Vec::new(), [INFO] [stdout] 29 | | last_enemy_spawned_at: 0.0, [INFO] [stdout] 30 | | time_to_spawn_enemy: 1000.0, [INFO] [stdout] 31 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/player.rs:58:16 [INFO] [stdout] | [INFO] [stdout] 50 | let asset = Asset::new(Image::load("sprites/nau.gif")); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | bullets: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fag-rust` (bin "fag-rust") due to 4 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/enemy.rs:64:16 [INFO] [stdout] | [INFO] [stdout] 53 | let asset = Asset::new(Image::load("sprites/tiefighter.gif")); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | bullets: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:25:8 [INFO] [stdout] | [INFO] [stdout] 23 | let tile_map = TileMap::new(21, 21, 30, 30, 0.1); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | let player = Player::new(300, 550, 38, 43); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | Ok(Game { [INFO] [stdout] | ________^ [INFO] [stdout] 26 | | tile_map, [INFO] [stdout] 27 | | player, [INFO] [stdout] 28 | | enemies: Vec::new(), [INFO] [stdout] 29 | | last_enemy_spawned_at: 0.0, [INFO] [stdout] 30 | | time_to_spawn_enemy: 1000.0, [INFO] [stdout] 31 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/player.rs:58:16 [INFO] [stdout] | [INFO] [stdout] 50 | let asset = Asset::new(Image::load("sprites/nau.gif")); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | bullets: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fag-rust` (bin "fag-rust" test) due to 4 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "c91d77146f67e3becfe45bd46418bd8f51ee8680a55548de4e01859619888f7a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c91d77146f67e3becfe45bd46418bd8f51ee8680a55548de4e01859619888f7a", kill_on_drop: false }` [INFO] [stdout] c91d77146f67e3becfe45bd46418bd8f51ee8680a55548de4e01859619888f7a