[INFO] cloning repository https://github.com/bczhc/simple-http-server-rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/bczhc/simple-http-server-rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbczhc%2Fsimple-http-server-rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbczhc%2Fsimple-http-server-rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] db61a8a9c6c6e6b0c5d782c8c2d1d44bb55a99bc [INFO] checking bczhc/simple-http-server-rust/db61a8a9c6c6e6b0c5d782c8c2d1d44bb55a99bc against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbczhc%2Fsimple-http-server-rust" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/bczhc/simple-http-server-rust on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/bczhc/simple-http-server-rust [INFO] finished tweaking git repo https://github.com/bczhc/simple-http-server-rust [INFO] tweaked toml for git repo https://github.com/bczhc/simple-http-server-rust written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/bczhc/simple-http-server-rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8ceb6f905318a3c7d3e1f444abfa4b0ff545a67f5c3e673835130e4216c524e9 [INFO] running `Command { std: "docker" "start" "-a" "8ceb6f905318a3c7d3e1f444abfa4b0ff545a67f5c3e673835130e4216c524e9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8ceb6f905318a3c7d3e1f444abfa4b0ff545a67f5c3e673835130e4216c524e9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8ceb6f905318a3c7d3e1f444abfa4b0ff545a67f5c3e673835130e4216c524e9", kill_on_drop: false }` [INFO] [stdout] 8ceb6f905318a3c7d3e1f444abfa4b0ff545a67f5c3e673835130e4216c524e9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1f13017f5088db96b3a851d008bf069e91e164e4e0f6d26883c13c4567549852 [INFO] running `Command { std: "docker" "start" "-a" "1f13017f5088db96b3a851d008bf069e91e164e4e0f6d26883c13c4567549852", kill_on_drop: false }` [INFO] [stderr] Checking simple-http-server v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `SocketAddrV4` [INFO] [stdout] --> src/main.rs:3:28 [INFO] [stdout] | [INFO] [stdout] 3 | use std::net::{SocketAddr, SocketAddrV4, TcpListener, TcpStream}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::sync::Arc` [INFO] [stdout] --> src/main.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::sync::Arc; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `RecvError` [INFO] [stdout] --> src/thread_pool.rs:1:32 [INFO] [stdout] | [INFO] [stdout] 1 | use std::sync::mpsc::{channel, RecvError, SendError, Sender}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `SocketAddrV4` [INFO] [stdout] --> src/main.rs:3:28 [INFO] [stdout] | [INFO] [stdout] 3 | use std::net::{SocketAddr, SocketAddrV4, TcpListener, TcpStream}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::sync::Arc` [INFO] [stdout] --> src/main.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::sync::Arc; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `RecvError` [INFO] [stdout] --> src/thread_pool.rs:1:32 [INFO] [stdout] | [INFO] [stdout] 1 | use std::sync::mpsc::{channel, RecvError, SendError, Sender}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `Message` is more private than the item `ThreadPoolError::SendTaskError::0` [INFO] [stdout] --> src/thread_pool.rs:72:19 [INFO] [stdout] | [INFO] [stdout] 72 | SendTaskError(SendError), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ field `ThreadPoolError::SendTaskError::0` is reachable at visibility `pub(crate)` [INFO] [stdout] | [INFO] [stdout] note: but type `Message` is only usable at visibility `pub(self)` [INFO] [stdout] --> src/thread_pool.rs:65:1 [INFO] [stdout] | [INFO] [stdout] 65 | enum Message { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(private_interfaces)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/thread_pool.rs:72:19 [INFO] [stdout] | [INFO] [stdout] 72 | SendTaskError(SendError), [INFO] [stdout] | ------------- ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `ThreadPoolError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 72 | SendTaskError(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thread_pool.rs:36:22 [INFO] [stdout] | [INFO] [stdout] 15 | let (queue_sender, queue_receiver): (Sender, _) = channel(); [INFO] [stdout] | ------------ -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | let queue_receiver = Arc::new(Mutex::new(queue_receiver)); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | [INFO] [stdout] 18 | let mut threads: Vec> = Vec::with_capacity(n); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | threads: Some(threads), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/thread_pool.rs:54:17 [INFO] [stdout] | [INFO] [stdout] 54 | self.queue_sender.send(Message::Terminate); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 54 | let _ = self.queue_sender.send(Message::Terminate); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `Message` is more private than the item `ThreadPoolError::SendTaskError::0` [INFO] [stdout] --> src/thread_pool.rs:72:19 [INFO] [stdout] | [INFO] [stdout] 72 | SendTaskError(SendError), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ field `ThreadPoolError::SendTaskError::0` is reachable at visibility `pub(crate)` [INFO] [stdout] | [INFO] [stdout] note: but type `Message` is only usable at visibility `pub(self)` [INFO] [stdout] --> src/thread_pool.rs:65:1 [INFO] [stdout] | [INFO] [stdout] 65 | enum Message { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(private_interfaces)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/thread_pool.rs:72:19 [INFO] [stdout] | [INFO] [stdout] 72 | SendTaskError(SendError), [INFO] [stdout] | ------------- ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `ThreadPoolError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 72 | SendTaskError(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thread_pool.rs:36:22 [INFO] [stdout] | [INFO] [stdout] 15 | let (queue_sender, queue_receiver): (Sender, _) = channel(); [INFO] [stdout] | ------------ -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | let queue_receiver = Arc::new(Mutex::new(queue_receiver)); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | [INFO] [stdout] 18 | let mut threads: Vec> = Vec::with_capacity(n); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | threads: Some(threads), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/thread_pool.rs:54:17 [INFO] [stdout] | [INFO] [stdout] 54 | self.queue_sender.send(Message::Terminate); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 54 | let _ = self.queue_sender.send(Message::Terminate); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `simple-http-server` (bin "simple-http-server") due to 2 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `simple-http-server` (bin "simple-http-server" test) due to 2 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "1f13017f5088db96b3a851d008bf069e91e164e4e0f6d26883c13c4567549852", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1f13017f5088db96b3a851d008bf069e91e164e4e0f6d26883c13c4567549852", kill_on_drop: false }` [INFO] [stdout] 1f13017f5088db96b3a851d008bf069e91e164e4e0f6d26883c13c4567549852