[INFO] cloning repository https://github.com/bchallenor/firebreak [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/bchallenor/firebreak" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbchallenor%2Ffirebreak", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbchallenor%2Ffirebreak'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 40d765a0ee68d108d1b2abc9f40d4dce9010c883 [INFO] checking bchallenor/firebreak/40d765a0ee68d108d1b2abc9f40d4dce9010c883 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbchallenor%2Ffirebreak" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/bchallenor/firebreak on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/bchallenor/firebreak [INFO] finished tweaking git repo https://github.com/bchallenor/firebreak [INFO] tweaked toml for git repo https://github.com/bchallenor/firebreak written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/bchallenor/firebreak already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 13d0e909228be901426f202ca7fee135e7380049e5d31311df46cf63520f6fa5 [INFO] running `Command { std: "docker" "start" "-a" "13d0e909228be901426f202ca7fee135e7380049e5d31311df46cf63520f6fa5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "13d0e909228be901426f202ca7fee135e7380049e5d31311df46cf63520f6fa5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "13d0e909228be901426f202ca7fee135e7380049e5d31311df46cf63520f6fa5", kill_on_drop: false }` [INFO] [stdout] 13d0e909228be901426f202ca7fee135e7380049e5d31311df46cf63520f6fa5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7ae4319d5b671299cbe5036752e4f23c5d0939f88eed6ba2d10b1eed93b489d6 [INFO] running `Command { std: "docker" "start" "-a" "7ae4319d5b671299cbe5036752e4f23c5d0939f88eed6ba2d10b1eed93b489d6", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.48 [INFO] [stderr] Compiling proc-macro-hack v0.5.19 [INFO] [stderr] Compiling proc-macro-nested v0.1.6 [INFO] [stderr] Checking futures-core v0.3.7 [INFO] [stderr] Checking once_cell v1.4.1 [INFO] [stderr] Checking futures-sink v0.3.7 [INFO] [stderr] Checking futures-io v0.3.7 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Checking regex-syntax v0.6.20 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking mio v0.7.4 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking bytes v0.6.0 [INFO] [stderr] Compiling unindent v0.1.7 [INFO] [stderr] Checking pin-project-lite v0.1.11 [INFO] [stderr] Checking ipnet v2.3.0 [INFO] [stderr] Compiling paste v1.0.2 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking futures-channel v0.3.7 [INFO] [stderr] Checking futures-task v0.3.7 [INFO] [stderr] Compiling indoc v1.0.3 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Checking regex v1.4.1 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Compiling pin-project-internal v1.0.1 [INFO] [stderr] Compiling futures-macro v0.3.7 [INFO] [stderr] Compiling tokio-macros v0.3.1 [INFO] [stderr] Compiling async-trait v0.1.41 [INFO] [stderr] Checking tokio v0.3.2 [INFO] [stderr] Checking pin-project v1.0.1 [INFO] [stderr] Checking futures-util v0.3.7 [INFO] [stderr] Checking futures-executor v0.3.7 [INFO] [stderr] Checking futures v0.3.7 [INFO] [stderr] Checking firebreak v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: methods `source_name`, `source_addr`, `target_name`, `target_addr`, and `connect` are never used [INFO] [stdout] --> src/conn/mod.rs:11:8 [INFO] [stdout] | [INFO] [stdout] 10 | pub trait ConnPath: Sync { [INFO] [stdout] | -------- methods in this trait [INFO] [stdout] 11 | fn source_name(&self) -> &str; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 12 | fn source_addr(&self) -> IpAddr; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 13 | fn target_name(&self) -> &str; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 14 | fn target_addr(&self) -> IpAddr; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 15 | [INFO] [stdout] 16 | async fn connect(&self, spec: ConnSpec) -> Result; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `Tcp` and `Udp` are never constructed [INFO] [stdout] --> src/conn/mod.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 20 | pub enum ConnSpec { [INFO] [stdout] | -------- variants in this enum [INFO] [stdout] 21 | Tcp { port: u16 }, [INFO] [stdout] | ^^^ [INFO] [stdout] 22 | Udp { port: u16 }, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ConnSpec` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple associated items are never used [INFO] [stdout] --> src/host/mod.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 12 | pub trait Host: Sized { [INFO] [stdout] | ---- associated items in this trait [INFO] [stdout] ... [INFO] [stdout] 15 | fn new(name: String) -> Result; [INFO] [stdout] | ^^^ [INFO] [stdout] 16 | [INFO] [stdout] 17 | fn name(&self) -> &str; [INFO] [stdout] | ^^^^ [INFO] [stdout] 18 | fn new_interface( [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 24 | fn load_nft_rules(&mut self, rules: R) -> Result<(), io::Error>; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 25 | fn list_nft_rules(&self) -> Result; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 26 | [INFO] [stdout] 27 | fn input_path<'a>( [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 31 | fn output_path<'a>( [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 35 | fn forward_path<'a>( [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `name`, `addr_with_net`, and `addr` are never used [INFO] [stdout] --> src/host/mod.rs:42:8 [INFO] [stdout] | [INFO] [stdout] 41 | pub trait Interface: Sized { [INFO] [stdout] | --------- methods in this trait [INFO] [stdout] 42 | fn name(&self) -> &str; [INFO] [stdout] | ^^^^ [INFO] [stdout] 43 | fn addr_with_net(&self) -> IpNet; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 44 | fn addr(&self) -> IpAddr { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/conn/os.rs:197:14 [INFO] [stdout] | [INFO] [stdout] 197 | async fn server(&self, socket: TcpListener) -> Result { [INFO] [stdout] | ^ ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | ______________| [INFO] [stdout] | | [INFO] [stdout] 198 | | let (mut stream, peer_addr) = socket.accept().await?; [INFO] [stdout] 199 | | debug!("Accepted connection"); [INFO] [stdout] 200 | | let cookie = stream.read_u128().await?; [INFO] [stdout] ... | [INFO] [stdout] 205 | | })) [INFO] [stdout] 206 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/conn/os.rs:250:14 [INFO] [stdout] | [INFO] [stdout] 250 | async fn server(&self, socket: UdpSocket) -> Result { [INFO] [stdout] | ^ ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | ______________| [INFO] [stdout] | | [INFO] [stdout] 251 | | let mut buf = 0u128.to_be_bytes(); [INFO] [stdout] 252 | | let (size, peer_addr) = socket.recv_from(&mut buf).await?; [INFO] [stdout] 253 | | debug!("Received packet"); [INFO] [stdout] ... | [INFO] [stdout] 260 | | })) [INFO] [stdout] 261 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/host/os.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 31 | let mut ns = OsNs::new_net()?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | Ok(OsHost { name, ns }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/host/os.rs:59:12 [INFO] [stdout] | [INFO] [stdout] 48 | let mut peer_ns = OsNs::new_net()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | Ok(OsInterface { [INFO] [stdout] | ____________^ [INFO] [stdout] 60 | | name, [INFO] [stdout] 61 | | addr_with_net, [INFO] [stdout] 62 | | peer_name, [INFO] [stdout] 63 | | peer_ns, [INFO] [stdout] 64 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/os.rs:63:16 [INFO] [stdout] | [INFO] [stdout] 56 | let fd = OpenOptions::new().read(true).open(current_path)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | let fd_path = PathBuf::from(format!( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | Ok(OsNs { fd, fd_path }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/os.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 73 | pub fn scoped<'a, F, T>(&self, f: F) -> Result [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | crossbeam_utils::thread::scope(|s| self.spawn_scoped(s, f).join().unwrap()).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/os.rs:79:44 [INFO] [stdout] | [INFO] [stdout] 73 | pub fn scoped<'a, F, T>(&self, f: F) -> Result [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | crossbeam_utils::thread::scope(|s| self.spawn_scoped(s, f).join().unwrap()).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/os.rs:92:17 [INFO] [stdout] | [INFO] [stdout] 85 | f: F, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | s.spawn(move |_| { [INFO] [stdout] | _________________^ [INFO] [stdout] 93 | | unsafe { [INFO] [stdout] 94 | | let res = libc::setns(self.fd.as_raw_fd(), 0); [INFO] [stdout] 95 | | if res == -1 { [INFO] [stdout] ... | [INFO] [stdout] 101 | | f() [INFO] [stdout] 102 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `firebreak` (bin "firebreak") due to 9 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: methods `source_name`, `target_name`, and `target_addr` are never used [INFO] [stdout] --> src/conn/mod.rs:11:8 [INFO] [stdout] | [INFO] [stdout] 10 | pub trait ConnPath: Sync { [INFO] [stdout] | -------- methods in this trait [INFO] [stdout] 11 | fn source_name(&self) -> &str; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 12 | fn source_addr(&self) -> IpAddr; [INFO] [stdout] 13 | fn target_name(&self) -> &str; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 14 | fn target_addr(&self) -> IpAddr; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `name` is never used [INFO] [stdout] --> src/host/mod.rs:17:8 [INFO] [stdout] | [INFO] [stdout] 12 | pub trait Host: Sized { [INFO] [stdout] | ---- method in this trait [INFO] [stdout] ... [INFO] [stdout] 17 | fn name(&self) -> &str; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `name`, `addr_with_net`, and `addr` are never used [INFO] [stdout] --> src/host/mod.rs:42:8 [INFO] [stdout] | [INFO] [stdout] 41 | pub trait Interface: Sized { [INFO] [stdout] | --------- methods in this trait [INFO] [stdout] 42 | fn name(&self) -> &str; [INFO] [stdout] | ^^^^ [INFO] [stdout] 43 | fn addr_with_net(&self) -> IpNet; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 44 | fn addr(&self) -> IpAddr { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/conn/os.rs:197:14 [INFO] [stdout] | [INFO] [stdout] 197 | async fn server(&self, socket: TcpListener) -> Result { [INFO] [stdout] | ^ ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | ______________| [INFO] [stdout] | | [INFO] [stdout] 198 | | let (mut stream, peer_addr) = socket.accept().await?; [INFO] [stdout] 199 | | debug!("Accepted connection"); [INFO] [stdout] 200 | | let cookie = stream.read_u128().await?; [INFO] [stdout] ... | [INFO] [stdout] 205 | | })) [INFO] [stdout] 206 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/conn/os.rs:250:14 [INFO] [stdout] | [INFO] [stdout] 250 | async fn server(&self, socket: UdpSocket) -> Result { [INFO] [stdout] | ^ ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | ______________| [INFO] [stdout] | | [INFO] [stdout] 251 | | let mut buf = 0u128.to_be_bytes(); [INFO] [stdout] 252 | | let (size, peer_addr) = socket.recv_from(&mut buf).await?; [INFO] [stdout] 253 | | debug!("Received packet"); [INFO] [stdout] ... | [INFO] [stdout] 260 | | })) [INFO] [stdout] 261 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/host/os.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 31 | let mut ns = OsNs::new_net()?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | Ok(OsHost { name, ns }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/host/os.rs:59:12 [INFO] [stdout] | [INFO] [stdout] 48 | let mut peer_ns = OsNs::new_net()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | Ok(OsInterface { [INFO] [stdout] | ____________^ [INFO] [stdout] 60 | | name, [INFO] [stdout] 61 | | addr_with_net, [INFO] [stdout] 62 | | peer_name, [INFO] [stdout] 63 | | peer_ns, [INFO] [stdout] 64 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/os.rs:63:16 [INFO] [stdout] | [INFO] [stdout] 56 | let fd = OpenOptions::new().read(true).open(current_path)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | let fd_path = PathBuf::from(format!( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | Ok(OsNs { fd, fd_path }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/os.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 73 | pub fn scoped<'a, F, T>(&self, f: F) -> Result [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | crossbeam_utils::thread::scope(|s| self.spawn_scoped(s, f).join().unwrap()).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/os.rs:79:44 [INFO] [stdout] | [INFO] [stdout] 73 | pub fn scoped<'a, F, T>(&self, f: F) -> Result [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | crossbeam_utils::thread::scope(|s| self.spawn_scoped(s, f).join().unwrap()).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/os.rs:92:17 [INFO] [stdout] | [INFO] [stdout] 85 | f: F, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | s.spawn(move |_| { [INFO] [stdout] | _________________^ [INFO] [stdout] 93 | | unsafe { [INFO] [stdout] 94 | | let res = libc::setns(self.fd.as_raw_fd(), 0); [INFO] [stdout] 95 | | if res == -1 { [INFO] [stdout] ... | [INFO] [stdout] 101 | | f() [INFO] [stdout] 102 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `firebreak` (bin "firebreak" test) due to 9 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "7ae4319d5b671299cbe5036752e4f23c5d0939f88eed6ba2d10b1eed93b489d6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7ae4319d5b671299cbe5036752e4f23c5d0939f88eed6ba2d10b1eed93b489d6", kill_on_drop: false }` [INFO] [stdout] 7ae4319d5b671299cbe5036752e4f23c5d0939f88eed6ba2d10b1eed93b489d6