[INFO] cloning repository https://github.com/basro/stylance-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/basro/stylance-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbasro%2Fstylance-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbasro%2Fstylance-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ff8679f8da6298b7146295c9691850281f869eb7 [INFO] checking basro/stylance-rs/ff8679f8da6298b7146295c9691850281f869eb7 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbasro%2Fstylance-rs" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/basro/stylance-rs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-4-tc2/source/rust-toolchain.toml [INFO] started tweaking git repo https://github.com/basro/stylance-rs [INFO] finished tweaking git repo https://github.com/basro/stylance-rs [INFO] tweaked toml for git repo https://github.com/basro/stylance-rs written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/basro/stylance-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 85da8222fdb735260c78a10fee14773cd864f838124d7ad4ef66a47d9eca2b6a [INFO] running `Command { std: "docker" "start" "-a" "85da8222fdb735260c78a10fee14773cd864f838124d7ad4ef66a47d9eca2b6a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "85da8222fdb735260c78a10fee14773cd864f838124d7ad4ef66a47d9eca2b6a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "85da8222fdb735260c78a10fee14773cd864f838124d7ad4ef66a47d9eca2b6a", kill_on_drop: false }` [INFO] [stdout] 85da8222fdb735260c78a10fee14773cd864f838124d7ad4ef66a47d9eca2b6a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bb9938521df01ce3288ddcf51bd7dc09c50e2f4d9294c64c6e95ab79c9656c8a [INFO] running `Command { std: "docker" "start" "-a" "bb9938521df01ce3288ddcf51bd7dc09c50e2f4d9294c64c6e95ab79c9656c8a", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.75 [INFO] [stderr] Compiling serde v1.0.194 [INFO] [stderr] Compiling anyhow v1.0.79 [INFO] [stderr] Compiling winnow v0.5.31 [INFO] [stderr] Compiling libc v0.2.151 [INFO] [stderr] Compiling siphasher v1.0.0 [INFO] [stderr] Compiling indexmap v2.1.0 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking clap_builder v4.4.12 [INFO] [stderr] Compiling serde_json v1.0.111 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Checking quote v1.0.35 [INFO] [stderr] Checking syn v2.0.48 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Checking filetime v0.2.23 [INFO] [stderr] Checking inotify v0.9.6 [INFO] [stderr] Checking notify v6.1.1 [INFO] [stderr] Compiling serde_derive v1.0.194 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling clap_derive v4.4.7 [INFO] [stderr] Checking tokio v1.35.1 [INFO] [stderr] Checking clap v4.4.12 [INFO] [stderr] Checking tokio-stream v0.1.14 [INFO] [stderr] Checking serde_spanned v0.6.5 [INFO] [stderr] Checking toml_datetime v0.6.5 [INFO] [stderr] Checking toml_edit v0.21.0 [INFO] [stderr] Checking toml v0.8.8 [INFO] [stderr] Checking stylance-core v0.5.1 (/opt/rustwide/workdir/internal/stylance-core) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> internal/stylance-core/src/class_name_pattern.rs:46:15 [INFO] [stdout] | [INFO] [stdout] 40 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | match parse::parse_pattern(&s) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> internal/stylance-core/src/parse.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 31 | range: impl Into, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | f: impl Parser<&'s str, O, ContextError>, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | ) -> impl Parser<&'s str, &'s str, ContextError> { [INFO] [stdout] 34 | fold_repeat(range, f, || (), |_, _| ()).recognize() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> internal/stylance-core/src/parse.rs:101:5 [INFO] [stdout] | [INFO] [stdout] 98 | let str_char = alt((none_of(['"']).void(), tag("\\\"").void())); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | let str_chars = recognize_repeat(0.., str_char); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | [INFO] [stdout] 101 | preceded('"', cut_err(terminated(str_chars, '"'))).parse_next(input) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> internal/stylance-core/src/parse.rs:108:5 [INFO] [stdout] | [INFO] [stdout] 105 | let str_char = alt((none_of(['\'']).void(), tag("\\'").void())); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | let str_chars = recognize_repeat(0.., str_char); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | [INFO] [stdout] 108 | preceded('\'', cut_err(terminated(str_chars, '\''))).parse_next(input) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> internal/stylance-core/src/parse.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 118 | range: impl Into, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | list: impl ContainsToken, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 123 | / alt(( [INFO] [stdout] 124 | | string.void(), [INFO] [stdout] 125 | | block_comment.void(), [INFO] [stdout] 126 | | line_comment.void(), [INFO] [stdout] ... | [INFO] [stdout] 130 | | take_till(1.., ('\'', '"', '/', '#', list)).void(), [INFO] [stdout] 131 | | )), [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> internal/stylance-core/src/parse.rs:175:5 [INFO] [stdout] | [INFO] [stdout] 170 | let content = alt(( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | delimited(ws, content, ws).parse_next(input) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `stylance-core` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> internal/stylance-core/src/class_name_pattern.rs:46:15 [INFO] [stdout] | [INFO] [stdout] 40 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | match parse::parse_pattern(&s) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> internal/stylance-core/src/parse.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 31 | range: impl Into, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | f: impl Parser<&'s str, O, ContextError>, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | ) -> impl Parser<&'s str, &'s str, ContextError> { [INFO] [stdout] 34 | fold_repeat(range, f, || (), |_, _| ()).recognize() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> internal/stylance-core/src/parse.rs:101:5 [INFO] [stdout] | [INFO] [stdout] 98 | let str_char = alt((none_of(['"']).void(), tag("\\\"").void())); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | let str_chars = recognize_repeat(0.., str_char); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | [INFO] [stdout] 101 | preceded('"', cut_err(terminated(str_chars, '"'))).parse_next(input) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> internal/stylance-core/src/parse.rs:108:5 [INFO] [stdout] | [INFO] [stdout] 105 | let str_char = alt((none_of(['\'']).void(), tag("\\'").void())); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | let str_chars = recognize_repeat(0.., str_char); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | [INFO] [stdout] 108 | preceded('\'', cut_err(terminated(str_chars, '\''))).parse_next(input) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> internal/stylance-core/src/parse.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 118 | range: impl Into, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | list: impl ContainsToken, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 123 | / alt(( [INFO] [stdout] 124 | | string.void(), [INFO] [stdout] 125 | | block_comment.void(), [INFO] [stdout] 126 | | line_comment.void(), [INFO] [stdout] ... | [INFO] [stdout] 130 | | take_till(1.., ('\'', '"', '/', '#', list)).void(), [INFO] [stdout] 131 | | )), [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> internal/stylance-core/src/parse.rs:175:5 [INFO] [stdout] | [INFO] [stdout] 170 | let content = alt(( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | delimited(ws, content, ws).parse_next(input) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `stylance-core` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "bb9938521df01ce3288ddcf51bd7dc09c50e2f4d9294c64c6e95ab79c9656c8a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bb9938521df01ce3288ddcf51bd7dc09c50e2f4d9294c64c6e95ab79c9656c8a", kill_on_drop: false }` [INFO] [stdout] bb9938521df01ce3288ddcf51bd7dc09c50e2f4d9294c64c6e95ab79c9656c8a