[INFO] cloning repository https://github.com/baskerville/fdb [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/baskerville/fdb" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbaskerville%2Ffdb", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbaskerville%2Ffdb'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 379c54f9a765c08c6beec652c5044f6573fe9567 [INFO] checking baskerville/fdb/379c54f9a765c08c6beec652c5044f6573fe9567 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbaskerville%2Ffdb" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/baskerville/fdb on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/baskerville/fdb [INFO] finished tweaking git repo https://github.com/baskerville/fdb [INFO] tweaked toml for git repo https://github.com/baskerville/fdb written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/baskerville/fdb already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 914b6be627830f9e362d3e5c800bd415c32698ed34f11e1b6b745d648193c884 [INFO] running `Command { std: "docker" "start" "-a" "914b6be627830f9e362d3e5c800bd415c32698ed34f11e1b6b745d648193c884", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "914b6be627830f9e362d3e5c800bd415c32698ed34f11e1b6b745d648193c884", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "914b6be627830f9e362d3e5c800bd415c32698ed34f11e1b6b745d648193c884", kill_on_drop: false }` [INFO] [stdout] 914b6be627830f9e362d3e5c800bd415c32698ed34f11e1b6b745d648193c884 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 594631192af2fc5619c9486add5c09a6b79546d2c40e9aeffe931290062fbaf3 [INFO] running `Command { std: "docker" "start" "-a" "594631192af2fc5619c9486add5c09a6b79546d2c40e9aeffe931290062fbaf3", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling libc v0.2.55 [INFO] [stderr] Compiling autocfg v0.1.2 [INFO] [stderr] Compiling syn v0.15.34 [INFO] [stderr] Compiling cc v1.0.37 [INFO] [stderr] Compiling memchr v2.2.0 [INFO] [stderr] Compiling failure_derive v0.1.5 [INFO] [stderr] Compiling serde v1.0.91 [INFO] [stderr] Compiling byteorder v1.3.1 [INFO] [stderr] Compiling backtrace v0.3.18 [INFO] [stderr] Compiling bincode v1.1.4 [INFO] [stderr] Checking lazy_static v1.3.0 [INFO] [stderr] Checking ucd-util v0.1.3 [INFO] [stderr] Compiling regex v1.1.6 [INFO] [stderr] Checking cfg-if v0.1.9 [INFO] [stderr] Checking rustc-demangle v0.1.14 [INFO] [stderr] Checking regex-syntax v0.6.6 [INFO] [stderr] Checking aho-corasick v0.7.3 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking utf8-ranges v1.0.2 [INFO] [stderr] Compiling quote v0.6.12 [INFO] [stderr] Checking unicode-width v0.1.5 [INFO] [stderr] Checking dirs v1.0.5 [INFO] [stderr] Checking getopts v0.2.19 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Compiling backtrace-sys v0.1.28 [INFO] [stderr] Compiling synstructure v0.10.2 [INFO] [stderr] Compiling serde_derive v1.0.91 [INFO] [stderr] Checking failure v0.1.5 [INFO] [stderr] Checking fdb v0.6.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:67:12 [INFO] [stdout] | [INFO] [stdout] 56 | let mut file = OpenOptions::new().write(true).create_new(true).open(&path); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | Ok(Lock(path)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:98:5 [INFO] [stdout] | [INFO] [stdout] 97 | fn get_env(key: &str, default: T) -> T { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | / env::var(key) [INFO] [stdout] 99 | | .ok() [INFO] [stdout] 100 | | .and_then(|val| val.parse::().ok()) [INFO] [stdout] | |______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:100:25 [INFO] [stdout] | [INFO] [stdout] 100 | .and_then(|val| val.parse::().ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:126:5 [INFO] [stdout] | [INFO] [stdout] 125 | let mut f = File::open(path).context("Can't open data file")?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | deserialize_from(&mut f).context("Can't deserialize data").map_err(Into::into) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:134:5 [INFO] [stdout] | [INFO] [stdout] 131 | let mut file = File::create(&new_path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | fs::rename(new_path, path).context("Couldn't rename temporary data file").map_err(Into::into) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fdb` (bin "fdb") due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:67:12 [INFO] [stdout] | [INFO] [stdout] 56 | let mut file = OpenOptions::new().write(true).create_new(true).open(&path); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | Ok(Lock(path)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:98:5 [INFO] [stdout] | [INFO] [stdout] 97 | fn get_env(key: &str, default: T) -> T { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | / env::var(key) [INFO] [stdout] 99 | | .ok() [INFO] [stdout] 100 | | .and_then(|val| val.parse::().ok()) [INFO] [stdout] | |______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:100:25 [INFO] [stdout] | [INFO] [stdout] 100 | .and_then(|val| val.parse::().ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:126:5 [INFO] [stdout] | [INFO] [stdout] 125 | let mut f = File::open(path).context("Can't open data file")?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | deserialize_from(&mut f).context("Can't deserialize data").map_err(Into::into) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:134:5 [INFO] [stdout] | [INFO] [stdout] 131 | let mut file = File::create(&new_path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | fs::rename(new_path, path).context("Couldn't rename temporary data file").map_err(Into::into) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fdb` (bin "fdb" test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "594631192af2fc5619c9486add5c09a6b79546d2c40e9aeffe931290062fbaf3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "594631192af2fc5619c9486add5c09a6b79546d2c40e9aeffe931290062fbaf3", kill_on_drop: false }` [INFO] [stdout] 594631192af2fc5619c9486add5c09a6b79546d2c40e9aeffe931290062fbaf3