[INFO] cloning repository https://github.com/balena-io/takeover [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/balena-io/takeover" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbalena-io%2Ftakeover", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbalena-io%2Ftakeover'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] beb21a1f3109f11a88b31f78fc2dc293f4f96b18 [INFO] checking balena-io/takeover/beb21a1f3109f11a88b31f78fc2dc293f4f96b18 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbalena-io%2Ftakeover" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/balena-io/takeover on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/balena-io/takeover [INFO] finished tweaking git repo https://github.com/balena-io/takeover [INFO] tweaked toml for git repo https://github.com/balena-io/takeover written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/balena-io/takeover already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f1e9575db24f716b6c5d9bbbb8e52d29012a3a01870c06943b8c56aa95b4b734 [INFO] running `Command { std: "docker" "start" "-a" "f1e9575db24f716b6c5d9bbbb8e52d29012a3a01870c06943b8c56aa95b4b734", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f1e9575db24f716b6c5d9bbbb8e52d29012a3a01870c06943b8c56aa95b4b734", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f1e9575db24f716b6c5d9bbbb8e52d29012a3a01870c06943b8c56aa95b4b734", kill_on_drop: false }` [INFO] [stdout] f1e9575db24f716b6c5d9bbbb8e52d29012a3a01870c06943b8c56aa95b4b734 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 37f96dd09c3d419f165270aa443bd3ffb14d88a06b4880f44bfd3a078879dd61 [INFO] running `Command { std: "docker" "start" "-a" "37f96dd09c3d419f165270aa443bd3ffb14d88a06b4880f44bfd3a078879dd61", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Compiling pkg-config v0.3.29 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling serde v1.0.196 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling openssl v0.10.63 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Compiling rustix v0.38.31 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Compiling fs-err v2.11.0 [INFO] [stderr] Compiling serde_json v1.0.113 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling thiserror v1.0.57 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking http v0.2.11 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking anstream v0.6.11 [INFO] [stderr] Checking plain v0.2.3 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking strsim v0.11.0 [INFO] [stderr] Checking indexmap v2.2.3 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking crc v3.0.1 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking rustls-pemfile v1.0.4 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking clap_builder v4.5.0 [INFO] [stderr] Checking encoding_rs v0.8.33 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Checking semver-parser v0.7.0 [INFO] [stderr] Checking either v1.10.0 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking paw-raw v1.0.0 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Checking semver v0.9.0 [INFO] [stderr] Checking finder v0.1.6 [INFO] [stderr] Checking file_diff v1.0.0 [INFO] [stderr] Checking chrono v0.4.34 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Checking socket2 v0.5.5 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking nix v0.27.1 [INFO] [stderr] Checking filetime v0.2.23 [INFO] [stderr] Checking colored v1.9.4 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking regex-automata v0.4.5 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking tokio v1.36.0 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking xattr v1.3.1 [INFO] [stderr] Checking which v6.0.0 [INFO] [stderr] Checking tar v0.4.40 [INFO] [stderr] Compiling openssl-src v300.2.2+3.2.1 [INFO] [stderr] Compiling openssl-sys v0.9.99 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Checking mod_logger v0.8.4 [INFO] [stderr] Compiling paw-attributes v1.0.2 [INFO] [stderr] Compiling serde_derive v1.0.196 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling scroll_derive v0.12.0 [INFO] [stderr] Compiling thiserror-impl v1.0.57 [INFO] [stderr] Compiling clap_derive v4.5.0 [INFO] [stderr] Checking paw v1.0.0 [INFO] [stderr] Checking scroll v0.12.0 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Checking goblin v0.8.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking clap v4.5.0 [INFO] [stderr] Checking h2 v0.3.24 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking lddtree v0.3.4 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking serde_yaml v0.8.26 [INFO] [stderr] Checking gptman v1.1.2 [INFO] [stderr] Checking hyper v0.14.28 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.24 [INFO] [stderr] Checking takeover v0.8.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: methods `error` and `error_with_kind` are never used [INFO] [stdout] --> src/common/error.rs:170:8 [INFO] [stdout] | [INFO] [stdout] 169 | pub trait ToError { [INFO] [stdout] | ------- methods in this trait [INFO] [stdout] 170 | fn error(self) -> Result; [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 173 | fn error_with_kind(self, kind: ErrorKind) -> Result; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `is_partition` and `set_mountpoint` are never used [INFO] [stdout] --> src/stage1/block_device_info/block_device.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 9 | pub(crate) trait BlockDevice { [INFO] [stdout] | ----------- methods in this trait [INFO] [stdout] ... [INFO] [stdout] 15 | fn is_partition(&self) -> bool; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 16 | fn set_mountpoint(&mut self, mountpoint: Mount); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:223:11 [INFO] [stdout] | [INFO] [stdout] 222 | pub fn dir_exists>(name: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 223 | match stat(name) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:317:5 [INFO] [stdout] | [INFO] [stdout] 315 | pub(crate) fn path_to_cstring>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 316 | let temp: OsString = path.as_ref().into(); [INFO] [stdout] 317 | CString::new(temp.as_bytes()).upstream_with_context(&format!( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/error.rs:81:20 [INFO] [stdout] | [INFO] [stdout] 77 | cause: Box, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | cause: Some(cause), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/error.rs:93:20 [INFO] [stdout] | [INFO] [stdout] 89 | cause: Box, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | cause: Some(cause), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/error.rs:105:20 [INFO] [stdout] | [INFO] [stdout] 100 | cause: Box, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | cause: Some(cause), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/error.rs:116:20 [INFO] [stdout] | [INFO] [stdout] 111 | cause: Box, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | cause: Some(cause), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/disk_util.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 42 | pub fn from_device>(device_path: P) -> Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | Disk::from_drive_file(device_path, None)?.get_label() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/disk_util.rs:149:12 [INFO] [stdout] | [INFO] [stdout] 148 | pub fn from_gzip_stream(stream: R) -> Result { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | Ok(Disk { [INFO] [stdout] | ____________^ [INFO] [stdout] 150 | | disk: Box::new(GZipStream::new(stream)?), [INFO] [stdout] 151 | | // writable: false, [INFO] [stdout] 152 | | block_size: DEF_BLOCK_SIZE as u64, [INFO] [stdout] 153 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/disk_util.rs:158:12 [INFO] [stdout] | [INFO] [stdout] 157 | pub fn from_gzip_img>(image: P) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 158 | Ok(Disk { [INFO] [stdout] | ____________^ [INFO] [stdout] 159 | | disk: Box::new(GZipFile::new(image.as_ref())?), [INFO] [stdout] 160 | | // writable: false, [INFO] [stdout] 161 | | block_size: DEF_BLOCK_SIZE as u64, [INFO] [stdout] 162 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/disk_util.rs:170:12 [INFO] [stdout] | [INFO] [stdout] 166 | drive: P, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 170 | Ok(Disk { [INFO] [stdout] | ____________^ [INFO] [stdout] 171 | | disk: Box::new(PlainFile::new(drive.as_ref())?), [INFO] [stdout] 172 | | // writable, [INFO] [stdout] 173 | | block_size: if let Some(block_size) = block_size { [INFO] [stdout] ... | [INFO] [stdout] 177 | | }, [INFO] [stdout] 178 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/disk_util/gzip_file.rs:39:12 [INFO] [stdout] | [INFO] [stdout] 20 | let file = match OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | Ok(file) => file, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | Err(why) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | Ok(GZipFile { [INFO] [stdout] | ____________^ [INFO] [stdout] 40 | | path: path.to_path_buf(), [INFO] [stdout] 41 | | decoder: GzDecoder::new(file), [INFO] [stdout] 42 | | bytes_read: 0, [INFO] [stdout] 43 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/disk_util/gzip_stream.rs:20:12 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn new(stream: R) -> Result> { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | Ok(GZipStream { [INFO] [stdout] | ____________^ [INFO] [stdout] 21 | | decoder: GzDecoder::new(stream), [INFO] [stdout] 22 | | bytes_read: 0, [INFO] [stdout] 23 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/disk_util/plain_file.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 14 | let file = match OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | Ok(file) => file, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | Err(why) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | Ok(PlainFile { [INFO] [stdout] | ____________^ [INFO] [stdout] 34 | | path: path.to_path_buf(), [INFO] [stdout] 35 | | file, [INFO] [stdout] 36 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stage1/backup/config.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 21 | pub(crate) fn backup_cfg_from_file>(file: P) -> Result> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | / serde_yaml::from_str( [INFO] [stdout] 23 | | &read_to_string(file.as_ref()).upstream_with_context(&format!( [INFO] [stdout] 24 | | "Failed to read backup configuration from file: '{}'", [INFO] [stdout] 25 | | file.as_ref().display() [INFO] [stdout] 26 | | ))?, [INFO] [stdout] 27 | | ) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stage1/backup/rust_tar_archiver.rs:19:12 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new>(file: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | Ok(RustTarArchiver { [INFO] [stdout] | ____________^ [INFO] [stdout] 20 | | archive: Builder::new(GzEncoder::new( [INFO] [stdout] 21 | | File::create(file.as_ref()).upstream_with_context(&format!( [INFO] [stdout] 22 | | "Failed to create backup in file '{}'", [INFO] [stdout] ... | [INFO] [stdout] 26 | | )), [INFO] [stdout] 27 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stage1/migrate_info.rs:259:19 [INFO] [stdout] | [INFO] [stdout] 259 | match patch_device_type(&api_endpoint, &api_key, change_to, &uuid) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `error` and `error_with_kind` are never used [INFO] [stdout] --> src/common/error.rs:170:8 [INFO] [stdout] | [INFO] [stdout] 169 | pub trait ToError { [INFO] [stdout] | ------- methods in this trait [INFO] [stdout] 170 | fn error(self) -> Result; [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 173 | fn error_with_kind(self, kind: ErrorKind) -> Result; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `is_partition` and `set_mountpoint` are never used [INFO] [stdout] --> src/stage1/block_device_info/block_device.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 9 | pub(crate) trait BlockDevice { [INFO] [stdout] | ----------- methods in this trait [INFO] [stdout] ... [INFO] [stdout] 15 | fn is_partition(&self) -> bool; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 16 | fn set_mountpoint(&mut self, mountpoint: Mount); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stage1/migrate_info.rs:267:12 [INFO] [stdout] | [INFO] [stdout] 61 | let device = get_device(opts)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | Err(why) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 267 | Ok(MigrateInfo { [INFO] [stdout] | ____________^ [INFO] [stdout] 268 | | // assets: Assets::new(), [INFO] [stdout] 269 | | os_name: get_os_name()?, [INFO] [stdout] 270 | | to_dir: None, [INFO] [stdout] ... | [INFO] [stdout] 279 | | backup, [INFO] [stdout] 280 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:223:11 [INFO] [stdout] | [INFO] [stdout] 222 | pub fn dir_exists>(name: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 223 | match stat(name) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:317:5 [INFO] [stdout] | [INFO] [stdout] 315 | pub(crate) fn path_to_cstring>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 316 | let temp: OsString = path.as_ref().into(); [INFO] [stdout] 317 | CString::new(temp.as_bytes()).upstream_with_context(&format!( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stage1/api_calls.rs:192:8 [INFO] [stdout] | [INFO] [stdout] 155 | let headers = get_header(api_key)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 178 | let res = Client::builder() [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 192 | Ok(Box::new(res)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stage1/block_device_info.rs:237:13 [INFO] [stdout] | [INFO] [stdout] 134 | let read_dir = read_dir(&sys_path).upstream_with_context(&format!( [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | let mut device_map: DeviceMap = DeviceMap::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 210 | let mut root_device: Option> = None; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 211 | let mut root_partition: Option> = None; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 237 | Err(Error::with_context( [INFO] [stdout] | _____________^ [INFO] [stdout] 238 | | ErrorKind::InvState, [INFO] [stdout] 239 | | "Failed to find root device", [INFO] [stdout] 240 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/error.rs:81:20 [INFO] [stdout] | [INFO] [stdout] 77 | cause: Box, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | cause: Some(cause), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stage1/block_device_info/partition.rs:138:12 [INFO] [stdout] | [INFO] [stdout] 136 | parent: Rc, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | ) -> Result { [INFO] [stdout] 138 | Ok(Partition { [INFO] [stdout] | ____________^ [INFO] [stdout] 139 | | name: name.to_owned(), [INFO] [stdout] 140 | | device_num, [INFO] [stdout] 141 | | mounted, [INFO] [stdout] 142 | | parent, [INFO] [stdout] 143 | | partition_info: PartitionInfo::new(format!("/dev/{}", name))?, [INFO] [stdout] 144 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/error.rs:93:20 [INFO] [stdout] | [INFO] [stdout] 89 | cause: Box, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | cause: Some(cause), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/error.rs:105:20 [INFO] [stdout] | [INFO] [stdout] 100 | cause: Box, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | cause: Some(cause), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/error.rs:116:20 [INFO] [stdout] | [INFO] [stdout] 111 | cause: Box, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | cause: Some(cause), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/disk_util.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 42 | pub fn from_device>(device_path: P) -> Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | Disk::from_drive_file(device_path, None)?.get_label() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/disk_util.rs:149:12 [INFO] [stdout] | [INFO] [stdout] 148 | pub fn from_gzip_stream(stream: R) -> Result { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | Ok(Disk { [INFO] [stdout] | ____________^ [INFO] [stdout] 150 | | disk: Box::new(GZipStream::new(stream)?), [INFO] [stdout] 151 | | // writable: false, [INFO] [stdout] 152 | | block_size: DEF_BLOCK_SIZE as u64, [INFO] [stdout] 153 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/disk_util.rs:158:12 [INFO] [stdout] | [INFO] [stdout] 157 | pub fn from_gzip_img>(image: P) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 158 | Ok(Disk { [INFO] [stdout] | ____________^ [INFO] [stdout] 159 | | disk: Box::new(GZipFile::new(image.as_ref())?), [INFO] [stdout] 160 | | // writable: false, [INFO] [stdout] 161 | | block_size: DEF_BLOCK_SIZE as u64, [INFO] [stdout] 162 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/disk_util.rs:170:12 [INFO] [stdout] | [INFO] [stdout] 166 | drive: P, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 170 | Ok(Disk { [INFO] [stdout] | ____________^ [INFO] [stdout] 171 | | disk: Box::new(PlainFile::new(drive.as_ref())?), [INFO] [stdout] 172 | | // writable, [INFO] [stdout] 173 | | block_size: if let Some(block_size) = block_size { [INFO] [stdout] ... | [INFO] [stdout] 177 | | }, [INFO] [stdout] 178 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/disk_util/gzip_file.rs:39:12 [INFO] [stdout] | [INFO] [stdout] 20 | let file = match OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | Ok(file) => file, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | Err(why) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | Ok(GZipFile { [INFO] [stdout] | ____________^ [INFO] [stdout] 40 | | path: path.to_path_buf(), [INFO] [stdout] 41 | | decoder: GzDecoder::new(file), [INFO] [stdout] 42 | | bytes_read: 0, [INFO] [stdout] 43 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/disk_util/gzip_stream.rs:20:12 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn new(stream: R) -> Result> { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | Ok(GZipStream { [INFO] [stdout] | ____________^ [INFO] [stdout] 21 | | decoder: GzDecoder::new(stream), [INFO] [stdout] 22 | | bytes_read: 0, [INFO] [stdout] 23 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/disk_util/plain_file.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 14 | let file = match OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | Ok(file) => file, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | Err(why) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | Ok(PlainFile { [INFO] [stdout] | ____________^ [INFO] [stdout] 34 | | path: path.to_path_buf(), [INFO] [stdout] 35 | | file, [INFO] [stdout] 36 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stage2.rs:1167:11 [INFO] [stdout] | [INFO] [stdout] 1154 | let mut decoder = GzDecoder::new(match File::open(image_path) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1155 | Ok(file) => file, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1156 | Err(why) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1167 | match Command::new(dd_cmd) [INFO] [stdout] | ___________^ [INFO] [stdout] 1168 | | .args([ [INFO] [stdout] 1169 | | &format!("of={}", &target_path.to_string_lossy()), [INFO] [stdout] 1170 | | &format!("bs={}", DD_BLOCK_SIZE), [INFO] [stdout] 1171 | | ]) [INFO] [stdout] 1172 | | .stdin(Stdio::piped()) [INFO] [stdout] 1173 | | .spawn() [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stage1/backup/config.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 21 | pub(crate) fn backup_cfg_from_file>(file: P) -> Result> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | / serde_yaml::from_str( [INFO] [stdout] 23 | | &read_to_string(file.as_ref()).upstream_with_context(&format!( [INFO] [stdout] 24 | | "Failed to read backup configuration from file: '{}'", [INFO] [stdout] 25 | | file.as_ref().display() [INFO] [stdout] 26 | | ))?, [INFO] [stdout] 27 | | ) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stage1/backup/rust_tar_archiver.rs:19:12 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new>(file: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | Ok(RustTarArchiver { [INFO] [stdout] | ____________^ [INFO] [stdout] 20 | | archive: Builder::new(GzEncoder::new( [INFO] [stdout] 21 | | File::create(file.as_ref()).upstream_with_context(&format!( [INFO] [stdout] 22 | | "Failed to create backup in file '{}'", [INFO] [stdout] ... | [INFO] [stdout] 26 | | )), [INFO] [stdout] 27 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stage1/migrate_info.rs:259:19 [INFO] [stdout] | [INFO] [stdout] 259 | match patch_device_type(&api_endpoint, &api_key, change_to, &uuid) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stage1/migrate_info.rs:267:12 [INFO] [stdout] | [INFO] [stdout] 61 | let device = get_device(opts)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | Err(why) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 267 | Ok(MigrateInfo { [INFO] [stdout] | ____________^ [INFO] [stdout] 268 | | // assets: Assets::new(), [INFO] [stdout] 269 | | os_name: get_os_name()?, [INFO] [stdout] 270 | | to_dir: None, [INFO] [stdout] ... | [INFO] [stdout] 279 | | backup, [INFO] [stdout] 280 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stage1/api_calls.rs:192:8 [INFO] [stdout] | [INFO] [stdout] 155 | let headers = get_header(api_key)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 178 | let res = Client::builder() [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 192 | Ok(Box::new(res)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stage1/block_device_info.rs:237:13 [INFO] [stdout] | [INFO] [stdout] 134 | let read_dir = read_dir(&sys_path).upstream_with_context(&format!( [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | let mut device_map: DeviceMap = DeviceMap::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 210 | let mut root_device: Option> = None; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 211 | let mut root_partition: Option> = None; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 237 | Err(Error::with_context( [INFO] [stdout] | _____________^ [INFO] [stdout] 238 | | ErrorKind::InvState, [INFO] [stdout] 239 | | "Failed to find root device", [INFO] [stdout] 240 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stage1/block_device_info/partition.rs:138:12 [INFO] [stdout] | [INFO] [stdout] 136 | parent: Rc, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | ) -> Result { [INFO] [stdout] 138 | Ok(Partition { [INFO] [stdout] | ____________^ [INFO] [stdout] 139 | | name: name.to_owned(), [INFO] [stdout] 140 | | device_num, [INFO] [stdout] 141 | | mounted, [INFO] [stdout] 142 | | parent, [INFO] [stdout] 143 | | partition_info: PartitionInfo::new(format!("/dev/{}", name))?, [INFO] [stdout] 144 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stage2.rs:1167:11 [INFO] [stdout] | [INFO] [stdout] 1154 | let mut decoder = GzDecoder::new(match File::open(image_path) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1155 | Ok(file) => file, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1156 | Err(why) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1167 | match Command::new(dd_cmd) [INFO] [stdout] | ___________^ [INFO] [stdout] 1168 | | .args([ [INFO] [stdout] 1169 | | &format!("of={}", &target_path.to_string_lossy()), [INFO] [stdout] 1170 | | &format!("bs={}", DD_BLOCK_SIZE), [INFO] [stdout] 1171 | | ]) [INFO] [stdout] 1172 | | .stdin(Stdio::piped()) [INFO] [stdout] 1173 | | .spawn() [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 21 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `takeover` (bin "takeover") due to 22 previous errors; 2 warnings emitted [INFO] [stdout] error: aborting due to 21 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `takeover` (bin "takeover" test) due to 22 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "37f96dd09c3d419f165270aa443bd3ffb14d88a06b4880f44bfd3a078879dd61", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "37f96dd09c3d419f165270aa443bd3ffb14d88a06b4880f44bfd3a078879dd61", kill_on_drop: false }` [INFO] [stdout] 37f96dd09c3d419f165270aa443bd3ffb14d88a06b4880f44bfd3a078879dd61