[INFO] cloning repository https://github.com/bakaq/formula-parser [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/bakaq/formula-parser" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbakaq%2Fformula-parser", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbakaq%2Fformula-parser'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d99f8a6407f893c612cc501d2dd7389cb08ca50c [INFO] checking bakaq/formula-parser/d99f8a6407f893c612cc501d2dd7389cb08ca50c against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbakaq%2Fformula-parser" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/bakaq/formula-parser on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/bakaq/formula-parser [INFO] finished tweaking git repo https://github.com/bakaq/formula-parser [INFO] tweaked toml for git repo https://github.com/bakaq/formula-parser written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/bakaq/formula-parser already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cf5708c5a530cfeec055b370d66e9b45cc37f6bbaa81bc3244b51ff9ccbfdb5e [INFO] running `Command { std: "docker" "start" "-a" "cf5708c5a530cfeec055b370d66e9b45cc37f6bbaa81bc3244b51ff9ccbfdb5e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cf5708c5a530cfeec055b370d66e9b45cc37f6bbaa81bc3244b51ff9ccbfdb5e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cf5708c5a530cfeec055b370d66e9b45cc37f6bbaa81bc3244b51ff9ccbfdb5e", kill_on_drop: false }` [INFO] [stdout] cf5708c5a530cfeec055b370d66e9b45cc37f6bbaa81bc3244b51ff9ccbfdb5e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 83151704fffe245bd82ea89580e6577fbbf1c0a4aa417022f08556c17e5d8068 [INFO] running `Command { std: "docker" "start" "-a" "83151704fffe245bd82ea89580e6577fbbf1c0a4aa417022f08556c17e5d8068", kill_on_drop: false }` [INFO] [stderr] Checking formula-parser v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: irrefutable `if let` pattern [INFO] [stdout] --> src/parser.rs:25:16 [INFO] [stdout] | [INFO] [stdout] 25 | if let ASTvalue::Int(int_value) = value { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `if let` is useless [INFO] [stdout] = help: consider replacing the `if let` with a `let` [INFO] [stdout] = note: `#[warn(irrefutable_let_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: irrefutable `if let` pattern [INFO] [stdout] --> src/parser.rs:82:36 [INFO] [stdout] | [INFO] [stdout] 82 | ... if let TokenValue::Int(n) = tok.value.as_ref().unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `if let` is useless [INFO] [stdout] = help: consider replacing the `if let` with a `let` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: irrefutable `if let` pattern [INFO] [stdout] --> src/parser.rs:25:16 [INFO] [stdout] | [INFO] [stdout] 25 | if let ASTvalue::Int(int_value) = value { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `if let` is useless [INFO] [stdout] = help: consider replacing the `if let` with a `let` [INFO] [stdout] = note: `#[warn(irrefutable_let_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: irrefutable `if let` pattern [INFO] [stdout] --> src/parser.rs:82:36 [INFO] [stdout] | [INFO] [stdout] 82 | ... if let TokenValue::Int(n) = tok.value.as_ref().unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `if let` is useless [INFO] [stdout] = help: consider replacing the `if let` with a `let` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/interpreter.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | _ => panic!("Deu merda!") [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/interpreter.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 5 | ASTtype::Add => { [INFO] [stdout] | ------------ matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 8 | ASTtype::Subtract => { [INFO] [stdout] | ----------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 11 | ASTtype::Multiply => { [INFO] [stdout] | ----------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 14 | ASTtype::Divide => { [INFO] [stdout] | --------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 21 | _ => panic!("Deu merda!") [INFO] [stdout] | ^ ...and 1 other patterns collectively make this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/interpreter.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | _ => panic!("Deu merda!") [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/interpreter.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 5 | ASTtype::Add => { [INFO] [stdout] | ------------ matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 8 | ASTtype::Subtract => { [INFO] [stdout] | ----------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 11 | ASTtype::Multiply => { [INFO] [stdout] | ----------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 14 | ASTtype::Divide => { [INFO] [stdout] | --------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 21 | _ => panic!("Deu merda!") [INFO] [stdout] | ^ ...and 1 other patterns collectively make this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/interpreter.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 18 | ASTvalue::Int(x) => *x, [INFO] [stdout] | ---------------- matches all the relevant values [INFO] [stdout] 19 | _ => panic!("Deu merda!") [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new_unary` is never used [INFO] [stdout] --> src/parser.rs:59:8 [INFO] [stdout] | [INFO] [stdout] 47 | impl ASTnode { [INFO] [stdout] | ------------ associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 59 | fn new_unary(op: ASTtype, left: Option>, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/interpreter.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 18 | ASTvalue::Int(x) => *x, [INFO] [stdout] | ---------------- matches all the relevant values [INFO] [stdout] 19 | _ => panic!("Deu merda!") [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new_unary` is never used [INFO] [stdout] --> src/parser.rs:59:8 [INFO] [stdout] | [INFO] [stdout] 47 | impl ASTnode { [INFO] [stdout] | ------------ associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 59 | fn new_unary(op: ASTtype, left: Option>, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:61:32 [INFO] [stdout] | [INFO] [stdout] 59 | fn new_unary(op: ASTtype, left: Option>, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | value: Option) -> ASTnode { [INFO] [stdout] 61 | ASTnode::new(op, left, None, value) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `interpret_AST` should have a snake case name [INFO] [stdout] --> src/interpreter.rs:3:4 [INFO] [stdout] | [INFO] [stdout] 3 | fn interpret_AST(node: &ASTnode) -> u32 { [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `interpret_ast` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:61:32 [INFO] [stdout] | [INFO] [stdout] 59 | fn new_unary(op: ASTtype, left: Option>, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | value: Option) -> ASTnode { [INFO] [stdout] 61 | ASTnode::new(op, left, None, value) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `interpret_AST` should have a snake case name [INFO] [stdout] --> src/interpreter.rs:3:4 [INFO] [stdout] | [INFO] [stdout] 3 | fn interpret_AST(node: &ASTnode) -> u32 { [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `interpret_ast` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `formula-parser` (bin "formula-parser") due to 2 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `formula-parser` (bin "formula-parser" test) due to 2 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "83151704fffe245bd82ea89580e6577fbbf1c0a4aa417022f08556c17e5d8068", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "83151704fffe245bd82ea89580e6577fbbf1c0a4aa417022f08556c17e5d8068", kill_on_drop: false }` [INFO] [stdout] 83151704fffe245bd82ea89580e6577fbbf1c0a4aa417022f08556c17e5d8068