[INFO] cloning repository https://github.com/azaika/mini-prolog [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/azaika/mini-prolog" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fazaika%2Fmini-prolog", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fazaika%2Fmini-prolog'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d29407106eb24cbd3ecf2550e94638db2642d825 [INFO] checking azaika/mini-prolog/d29407106eb24cbd3ecf2550e94638db2642d825 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fazaika%2Fmini-prolog" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/azaika/mini-prolog on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/azaika/mini-prolog [INFO] finished tweaking git repo https://github.com/azaika/mini-prolog [INFO] tweaked toml for git repo https://github.com/azaika/mini-prolog written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/azaika/mini-prolog already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 6 packages to latest compatible versions [INFO] [stderr] Adding ansi_term v0.12.1 [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding strsim v0.8.0 (latest: v0.11.1) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] [stderr] Adding unicode-width v0.1.13 [INFO] [stderr] Adding vec_map v0.8.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 62fe15848dbaf2efe14c5da6f3580aaf82c71839f42875e2415d1be0b2c4eb2c [INFO] running `Command { std: "docker" "start" "-a" "62fe15848dbaf2efe14c5da6f3580aaf82c71839f42875e2415d1be0b2c4eb2c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "62fe15848dbaf2efe14c5da6f3580aaf82c71839f42875e2415d1be0b2c4eb2c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "62fe15848dbaf2efe14c5da6f3580aaf82c71839f42875e2415d1be0b2c4eb2c", kill_on_drop: false }` [INFO] [stdout] 62fe15848dbaf2efe14c5da6f3580aaf82c71839f42875e2415d1be0b2c4eb2c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 46173d0a315f3ed82e816ca7f940134238d8bf22d7f6c97f6b2e72f6dbca27a0 [INFO] running `Command { std: "docker" "start" "-a" "46173d0a315f3ed82e816ca7f940134238d8bf22d7f6c97f6b2e72f6dbca27a0", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.98 [INFO] [stderr] Compiling memchr v2.4.0 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling hashbrown v0.11.2 [INFO] [stderr] Compiling siphasher v0.3.5 [INFO] [stderr] Compiling regex-syntax v0.6.25 [INFO] [stderr] Compiling fixedbitset v0.2.0 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Compiling either v1.6.1 [INFO] [stderr] Compiling bit-set v0.5.2 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling diff v0.1.12 [INFO] [stderr] Compiling pico-args v0.4.2 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling phf_shared v0.8.0 [INFO] [stderr] Compiling itertools v0.10.1 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Compiling indexmap v1.7.0 [INFO] [stderr] Compiling string_cache v0.8.1 [INFO] [stderr] Compiling ena v0.14.0 [INFO] [stderr] Compiling aho-corasick v0.7.18 [INFO] [stderr] Compiling dirs-sys-next v0.1.2 [INFO] [stderr] Compiling atty v0.2.14 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Compiling dirs-next v2.0.0 [INFO] [stderr] Compiling petgraph v0.5.1 [INFO] [stderr] Compiling term v0.7.0 [INFO] [stderr] Compiling ascii-canvas v3.0.0 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking lalrpop-util v0.19.6 [INFO] [stderr] Compiling lalrpop v0.19.6 [INFO] [stderr] Compiling mini-prolog v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::str::FromStr` [INFO] [stdout] --> /opt/rustwide/target/debug/build/mini-prolog-71e26d10d46da030/out/grammer.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::str::FromStr; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::str::FromStr` [INFO] [stdout] --> /opt/rustwide/target/debug/build/mini-prolog-71e26d10d46da030/out/grammer.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::str::FromStr; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast.rs:46:20 [INFO] [stdout] | [INFO] [stdout] 43 | fn rewrite(mut self, table : &HashMap) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | args : self.args.drain(..).map(|t| { Box::new((*t).rewrite(table)) }).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast.rs:46:59 [INFO] [stdout] | [INFO] [stdout] 46 | args : self.args.drain(..).map(|t| { Box::new((*t).rewrite(table)) }).collect() [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast.rs:57:10 [INFO] [stdout] | [INFO] [stdout] 50 | pub fn renew(self, count : usize) -> (Self, usize) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | let mut vars = HashSet::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | (self.rewrite(&table), count + num) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/subst.rs:53:22 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn apply_clause(&self, c : Clause) -> Clause { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | let (p, mut args) = c.decompose(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | Clause::from((p, args)) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/subst.rs:57:71 [INFO] [stdout] | [INFO] [stdout] 57 | let l_s : HashMap<_, _> = latter.0.drain().map(|(v, t)| { (v, self.apply_term(t)) }).collect(); [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> /opt/rustwide/target/debug/build/mini-prolog-71e26d10d46da030/out/grammer.rs:3522:40 [INFO] [stdout] | [INFO] [stdout] 3518 | (_, c, _): (usize, Clause, usize), [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 3522 | ast::Rule{ conclusion : c, conds : VecDeque::new() } [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast.rs:46:20 [INFO] [stdout] | [INFO] [stdout] 43 | fn rewrite(mut self, table : &HashMap) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | args : self.args.drain(..).map(|t| { Box::new((*t).rewrite(table)) }).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast.rs:46:59 [INFO] [stdout] | [INFO] [stdout] 46 | args : self.args.drain(..).map(|t| { Box::new((*t).rewrite(table)) }).collect() [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast.rs:57:10 [INFO] [stdout] | [INFO] [stdout] 50 | pub fn renew(self, count : usize) -> (Self, usize) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | let mut vars = HashSet::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | (self.rewrite(&table), count + num) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/subst.rs:53:22 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn apply_clause(&self, c : Clause) -> Clause { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | let (p, mut args) = c.decompose(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | Clause::from((p, args)) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/subst.rs:57:71 [INFO] [stdout] | [INFO] [stdout] 57 | let l_s : HashMap<_, _> = latter.0.drain().map(|(v, t)| { (v, self.apply_term(t)) }).collect(); [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> /opt/rustwide/target/debug/build/mini-prolog-71e26d10d46da030/out/grammer.rs:3522:40 [INFO] [stdout] | [INFO] [stdout] 3518 | (_, c, _): (usize, Clause, usize), [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 3522 | ast::Rule{ conclusion : c, conds : VecDeque::new() } [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mini-prolog` (bin "mini-prolog" test) due to 7 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mini-prolog` (bin "mini-prolog") due to 7 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "46173d0a315f3ed82e816ca7f940134238d8bf22d7f6c97f6b2e72f6dbca27a0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "46173d0a315f3ed82e816ca7f940134238d8bf22d7f6c97f6b2e72f6dbca27a0", kill_on_drop: false }` [INFO] [stdout] 46173d0a315f3ed82e816ca7f940134238d8bf22d7f6c97f6b2e72f6dbca27a0